dm: remove unlikely() before IS_ERR()
IS_ERR() already contains an 'unlikely' compiler flag so there is no need to do that again from IS_ERR() callers. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
parent
e80d1c805a
commit
fc0a446152
3 changed files with 6 additions and 6 deletions
|
@ -533,7 +533,7 @@ static int read_exceptions(struct pstore *ps,
|
||||||
chunk = area_location(ps, ps->current_area);
|
chunk = area_location(ps, ps->current_area);
|
||||||
|
|
||||||
area = dm_bufio_read(client, chunk, &bp);
|
area = dm_bufio_read(client, chunk, &bp);
|
||||||
if (unlikely(IS_ERR(area))) {
|
if (IS_ERR(area)) {
|
||||||
r = PTR_ERR(area);
|
r = PTR_ERR(area);
|
||||||
goto ret_destroy_bufio;
|
goto ret_destroy_bufio;
|
||||||
}
|
}
|
||||||
|
|
|
@ -267,7 +267,7 @@ static int verity_verify_level(struct dm_verity_io *io, sector_t block,
|
||||||
verity_hash_at_level(v, block, level, &hash_block, &offset);
|
verity_hash_at_level(v, block, level, &hash_block, &offset);
|
||||||
|
|
||||||
data = dm_bufio_read(v->bufio, hash_block, &buf);
|
data = dm_bufio_read(v->bufio, hash_block, &buf);
|
||||||
if (unlikely(IS_ERR(data)))
|
if (IS_ERR(data))
|
||||||
return PTR_ERR(data);
|
return PTR_ERR(data);
|
||||||
|
|
||||||
aux = dm_bufio_get_aux_data(buf);
|
aux = dm_bufio_get_aux_data(buf);
|
||||||
|
|
|
@ -454,7 +454,7 @@ int dm_bm_read_lock(struct dm_block_manager *bm, dm_block_t b,
|
||||||
int r;
|
int r;
|
||||||
|
|
||||||
p = dm_bufio_read(bm->bufio, b, (struct dm_buffer **) result);
|
p = dm_bufio_read(bm->bufio, b, (struct dm_buffer **) result);
|
||||||
if (unlikely(IS_ERR(p)))
|
if (IS_ERR(p))
|
||||||
return PTR_ERR(p);
|
return PTR_ERR(p);
|
||||||
|
|
||||||
aux = dm_bufio_get_aux_data(to_buffer(*result));
|
aux = dm_bufio_get_aux_data(to_buffer(*result));
|
||||||
|
@ -490,7 +490,7 @@ int dm_bm_write_lock(struct dm_block_manager *bm,
|
||||||
return -EPERM;
|
return -EPERM;
|
||||||
|
|
||||||
p = dm_bufio_read(bm->bufio, b, (struct dm_buffer **) result);
|
p = dm_bufio_read(bm->bufio, b, (struct dm_buffer **) result);
|
||||||
if (unlikely(IS_ERR(p)))
|
if (IS_ERR(p))
|
||||||
return PTR_ERR(p);
|
return PTR_ERR(p);
|
||||||
|
|
||||||
aux = dm_bufio_get_aux_data(to_buffer(*result));
|
aux = dm_bufio_get_aux_data(to_buffer(*result));
|
||||||
|
@ -523,7 +523,7 @@ int dm_bm_read_try_lock(struct dm_block_manager *bm,
|
||||||
int r;
|
int r;
|
||||||
|
|
||||||
p = dm_bufio_get(bm->bufio, b, (struct dm_buffer **) result);
|
p = dm_bufio_get(bm->bufio, b, (struct dm_buffer **) result);
|
||||||
if (unlikely(IS_ERR(p)))
|
if (IS_ERR(p))
|
||||||
return PTR_ERR(p);
|
return PTR_ERR(p);
|
||||||
if (unlikely(!p))
|
if (unlikely(!p))
|
||||||
return -EWOULDBLOCK;
|
return -EWOULDBLOCK;
|
||||||
|
@ -559,7 +559,7 @@ int dm_bm_write_lock_zero(struct dm_block_manager *bm,
|
||||||
return -EPERM;
|
return -EPERM;
|
||||||
|
|
||||||
p = dm_bufio_new(bm->bufio, b, (struct dm_buffer **) result);
|
p = dm_bufio_new(bm->bufio, b, (struct dm_buffer **) result);
|
||||||
if (unlikely(IS_ERR(p)))
|
if (IS_ERR(p))
|
||||||
return PTR_ERR(p);
|
return PTR_ERR(p);
|
||||||
|
|
||||||
memset(p, 0, dm_bm_block_size(bm));
|
memset(p, 0, dm_bm_block_size(bm));
|
||||||
|
|
Loading…
Add table
Reference in a new issue