evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[libata] ACPI: remove needless ->qc_issue hook existence test

Browse source 
All drivers must implement this hook, otherwise ATA commands would go
nowhere (and a lot of other oopsen would appear as well).

Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Jeff Garzik 2007-02-24 21:05:01 -05:00
parent ea34e45a46
commit fc16c25ff4
1 changed files with 20 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
drivers/ata/libata-acpi.c
View file

@ -455,6 +455,9 @@ static void taskfile_load_raw(struct ata_port *ap,
struct ata_device *atadev, struct ata_device *atadev,
const struct taskfile_array *gtf) const struct taskfile_array *gtf)
{ {
struct ata_taskfile tf;
unsigned int err;
if (ata_msg_probe(ap)) if (ata_msg_probe(ap))
ata_dev_printk(atadev, KERN_DEBUG, "%s: (0x1f1-1f7): hex: " ata_dev_printk(atadev, KERN_DEBUG, "%s: (0x1f1-1f7): hex: "
"%02x %02x %02x %02x %02x %02x %02x\n", "%02x %02x %02x %02x %02x %02x %02x\n",
@ -467,10 +470,6 @@ static void taskfile_load_raw(struct ata_port *ap,
&& (gtf->tfa[6] == 0)) && (gtf->tfa[6] == 0))
return; return;
if (ap->ops->qc_issue) {
struct ata_taskfile tf;
unsigned int err;
ata_tf_init(atadev, &tf); ata_tf_init(atadev, &tf);
/* convert gtf to tf */ /* convert gtf to tf */
@ -490,12 +489,6 @@ static void taskfile_load_raw(struct ata_port *ap,
ata_dev_printk(atadev, KERN_ERR, ata_dev_printk(atadev, KERN_ERR,
"%s: ata_exec_internal failed: %u\n", "%s: ata_exec_internal failed: %u\n",
__FUNCTION__, err); __FUNCTION__, err);
} else
if (ata_msg_warn(ap))
ata_dev_printk(atadev, KERN_WARNING,
"%s: SATA driver is missing qc_issue function"
" entry points\n",
__FUNCTION__);
} }
/** /**