evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

staging: comedi: das16: remove unnecessary das16_ai_disable()

Browse source 
The das16_ai_disable() function disables interrupts and the pacer clock. This
function is called by the subdevice (*cancel) operation.

The comedi core will not call a subdevice (*insn_read) operation while an
async command is running due to the s->busy check in parse_insn(). Since all
async commands are terminated by a (*cancel), the das16_ai_disable() is not
necessary in das16_ai_insn_read(). Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2015-01-26 16:17:14 -07:00 • committed by Greg Kroah-Hartman
parent 7157fda400
commit fc4e021752
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/staging/comedi/drivers/das16.c
View file

@ -831,8 +831,6 @@ static int das16_ai_insn_read(struct comedi_device *dev,
int ret; int ret;
int i; int i;
das16_ai_disable(dev);
/* set multiplexer */ /* set multiplexer */
outb(chan | (chan << 4), dev->iobase + DAS16_MUX_REG); outb(chan | (chan << 4), dev->iobase + DAS16_MUX_REG);