From fdde54c4d4670a08e5c3ecc60739ac30d7f3bf62 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Mon, 12 Jun 2017 09:16:43 -0600 Subject: [PATCH] drm/msm/rd: split out snapshot_buf helper (reduce the noise in next patch) Change-Id: Ic0dedbadd4b1100ff7b203f120f4acd0c4bf8d09 Signed-off-by: Rob Clark Git-commit: 6507e799f432d9fa86ba398b095ef1139a70deac Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git [jcrouse@codeaurora.org: fixed minor merge conflicts] Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_rd.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c index 2d112f24a902..6490d7112de2 100644 --- a/drivers/gpu/drm/msm/msm_rd.c +++ b/drivers/gpu/drm/msm/msm_rd.c @@ -277,6 +277,24 @@ void msm_rd_debugfs_cleanup(struct drm_minor *minor) kfree(rd); } +static void snapshot_buf(struct msm_rd_state *rd, + struct msm_gem_submit *submit, int idx, + uint64_t iova, uint32_t size) +{ + struct msm_gem_object *obj = submit->bos[idx].obj; + const char *buf; + + buf = msm_gem_vaddr(&obj->base); + if (IS_ERR(buf)) + return; + + buf += iova - submit->bos[idx].iova; + + rd_write_section(rd, RD_GPUADDR, + (uint64_t[2]) { iova, size }, 16); + rd_write_section(rd, RD_BUFFER_CONTENTS, buf, size); +} + /* called under struct_mutex */ void msm_rd_dump_submit(struct msm_gem_submit *submit) { @@ -306,18 +324,11 @@ void msm_rd_dump_submit(struct msm_gem_submit *submit) */ for (i = 0; i < submit->nr_cmds; i++) { - uint32_t idx = submit->cmd[i].idx; uint64_t iova = submit->cmd[i].iova; uint32_t szd = submit->cmd[i].size; /* in dwords */ - struct msm_gem_object *obj = submit->bos[idx].obj; - const char *buf = msm_gem_vaddr(&obj->base); - buf += iova - submit->bos[idx].iova; - - rd_write_section(rd, RD_GPUADDR, - (uint64_t[2]) { iova, szd * 4 }, 16); - rd_write_section(rd, RD_BUFFER_CONTENTS, - buf, szd * 4); + snapshot_buf(rd, submit, submit->cmd[i].idx, + submit->cmd[i].iova, szd * 4); switch (submit->cmd[i].type) { case MSM_SUBMIT_CMD_IB_TARGET_BUF: