From fe3b4ba16e1b3729268d3c7eae0ffd1f17023945 Mon Sep 17 00:00:00 2001 From: Manoj Rao Date: Fri, 23 May 2014 16:13:06 -0700 Subject: [PATCH] msm: mdss: avoid flagging error for retire fence fd For cases such as the rotator interface, flags to indicate retire fence file descriptors are not set. Do not return error while copying these file descriptors for such interfaces. This avoids the driver from setting false positive error flags to user space processes in usecases where retire fence fd is not present. CRs-Fixed: 663793 Change-Id: I7918520764c364ee11f469ea757c38ef46bf93cd Signed-off-by: Manoj Rao --- drivers/video/fbdev/msm/mdss_compat_utils.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/msm/mdss_compat_utils.c b/drivers/video/fbdev/msm/mdss_compat_utils.c index 9df9c97b5328..4c35f799d128 100644 --- a/drivers/video/fbdev/msm/mdss_compat_utils.c +++ b/drivers/video/fbdev/msm/mdss_compat_utils.c @@ -133,8 +133,13 @@ static int mdss_fb_compat_buf_sync(struct fb_info *info, unsigned int cmd, return -EFAULT; if (copy_in_user(compat_ptr(buf_sync32->retire_fen_fd), buf_sync->retire_fen_fd, - sizeof(int))) - return -EFAULT; + sizeof(int))) { + if (buf_sync->flags & MDP_BUF_SYNC_FLAG_RETIRE_FENCE) + return -EFAULT; + else + pr_debug("%s: no retire fence fd for wb\n", + __func__); + } return ret; }