The skb_peek and skb_peek_tail functions can return NULL if the skb
list is empty. Check the return value before using the skb.
CRs-Fixed: 2121368
Change-Id: If14320104ec37b8b7504e930ed8fd06e72d08724
Signed-off-by: Chris Lew <clew@codeaurora.org>
variable rc is not initialized in the beginning of function
ipc_router_mhi_write and ipc_router_mhi_xprt_probe. This leads
possible use without initialization issue.
Initialize variable in the beginning of both functions.
CRs-Fixed: 2209246
Change-Id: Ida0bdad2336be928d6e440d4143350bbf9f253d5
Signed-off-by: Dhoat Harpal <hdhoat@codeaurora.org>
In get_args function their is no NULL pointer check for rpra
variable, that might lead to null pointer dereference. Add
condition to verify.
Change-Id: I0789e8ea875221de5809598419bc7f842aa3e22e
Signed-off-by: Tharun Kumar Merugu <mtharu@codeaurora.org>
The logic to truncate packets if the size is too long was off by one.
Fix the conditional logic for checking lengths.
CRs-Fixed: 2121368
Change-Id: I908bd0a1ab78dea439056dbcd12eb158b2789e4a
Signed-off-by: Chris Lew <clew@codeaurora.org>
Some external hubs cannot enter into test mode if EHSET fixture
is connected to one of its downstream ports. Add support to
enable test modes on any desired downstream port of an external
hub. The port and the test mode can be selected via sysfs nodes.
For example, to send TEST_J packet on downstream port 4 of
external hub 3-1:1.0:
echo 4 > /sys/bus/usb/devices/3-1/3-1\:1.0/test_j_portnum
Change-Id: I145f150bfe8557844cb150cf39fafe03a18bd955
Signed-off-by: Ajay Agarwal <ajaya@codeaurora.org>
Decoder STOP command is to signal HW that this is the EOS
buffer. HW returns all the pending ETB's and FTB's. One of
the FTB_DONE's will have EOS flag back to client. With this,
driver don't need to support zero_bytes_used input buffers.
CRs-Fixed: 2078801
Signed-off-by: Praneeth Paladugu <ppaladug@codeaurora.org>
Change-Id: I44c60db1c98707501b5637eba5d1d81663d6a722
In boards without adv7481 chip present, there is a huge
boot time impact due to long time taken by probe failure
because of I2C communication failures. Add early returns
in case of error, to minimize the impact.
Change-Id: I74643ec8e35e16ba93b795cccd8c709c8e530889
Signed-off-by: Suprith Malligere Shankaregowda <supgow@codeaurora.org>
In diagchar_open() protect the decrement of number of diag clients
so that there will be no race conditions while reading the value
from other functions.
Change-Id: I0e2fb5331eec9c7bba39e7d881b69559256833a3
Signed-off-by: Sreelakshmi Gownipalli <sgownipa@codeaurora.org>
The owner for the driver is not a string. Fix the owner
accordingly.
Change-Id: I5f29cc0ae65714756868a0076f8a8adc6c3d45c2
Signed-off-by: Anant Goel <anantg@codeaurora.org>
The SDM636 GPU is similar to SDM660 but different
because of GPU clock plan. Update SDM636 GPU ID to
A509 so that we can handle it.
Change-Id: I8ed4403a5a11b5cb92827716d8f1e9655403c8bf
Signed-off-by: Hareesh Gundu <hareeshg@codeaurora.org>
This change fixes an unclocked hdmi register access while going
to suspend state.
When splash is enabled on HDMI interface & we are going to turn
on the hdmi bridge power. Context of sde_hdmi connector is found
to be NULL because connector was not initialized yet and we never
called sde_hdmi_core_enable which enables hpd clocks.
Now when going to suspend system would be calling clock unprepare
for clocks which were never enabled. Hence hdmi clock gets unbalanced
and resulted in unclocked access to one of the hdmi register during
disabling vblank.
Adding struct sde_hdmi as a member of struct sde_hdmi_bridge and remove
dependency on sde connector to get the hdmi display object.
Change-Id: If96324fd5152ab0e721dfd38e93a68321a615455
Signed-off-by: Camus Wong <camusw@codeaurora.org>
Signed-off-by: Rahul Sharma <rahsha@codeaurora.org>
Signed-off-by: Suprith Malligere Shankaregowda <supgow@codeaurora.org>
Switch ION type from CARVEOUT to SYSTEM for audio function.
Change-Id: Ida2ccb7d1dbe1a037f305fe749ca3bc0a8dd51b2
Signed-off-by: Yimin Peng <yiminp@codeaurora.org>
make this change to avoid the clk warning logs
remove some redundant codes
Change-Id: Ic2d85ae86c577f7f299061f5936d7b457297f1c4
Signed-off-by: Chunhuan Zhan <zhanc@codeaurora.org>
Store the last MDSS IRQ status value to help identify the source
of any erroneous IRQs that might cause an IRQ storm. Also, check
return codes on IRQ mapping or handling and report any unhandled
IRQs to the IRQ system.
Change-Id: I585c97c01736216556eb389bda79548c1fda2b64
Signed-off-by: Lloyd Atkinson <latkinso@codeaurora.org>
Take the callback spinlock before checking whether the callback
table list is empty. This resolves a race condition where the
callback list could be empty during the servicing of an
interrupt.
Change-Id: I8d59c0211526173ce98c8ca2dac36ec4743dc8f8
Signed-off-by: Lloyd Atkinson <latkinso@codeaurora.org>
Signed-off-by: Lakshmi Narayana Kalavala <lkalaval@codeaurora.org>
Update the sde_dbg_dump function to only dump event log
entries up to the time the dump is initiated, and increase
the number of recorded event log entries.
This places a limit on the total number of entries that are
output to the dmesg log even if more entries would have been
added while the dump is executing (e.g., interrupt events),
while still allowing the extra events to be recorded properly.
Change-Id: I66f850d21a2d0217f9049facffce074831b7e17d
Signed-off-by: Clarence Ip <cip@codeaurora.org>
Signed-off-by: Lakshmi Narayana Kalavala <lkalaval@codeaurora.org>
This change adds debugfs nodes for debugging underruns,
after this change following commands are supported:
1. To enable the underrun ftrace:
echo 1 > /d/tracing/events/sde/sde_encoder_underrun/enable
2. To enable feature that disables the ftraces once the
underrun happens:
echo 1 > /d/dri/0/debug/dbg_ctrl
3. To enable the panic in the device when underrun happens:
echo 2 > /d/dri/0/debug/dbg_ctrl
4. To enable both of the above options:
echo 3 > /d/dri/0/debug/dbg_ctrl
Change-Id: Id9f407edb0908a5f8454f08d63c356dc8f04d353
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
Signed-off-by: Jayant Shekhar <jshekhar@codeaurora.org>
Signed-off-by: Lakshmi Narayana Kalavala <lkalaval@codeaurora.org>
Enable qti can driver support in msm-auto_defconfg and
msm-auto-perf_defconfig.
Change-Id: I9a88bb345c9ebf3dac49cfef9e46ff7f736d979c
Signed-off-by: Balachandra C S <balacs@codeaurora.org>
mpc5746c CAN driver will be supported by the unified driver qti-can
also remove rh850 support from qti-can driver.
Change-Id: I6743604c1298b9705ac3550b96c9dae04d5137bd
Signed-off-by: Balachandra C S <balacs@codeaurora.org>
For MI2S shutdown, if clock disable fails,
do not increment clock reference. Otherwise,
next time when startup is called, clock enable will not
be called again, so use case will not work.
CRs-Fixed: 2200021
Change-Id: Ic1b6f238e55a58ca1993049468cf13f13d80b9f4
Signed-off-by: Soumya Managoli <smanag@codeaurora.org>
Add CAN device for MSM8996 auto variant using QTI CAN driver.
Change-Id: I76db18009bec22e2fa2216511b42dee99d1173ee
Signed-off-by: Balachandra C S <balacs@codeaurora.org>
Create a single CAN driver for all the supported CAN
controllers.
Change-Id: I3770aae1adf4ccafd5132f6b57ddc050a93c7c0f
Signed-off-by: Balachandra C S <balacs@codeaurora.org>