Bill Pemberton
cf530aa438
Staging: comedi: remove C99 comments in cb_pcidas.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:29 -07:00
Bill Pemberton
9ef4dea6eb
Staging: comedi: remove C99 comments in cb_pcidas64.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
6a438139a8
Staging: comedi: remove C99 comments in c6xdigio.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
d6d9bd32a0
Staging: comedi: remove C99 comments in adv_pci1723.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
0f04c35655
Staging: comedi: remove C99 comments in adl_pci9118.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
14458b19e5
Staging: comedi: remove C99 comments in adl_pci6208.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
1efd18f0cc
Staging: comedi: remove C99 comments in hwdrv_apci3120.c
...
This replaces C99 comments with traditional C comments. This
also removes 3 blocks of code that were already commented out.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
f147598bc1
Staging: comedi: remove C99 comments in hwdrv_apci3200.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
b58d9b17db
Staging: comedi: remove C99 comments in hwdrv_apci1564.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
0110c4432a
Staging: comedi: remove C99 comments in APCI1710_Pwm.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
c47375f3de
Staging: comedi: remove C99 comments in hwdrv_apci1500.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
0109253dee
Staging: comedi: remove C99 comments in pcl818.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
a351ecf308
Staging: comedi: remove C99 comments in das1800.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:28 -07:00
Bill Pemberton
cf0fd1086c
Staging: comedi: remove C99 comments in APCI1710_82x54.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
ed27614451
Staging: comedi: remove C99 comments in acl7225b.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
67d83b4fb9
Staging: comedi: remove C99 comments in 8253.h
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
6a037d5f65
Staging: comedi: Remove str_AnalogInputHeader typedef in addi-data/addi_eeprom.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
0a4eb4b6c7
Staging: comedi: Remove labpc_private typedef
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
9ad007403f
Staging: comedi: Remove labpc_board_struct typedef
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
70275063e4
Staging: comedi: Remove str_ADDIDATA_RTDStruct typedef in addi-data/hwdrv_apci3200
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
0a4de47be0
Staging: comedi: Remove str_BoardInfos typedef in addi-data/hwdrv_apci3200
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
ecab384b15
Staging: comedi: Remove str_Module typedef in addi-data/hwdrv_apci3200.h
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
0077f93c5a
Staging: comedi: Remove str_AnalogReadInformation typedef in addi-data/hwdrv_apci3120.h
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
73b0d70aeb
Staging: comedi: Remove str_TimerMainHeader typedef in addi-data/addi_eeprom.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
cc0ea813f2
Staging: comedi: Remove str_TimerDetails typedef in addi-data/addi_eeprom.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:27 -07:00
Bill Pemberton
d2e0cc9ae1
Staging: comedi: Remove str_DigitalOutputHeader typedef in addi-data/addi_eeprom.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
a28f34b7e9
Staging: comedi: Remove str_DigitalInputHeader typedef in addi-data/addi_eeprom.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
8881b568bf
Staging: comedi: Remove str_MainHeader typedef in addi-data/addi_eeprom.c
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
e320671e63
Staging: comedi: Remove addi_private typedef in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
b4ce4f165c
Staging: comedi: Remove str_ModuleInfo typedef in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
6a770eca8a
Staging: comedi: Remove boardtype typedef in addi-data
...
typedef for boardtype removed and struct renamed to
addi_board
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
1c09a82ced
Staging: comedi: Remove PCRANGE typedef in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
a3435c92d0
Staging: comedi: Remove ULONG_PTR typedef in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
756e9d7ca6
Staging: comedi: Remove DWORD and *PDWORD typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
82a6e2e7ab
Staging: comedi: Remove ULONG and *PULONG typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:26 -07:00
Bill Pemberton
2b6257c534
Staging: comedi: Remove LONG and *PLONG typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
117102b0f6
Staging: comedi: Remove UINT and *PUINT typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
74b894e56a
Staging: comedi: Remove INT and *PINT typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
babf0ede30
Staging: comedi: Remove WORD and *PWORD typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
a9fce7c9a3
Staging: comedi: Remove USHORT and *PUSHORT typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
66673a7c84
Staging: comedi: Remove SHORT and *PSHORT typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
1783fbfe02
Staging: comedi: Remove BYTE and *PBYTE typedefs in addi-data
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
2ec9f875f8
Staging: comedi: Remove local_info_t typedef in ni_daq_dio24
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
cf4c8d1b8f
Staging: comedi: Remove dio24_board_struct typedef
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
e3f9f2c8e6
Staging: comedi: Remove local_info_t typedef in ni_labpc_cs
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:25 -07:00
Bill Pemberton
3301cc7665
Staging: comedi: Remove ni_private typedef
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:24 -07:00
Bill Pemberton
8ab41df0d7
Staging: comedi: Remove ni_board typedef
...
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:24 -07:00
Greg Kroah-Hartman
1c6ccf6270
Staging: add mailing list address for staging tree
...
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19 11:00:24 -07:00
Eric Paris
528da3e9e2
inotify: inotify_destroy_mark_entry could get called twice
...
inotify_destroy_mark_entry could get called twice for the same mark since it
is called directly in inotify_rm_watch and when the mark is being destroyed for
another reason. As an example assume that the file being watched was just
deleted so inotify_destroy_mark_entry would get called from the path
fsnotify_inoderemove() -> fsnotify_destroy_marks_by_inode() ->
fsnotify_destroy_mark_entry() -> inotify_destroy_mark_entry(). If this
happened at the same time as userspace tried to remove a watch via
inotify_rm_watch we could attempt to remove the mark from the idr twice and
could thus double dec the ref cnt and potentially could be in a use after
free/double free situation. The fix is to have inotify_rm_watch use the
generic recursive safe fsnotify_destroy_mark_by_entry() so we are sure the
inotify_destroy_mark_entry() function can only be called one.
This patch also renames the function to inotify_ingored_remove_idr() so it is
clear what is actually going on in the function.
Hopefully this fixes:
[ 20.342058] idr_remove called for id=20 which is not allocated.
[ 20.348000] Pid: 1860, comm: udevd Not tainted 2.6.30-tip #1077
[ 20.353933] Call Trace:
[ 20.356410] [<ffffffff811a82b7>] idr_remove+0x115/0x18f
[ 20.361737] [<ffffffff8134259d>] ? _spin_lock+0x6d/0x75
[ 20.367061] [<ffffffff8111640a>] ? inotify_destroy_mark_entry+0xa3/0xcf
[ 20.373771] [<ffffffff8111641e>] inotify_destroy_mark_entry+0xb7/0xcf
[ 20.380306] [<ffffffff81115913>] inotify_freeing_mark+0xe/0x10
[ 20.386238] [<ffffffff8111410d>] fsnotify_destroy_mark_by_entry+0x143/0x170
[ 20.393293] [<ffffffff811163a3>] inotify_destroy_mark_entry+0x3c/0xcf
[ 20.399829] [<ffffffff811164d1>] sys_inotify_rm_watch+0x9b/0xc6
[ 20.405850] [<ffffffff8100bcdb>] system_call_fastpath+0x16/0x1b
Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Eric Paris <eparis@redhat.com>
Tested-by: Peter Ziljlstra <peterz@infradead.org>
2009-06-19 12:42:48 -04:00
Paul Mackerras
9cffa8d533
perf_counter tools: Define and use our own u64, s64 etc. definitions
...
On 64-bit powerpc, __u64 is defined to be unsigned long rather than
unsigned long long. This causes compiler warnings every time we
print a __u64 value with %Lx.
Rather than changing __u64, we define our own u64 to be unsigned long
long on all architectures, and similarly s64 as signed long long.
For consistency we also define u32, s32, u16, s16, u8 and s8. These
definitions are put in a new header, types.h, because these definitions
are needed in util/string.h and util/symbol.h.
The main change here is the mechanical change of __[us]{64,32,16,8}
to remove the "__". The other changes are:
* Create types.h
* Include types.h in perf.h, util/string.h and util/symbol.h
* Add types.h to the LIB_H definition in Makefile
* Added (u64) casts in process_overflow_event() and print_sym_table()
to kill two remaining warnings.
Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: benh@kernel.crashing.org
LKML-Reference: <19003.33494.495844.956580@cargo.ozlabs.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-06-19 18:25:47 +02:00