evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
android_kernel_oneplus_msm8998/drivers/infiniband/hw/qib
History
Exact
Mike Marciniszyn 586ff170c7 IB/qib: Fix DMA api warning with debug kernel 
commit 0252f73334f9ef68868e4684200bea3565a4fcee upstream.

The following error occurs in a debug build when running MPI PSM:

[  307.415911] WARNING: CPU: 4 PID: 23867 at lib/dma-debug.c:1158
check_unmap+0x4ee/0xa20
[  307.455661] ib_qib 0000:05:00.0: DMA-API: device driver failed to check map
error[device address=0x00000000df82b000] [size=4096 bytes] [mapped as page]
[  307.517494] Modules linked in:
[  307.531584]  ib_isert iscsi_target_mod ib_srpt target_core_mod rpcrdma
sunrpc ib_srp scsi_transport_srp scsi_tgt ib_iser libiscsi ib_ipoib
scsi_transport_iscsi rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm ib_cm iw_cm
ib_qib intel_powerclamp coretemp rdmavt intel_rapl iosf_mbi kvm_intel kvm
irqbypass crc32_pclmul ghash_clmulni_intel ipmi_ssif ib_core aesni_intel sg
ipmi_si lrw gf128mul dca glue_helper ipmi_devintf iTCO_wdt gpio_ich hpwdt
iTCO_vendor_support ablk_helper hpilo acpi_power_meter cryptd ipmi_msghandler
ie31200_edac shpchp pcc_cpufreq lpc_ich pcspkr ip_tables xfs libcrc32c sd_mod
crc_t10dif crct10dif_generic mgag200 i2c_algo_bit drm_kms_helper syscopyarea
sysfillrect sysimgblt fb_sys_fops ttm ahci crct10dif_pclmul crct10dif_common
drm crc32c_intel libahci tg3 libata serio_raw ptp i2c_core
[  307.846113]  pps_core dm_mirror dm_region_hash dm_log dm_mod
[  307.866505] CPU: 4 PID: 23867 Comm: mpitests-IMB-MP Kdump: loaded Not
tainted 3.10.0-862.el7.x86_64.debug #1
[  307.911178] Hardware name: HP ProLiant DL320e Gen8, BIOS J05 11/09/2013
[  307.944206] Call Trace:
[  307.956973]  [<ffffffffbd9e915b>] dump_stack+0x19/0x1b
[  307.982201]  [<ffffffffbd2a2f58>] __warn+0xd8/0x100
[  308.005999]  [<ffffffffbd2a2fdf>] warn_slowpath_fmt+0x5f/0x80
[  308.034260]  [<ffffffffbd5f667e>] check_unmap+0x4ee/0xa20
[  308.060801]  [<ffffffffbd41acaa>] ? page_add_file_rmap+0x2a/0x1d0
[  308.090689]  [<ffffffffbd5f6c4d>] debug_dma_unmap_page+0x9d/0xb0
[  308.120155]  [<ffffffffbd4082e0>] ? might_fault+0xa0/0xb0
[  308.146656]  [<ffffffffc07761a5>] qib_tid_free.isra.14+0x215/0x2a0 [ib_qib]
[  308.180739]  [<ffffffffc0776bf4>] qib_write+0x894/0x1280 [ib_qib]
[  308.210733]  [<ffffffffbd540b00>] ? __inode_security_revalidate+0x70/0x80
[  308.244837]  [<ffffffffbd53c2b7>] ? security_file_permission+0x27/0xb0
[  308.266025] qib_ib0.8006: multicast join failed for
ff12:401b:8006:0000:0000:0000:ffff:ffff, status -22
[  308.323421]  [<ffffffffbd46f5d3>] vfs_write+0xc3/0x1f0
[  308.347077]  [<ffffffffbd492a5c>] ? fget_light+0xfc/0x510
[  308.372533]  [<ffffffffbd47045a>] SyS_write+0x8a/0x100
[  308.396456]  [<ffffffffbd9ff355>] system_call_fastpath+0x1c/0x21

The code calls a qib_map_page() which has never correctly tested for a
mapping error.

Fix by testing for pci_dma_mapping_error() in all cases and properly
handling the failure in the caller.

Additionally, streamline qib_map_page() arguments to satisfy just
the single caller.

Cc: <stable@vger.kernel.org>
Reviewed-by: Alex Estrin <alex.estrin@intel.com>
Tested-by: Don Dutile <ddutile@redhat.com>
Reviewed-by: Don Dutile <ddutile@redhat.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-07-03 11:21:29 +02:00
..
Kconfig Remove GENERIC_HARDIRQ config option 2013-09-13 15:09:52 +02:00
Makefile IB/qib: Convert opcode counters to per-context 2013-06-21 17:19:50 -07:00
qib.h IB/qib: Fix DMA api warning with debug kernel 2018-07-03 11:21:29 +02:00
qib_6120_regs.h
qib_7220.h
qib_7220_regs.h
qib_7322_regs.h
qib_common.h IB/qib: Fix checkpatch warnings 2015-02-20 09:04:09 -08:00
qib_cq.c IB/core: Change provider's API of create_cq to be extendible 2015-06-12 14:49:10 -04:00
qib_debugfs.c IB/qib: Fix checkpatch warnings 2015-02-20 09:04:09 -08:00
qib_debugfs.h IB/qib: Convert opcode counters to per-context 2013-06-21 17:19:50 -07:00
qib_diag.c IB/qib: Add blank line after declaration 2015-02-20 09:04:12 -08:00
qib_dma.c IB/qib: Remove ib_sg_dma_address() and ib_sg_dma_len() overloads 2014-04-01 11:16:31 -07:00
qib_driver.c IB/qib: Add blank line after declaration 2015-02-20 09:04:12 -08:00
qib_eeprom.c IB/qib: Add blank line after declaration 2015-02-20 09:04:12 -08:00
qib_file_ops.c IB/qib: Fix DMA api warning with debug kernel 2018-07-03 11:21:29 +02:00
qib_fs.c make simple_positive() public 2015-06-23 18:02:01 -04:00
qib_iba6120.c IB/qib: use arch_phys_wc_add() 2015-05-05 09:18:02 -04:00
qib_iba7220.c IB/qib: use arch_phys_wc_add() 2015-05-05 09:18:02 -04:00
qib_iba7322.c IB/qib: fix false-postive maybe-uninitialized warning 2017-10-08 10:14:20 +02:00
qib_init.c mm, page_alloc: rename __GFP_WAIT to __GFP_RECLAIM 2015-11-06 17:50:42 -08:00
qib_intr.c IB/qib: Fix checkpatch warnings 2015-02-20 09:04:09 -08:00
qib_keys.c IB/qib: Remove old FRWR API 2015-10-28 22:32:29 -04:00
qib_mad.c IB/mad: Remove improper use of BUG_ON 2015-07-14 13:20:08 -04:00
qib_mad.h IB/core: Add core header changes needed for OPA 2015-08-28 22:54:50 -04:00
qib_mmap.c mm: mark most vm_operations_struct const 2015-09-10 13:29:01 -07:00
qib_mr.c IB/qib: Remove old FRWR API 2015-10-28 22:32:29 -04:00
qib_pcie.c IB/qib: Add blank line after declaration 2015-02-20 09:04:12 -08:00
qib_pio_copy.c
qib_qp.c IB/qib: rename BITS_PER_PAGE to RVT_BITS_PER_PAGE 2017-05-08 07:46:02 +02:00
qib_qsfp.c IB/qib: Minor fixes to qib per SFF 8636 2015-12-07 16:36:00 -05:00
qib_qsfp.h
qib_rc.c RDMA/qib,hfi1: Fix MR reference count leak on write with immediate 2017-06-14 13:16:27 +02:00
qib_ruc.c IB: split struct ib_send_wr 2015-10-08 11:09:10 +01:00
qib_sd7220.c IB/qib: Add blank line after declaration 2015-02-20 09:04:12 -08:00
qib_sdma.c IB/qib: Improve SDMA performance 2013-08-13 11:14:34 -07:00
qib_srq.c
qib_sysfs.c IB/qib: Fix sizeof checkpatch warnings 2015-02-17 10:26:19 -08:00
qib_twsi.c IB/qib: Add blank line after declaration 2015-02-20 09:04:12 -08:00
qib_tx.c IB/qib: Add blank line after declaration 2015-02-20 09:04:12 -08:00
qib_uc.c IB: split struct ib_send_wr 2015-10-08 11:09:10 +01:00
qib_ud.c IB: split struct ib_send_wr 2015-10-08 11:09:10 +01:00
qib_user_pages.c IB/qib: Fix DMA api warning with debug kernel 2018-07-03 11:21:29 +02:00
qib_user_sdma.c IB/qib: Add blank line after declaration 2015-02-20 09:04:12 -08:00
qib_user_sdma.h
qib_verbs.c IB/qib: Remove old FRWR API 2015-10-28 22:32:29 -04:00
qib_verbs.h IB/qib: Fix qib_mr structure 2015-12-07 16:22:14 -05:00
qib_verbs_mcast.c IB/qib: fix mcast detach when qp not attached 2016-03-03 15:07:25 -08:00
qib_wc_ppc64.c
qib_wc_x86_64.c IB/qib: fix test of unsigned variable 2015-05-12 13:55:41 -04:00