evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
android_kernel_oneplus_msm8998/fs/kernfs
History
Exact
Ivan Vecera f1db1b8055 kernfs: fix regression in kernfs_fop_write caused by wrong type 
commit ba87977a49913129962af8ac35b0e13e0fa4382d upstream.

Commit b7ce40cff0 ("kernfs: cache atomic_write_len in
kernfs_open_file") changes type of local variable 'len' from ssize_t
to size_t. This change caused that the *ppos value is updated also
when the previous write callback failed.

Mentioned snippet:
...
len = ops->write(...); <- return value can be negative
...
if (len > 0)           <- true here in this case
        *ppos += len;
...

Fixes: b7ce40cff0 ("kernfs: cache atomic_write_len in kernfs_open_file")
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-02-16 20:09:42 +01:00
..
dir.c kernfs: implement kernfs_path_len() 2015-08-18 15:49:15 -07:00
file.c kernfs: fix regression in kernfs_fop_write caused by wrong type 2018-02-16 20:09:42 +01:00
inode.c kernfs: Add support for always empty directories. 2015-07-01 10:36:43 -05:00
Kconfig kernfs: add CONFIG_KERNFS 2014-02-07 16:08:57 -08:00
kernfs-internal.h kernfs: make kernfs_get_inode() public 2015-06-18 16:54:28 -04:00
Makefile sysfs, kernfs: add skeletons for kernfs 2013-11-27 13:28:24 -08:00
mount.c fs: deduplicate noop_backing_dev_info 2015-01-20 14:02:54 -07:00
symlink.c new helper: free_page_put_link() 2015-05-11 08:13:13 -04:00