be90a09bd9
commit 79a628d14ec7ee9adfdc3ce04343d5ff7ec20c18 upstream. reiserfs_xattr_[sg]et() will fail with -EOPNOTSUPP for V1 inodes anyway, and all reiserfs instances of ->[sg]et() call it and so does ->set_acl(). Checks for name length in the instances had been bogus; they should've been "bugger off if it's _exactly_ the prefix" (as generic would do on its own) and not "bugger off if it's shorter than the prefix" - that can't happen. xattr_full_name() is needed to adjust for the fact that generic instances will skip the prefix in the name passed to ->[gs]et(); reiserfs homegrown analogues didn't. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> [jeffm: Backported to v4.4: adjust context] Signed-off-by: Jeff Mahoney <jeffm@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
51 lines
1.3 KiB
C
51 lines
1.3 KiB
C
#include "reiserfs.h"
|
|
#include <linux/errno.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/pagemap.h>
|
|
#include <linux/xattr.h>
|
|
#include "xattr.h"
|
|
#include <linux/uaccess.h>
|
|
|
|
static int
|
|
user_get(const struct xattr_handler *handler, struct dentry *dentry,
|
|
const char *name, void *buffer, size_t size)
|
|
{
|
|
if (!reiserfs_xattrs_user(dentry->d_sb))
|
|
return -EOPNOTSUPP;
|
|
return reiserfs_xattr_get(d_inode(dentry),
|
|
xattr_full_name(handler, name),
|
|
buffer, size);
|
|
}
|
|
|
|
static int
|
|
user_set(const struct xattr_handler *handler, struct dentry *dentry,
|
|
const char *name, const void *buffer, size_t size, int flags)
|
|
{
|
|
if (!reiserfs_xattrs_user(dentry->d_sb))
|
|
return -EOPNOTSUPP;
|
|
return reiserfs_xattr_set(d_inode(dentry),
|
|
xattr_full_name(handler, name),
|
|
buffer, size, flags);
|
|
}
|
|
|
|
static size_t user_list(const struct xattr_handler *handler,
|
|
struct dentry *dentry, char *list, size_t list_size,
|
|
const char *name, size_t name_len)
|
|
{
|
|
const size_t len = name_len + 1;
|
|
|
|
if (!reiserfs_xattrs_user(dentry->d_sb))
|
|
return 0;
|
|
if (list && len <= list_size) {
|
|
memcpy(list, name, name_len);
|
|
list[name_len] = '\0';
|
|
}
|
|
return len;
|
|
}
|
|
|
|
const struct xattr_handler reiserfs_xattr_user_handler = {
|
|
.prefix = XATTR_USER_PREFIX,
|
|
.get = user_get,
|
|
.set = user_set,
|
|
.list = user_list,
|
|
};
|