Jesper Dangaard Brouer 19952cc4f8 net: frag queue per hash bucket locking ... This patch implements per hash bucket locking for the frag queue hash. This removes two write locks, and the only remaining write lock is for protecting hash rebuild. This essentially reduce the readers-writer lock to a rebuild lock. This patch is part of "net: frag performance followup" http://thread.gmane.org/gmane.linux.network/263644 of which two patches have already been accepted: Same test setup as previous: (http://thread.gmane.org/gmane.linux.network/257155) Two 10G interfaces, on seperate NUMA nodes, are under-test, and uses Ethernet flow-control. A third interface is used for generating the DoS attack (with trafgen). Notice, I have changed the frag DoS generator script to be more efficient/deadly. Before it would only hit one RX queue, now its sending packets causing multi-queue RX, due to "better" RX hashing. Test types summary (netperf UDP_STREAM): Test-20G64K == 2x10G with 65K fragments Test-20G3F == 2x10G with 3x fragments (3*1472 bytes) Test-20G64K+DoS == Same as 20G64K with frag DoS Test-20G3F+DoS == Same as 20G3F with frag DoS Test-20G64K+MQ == Same as 20G64K with Multi-Queue frag DoS Test-20G3F+MQ == Same as 20G3F with Multi-Queue frag DoS When I rebased this-patch(03) (on top of net-next commit a210576c) and removed the _bh spinlock, I saw a performance regression. BUT this was caused by some unrelated change in-between. See tests below. Test (A) is what I reported before for patch-02, accepted in commit 1b5ab0de. Test (B) verifying-retest of commit 1b5ab0de corrospond to patch-02. Test (C) is what I reported before for this-patch Test (D) is net-next master HEAD (commit a210576c), which reveals some (unknown) performance regression (compared against test (B)). Test (D) function as a new base-test. Performance table summary (in Mbit/s): (#) Test-type: 20G64K 20G3F 20G64K+DoS 20G3F+DoS 20G64K+MQ 20G3F+MQ ---------- ------- ------- ---------- --------- -------- ------- (A) Patch-02 : 18848.7 13230.1 4103.04 5310.36 130.0 440.2 (B) 1b5ab0de : 18841.5 13156.8 4101.08 5314.57 129.0 424.2 (C) Patch-03v1: 18838.0 13490.5 4405.11 6814.72 196.6 461.6 (D) a210576c : 18321.5 11250.4 3635.34 5160.13 119.1 405.2 (E) with _bh : 17247.3 11492.6 3994.74 6405.29 166.7 413.6 (F) without bh: 17471.3 11298.7 3818.05 6102.11 165.7 406.3 Test (E) and (F) is this-patch(03), with(V1) and without(V2) the _bh spinlocks. I cannot explain the slow down for 20G64K (but its an artificial "lab-test" so I'm not worried). But the other results does show improvements. And test (E) "with _bh" version is slightly better. Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Acked-by: Eric Dumazet <edumazet@google.com> ---- V2: - By analysis from Hannes Frederic Sowa and Eric Dumazet, we don't need the spinlock _bh versions, as Netfilter currently does a local_bh_disable() before entering inet_fragment. - Fold-in desc from cover-mail V3: - Drop the chain_len counter per hash bucket. Signed-off-by: David S. Miller <davem@davemloft.net>		2013-04-04 17:37:05 -04:00
..
acpi	Fixes:	2013-03-12 20:25:53 -07:00
asm-generic	asm-generic: move cmpxchg*_local defs to cmpxchg.h	2013-03-13 06:11:05 +01:00
clocksource	ImgTec Meta architecture changes for v3.9-rc1	2013-03-03 12:06:09 -08:00
crypto
drm	drm/radeon: add Richland pci ids	2013-03-15 18:47:19 -04:00
keys
linux	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-04-03 01:31:54 -04:00
math-emu
media
memory
misc
net	net: frag queue per hash bucket locking	2013-04-04 17:37:05 -04:00
pcmcia
ras
rdma
rxrpc
scsi	libfc, fcoe, bnx2fc: Split fc_disc_init into fc_disc_{init, config}	2013-03-25 16:03:03 -07:00
sound	arm-soc: late OMAP changes	2013-02-28 20:00:40 -08:00
target	target: Rename spc_get_write_same_sectors -> sbc_get_write_same_sectors	2013-02-23 12:46:14 -08:00
trace	Various bug fixes for ext4. The most important is a fix for the new	2013-03-02 19:33:21 -08:00
uapi	net: add option to enable error queue packets waking select	2013-03-31 19:44:20 -04:00
video	ARM: at91: fix LCD-wiring mode	2013-03-13 11:05:04 +01:00
xen	for-linus-20130331	2013-03-31 11:38:59 -07:00
Kbuild