Sultan Alsawaf 1b37d68f4c ANDROID: Fix massive cpufreq_times memory leaks ... Every time _cpu_up() is called for a CPU, idle_thread_get() is called which then re-initializes a CPU's idle thread that was already previously created and cached in a global variable in smpboot.c. idle_thread_get() calls init_idle() which then calls __sched_fork(). __sched_fork() is where cpufreq_task_times_init() is, and cpufreq_task_times_init() allocates memory for the task struct's time_in_state array. Since idle_thread_get() reuses a task struct instance that was already previously created, this means that every time it calls init_idle(), cpufreq_task_times_init() allocates this array again and overwrites the existing allocation that the idle thread already had. This causes memory to be leaked every time a CPU is onlined. In order to fix this, move allocation of time_in_state into _do_fork to avoid allocating it at all for idle threads. The cpufreq times interface is intended to be used for tracking userspace tasks, so we can safely remove it from the kernel's idle threads without killing any functionality. But that's not all! Task structs can be freed outside of release_task(), which creates another memory leak because a task struct can be freed without having its cpufreq times allocation freed. To fix this, free the cpufreq times allocation at the same time that task struct allocations are freed, in free_task(). Since free_task() can also be called in error paths of copy_process() after dup_task_struct(), set time_in_state to NULL immediately after calling dup_task_struct() to avoid possible double free. Bug description and fix adapted from patch submitted by Sultan Alsawaf <sultanxda@gmail.com> at https://android-review.googlesource.com/c/kernel/msm/+/700134 Bug: 110044919 Test: Hikey960 builds, boots & reports /proc/<pid>/time_in_state correctly Change-Id: I12fe7611fc88eb7f6c39f8f7629ad27b6ec4722c Signed-off-by: Connor O'Brien <connoro@google.com>		2018-07-18 13:21:38 +00:00
..
bpf	bpf: map_get_next_key to return first key on NULL	2018-05-16 10:06:46 +02:00
configs	UPSTREAM: config: android-base: disable CONFIG_NFSD and CONFIG_NFS_FS	2018-02-05 08:58:36 -08:00
debug	This is the 4.4.134 stable release	2018-05-30 13:25:24 +02:00
events	This is the 4.4.134 stable release	2018-05-30 13:25:24 +02:00
gcov	gcov: disable for COMPILE_TEST	2018-01-23 19:50:10 +01:00
irq	genirq: Use cpumask_available() for check of cpumask variable	2018-04-08 11:51:57 +02:00
livepatch	livepatch: x86: fix relocation computation with kASLR	2015-11-11 17:36:04 +01:00
locking	This is the 4.4.134 stable release	2018-05-30 13:25:24 +02:00
power	This is the 4.4.141 stable release	2018-07-17 12:15:52 +02:00
printk	This is the 4.4.123 stable release	2018-03-22 09:57:28 +01:00
rcu	BACKPORT: kernel: add kcov code coverage	2017-12-18 09:41:57 -08:00
sched	ANDROID: Fix massive cpufreq_times memory leaks	2018-07-18 13:21:38 +00:00
time	This is the 4.4.139 stable release	2018-07-03 18:23:34 +02:00
trace	This is the 4.4.140 stable release	2018-07-11 16:24:21 +02:00
.gitignore	certs: add .gitignore to stop git nagging about x509_certificate_list	2015-10-21 15:18:35 +01:00
acct.c	kernel/acct.c: fix the acct->needcheck check in check_free_space()	2018-01-10 09:27:08 +01:00
async.c	kernel/async.c: revert "async: simplify lowest_in_progress()"	2018-02-16 20:09:45 +01:00
audit.c	This is the 4.4.134 stable release	2018-05-30 13:25:24 +02:00
audit.h	audit: audit_tree_match can be boolean	2015-11-04 08:23:51 -05:00
audit_fsnotify.c
audit_tree.c	audit: audit_tree_match can be boolean	2015-11-04 08:23:51 -05:00
audit_watch.c	audit: Fix use after free in audit_remove_watch_rule()	2017-08-24 17:02:35 -07:00
auditfilter.c	audit: fix comment block whitespace	2015-11-04 08:23:51 -05:00
auditsc.c	This is the 4.4.133 stable release	2018-05-26 10:12:26 +02:00
backtracetest.c
bounds.c
capability.c	exec: Ensure mm->user_ns contains the execed files	2017-01-06 11:16:14 +01:00
cgroup.c	cgroup: Disable IRQs while holding css_set_lock	2018-05-24 13:58:01 -07:00
cgroup_freezer.c	cgroup: fix handling of multi-destination migration from subtree_control enabling	2015-12-03 10:18:21 -05:00
cgroup_pids.c	cgroup_pids: don't account for the root cgroup	2015-12-03 10:18:21 -05:00
compat.c
configs.c
context_tracking.c	context_tracking: avoid irq_save/irq_restore on guest entry and exit	2015-11-10 12:06:23 +01:00
cpu.c	This is the 4.4.43 stable release	2017-01-17 12:44:14 -08:00
cpu_pm.c	kernel/cpu_pm: fix cpu_cluster_pm_exit comment	2015-09-03 02:42:20 +02:00
cpuset.c	This is the 4.4.92 stable release	2017-10-12 12:05:45 +02:00
crash_dump.c
cred.c	cred: Reject inodes with invalid ids in set_create_file_as()	2016-09-15 08:27:49 +02:00
delayacct.c
dma.c
elfcore.c
exec_domain.c
exit.c	ANDROID: Fix massive cpufreq_times memory leaks	2018-07-18 13:21:38 +00:00
extable.c	kernel/extable.c: mark core_kernel_text notrace	2017-07-21 07:44:56 +02:00
fork.c	ANDROID: Fix massive cpufreq_times memory leaks	2018-07-18 13:21:38 +00:00
freezer.c
futex.c	futex: futex_wake_op, fix sign_extend32 sign bits	2018-05-26 08:48:51 +02:00
futex_compat.c	BACKPORT: ptrace: use fsuid, fsgid, effective creds for fs access checks	2016-07-07 16:30:43 -07:00
groups.c	kernel: make groups_sort calling a responsibility group_info allocators	2018-01-10 09:27:10 +01:00
hung_task.c
irq_work.c	treewide: Remove old email address	2015-11-23 09:44:58 +01:00
jump_label.c	jump_label: Invoke jump_label_test() via early_initcall()	2017-12-16 10:33:55 +01:00
kallsyms.c
kcmp.c	BACKPORT: ptrace: use fsuid, fsgid, effective creds for fs access checks	2016-07-07 16:30:43 -07:00
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c	UPSTREAM: kcov: fix comparison callback signature	2017-12-18 09:41:57 -08:00
kexec.c	kexec: use file name as the output message prefix	2015-11-06 17:50:42 -08:00
kexec_core.c	kexec: use file name as the output message prefix	2015-11-06 17:50:42 -08:00
kexec_file.c	kexec: fix double-free when failing to relocate the purgatory	2016-09-24 10:07:36 +02:00
kexec_internal.h	kexec: split kexec_file syscall code to kexec_file.c	2015-09-10 13:29:01 -07:00
kmod.c	kmod: don't run async usermode helper as a child of kworker thread	2015-10-23 17:55:10 +09:00
kprobes.c	kprobes/x86: Fix to set RWX bits correctly before releasing trampoline	2018-04-08 11:51:56 +02:00
ksysfs.c	kexec: split kexec_load syscall from kexec core code	2015-09-10 13:29:01 -07:00
kthread.c	UPSTREAM: kthread: Pin the stack via try_get_task_stack()/put_task_stack() in to_live_kthread() function	2017-08-09 15:23:22 +01:00
latencytop.c
Makefile	BACKPORT: kernel: add kcov code coverage	2017-12-18 09:41:57 -08:00
membarrier.c	Fix: Disable sys_membarrier when nohz_full is enabled	2017-03-12 06:37:26 +01:00
memremap.c	mm: fix devm_memremap_pages crash, use mem_hotplug_{begin, done}	2017-01-19 20:17:18 +01:00
module-internal.h
module.c	module/retpoline: Warn about missing retpoline in module	2018-02-25 11:03:52 +01:00
module_signing.c	KEYS: Merge the type-specific data with the payload data	2015-10-21 15:18:36 +01:00
notifier.c
nsproxy.c
padata.c	padata: free correct variable	2017-05-20 14:27:02 +02:00
panic.c	kernel/panic.c: add missing \n	2017-07-05 14:37:19 +02:00
params.c	Nothing exciting, minor tweaks and cleanups.	2015-11-09 15:53:39 -08:00
pid.c	pidns: disable pid allocation if pid_ns_prepare_proc() is failed in alloc_pid()	2018-04-13 19:50:03 +02:00
pid_namespace.c	pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes	2017-05-25 14:30:11 +02:00
profile.c	profile: hide unused functions when !CONFIG_PROC_FS	2018-02-25 11:03:44 +01:00
ptrace.c	ptrace: Properly initialize ptracer_cred on fork	2017-06-14 13:16:20 +02:00
range.c
reboot.c	kexec: split kexec_load syscall from kexec core code	2015-09-10 13:29:01 -07:00
relay.c	kernel/relay.c: limit kmalloc size to KMALLOC_MAX_SIZE	2018-05-30 07:49:00 +02:00
resource.c	resource: fix integer overflow at reallocation	2018-04-24 09:32:05 +02:00
seccomp.c	seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter()	2017-10-05 09:41:46 +02:00
signal.c	kernel/signal.c: avoid undefined behaviour in kill_something_info	2018-05-30 07:48:52 +02:00
smp.c	mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd	2015-11-06 17:50:42 -08:00
smpboot.c	stop_machine: Kill smp_hotplug_thread->pre_unpark, introduce stop_machine_unpark()	2015-10-20 10:23:55 +02:00
smpboot.h
softirq.c	UPSTREAM: arch, ftrace: for KASAN put hard/soft IRQ entries into separate sections	2017-12-14 08:26:37 -08:00
stacktrace.c
stop_machine.c	kernel: remove stop_machine() Kconfig dependency	2015-12-12 10:15:34 -08:00
sys.c	This is the 4.4.134 stable release	2018-05-30 13:25:24 +02:00
sys_ni.c	mm: mlock: add new mlock system call	2015-11-05 19:34:48 -08:00
sysctl.c	cpufreq: Drop schedfreq governor	2017-11-07 23:57:47 +00:00
sysctl_binary.c	fs/coredump: prevent fsuid=0 dumps into user-controlled directories	2016-04-12 09:08:58 -07:00
task_work.c	task_work: remove fifo ordering guarantee	2015-09-05 13:46:58 -07:00
taskstats.c
test_kprobes.c
torture.c	torture: Consolidate cond_resched_rcu_qs() into stutter_wait()	2015-10-06 11:25:01 -07:00
tracepoint.c	tracepoint: Do not warn on ENOMEM	2018-05-16 10:06:47 +02:00
tsacct.c
uid16.c	kernel: make groups_sort calling a responsibility group_info allocators	2018-01-10 09:27:10 +01:00
up.c
user-return-notifier.c
user.c	ANDROID: proc: Add /proc/uid directory	2018-03-06 20:39:55 +00:00
user_namespace.c	capabilities: ambient capabilities	2015-09-04 16:54:41 -07:00
utsname.c
utsname_sysctl.c
watchdog.c	This is the 4.4.40 stable release	2017-01-09 10:12:25 -08:00
workqueue.c	workqueue: use put_device() instead of kfree()	2018-05-30 07:49:04 +02:00
workqueue_internal.h	workqueue: Fix NULL pointer dereference	2017-11-15 17:13:11 +01:00