c269f0b61c
[ Upstream commit ee9d21b3b3583712029a0db65a4b7c081d08d3b3 ] When building with clang crt0's _zimage_start is not marked weak, which breaks the build when linking the kernel image: $ objdump -t arch/powerpc/boot/crt0.o |grep _zimage_start$ 0000000000000058 g .text 0000000000000000 _zimage_start ld: arch/powerpc/boot/wrapper.a(crt0.o): in function '_zimage_start': (.text+0x58): multiple definition of '_zimage_start'; arch/powerpc/boot/pseries-head.o:(.text+0x0): first defined here Clang requires the .weak directive to appear after the symbol is declared. The binutils manual says: This directive sets the weak attribute on the comma separated list of symbol names. If the symbols do not already exist, they will be created. So it appears this is different with clang. The only reference I could see for this was an OpenBSD mailing list post[1]. Changing it to be after the declaration fixes building with Clang, and still works with GCC. $ objdump -t arch/powerpc/boot/crt0.o |grep _zimage_start$ 0000000000000058 w .text 0000000000000000 _zimage_start Reported to clang as https://bugs.llvm.org/show_bug.cgi?id=38921 [1] https://groups.google.com/forum/#!topic/fa.openbsd.tech/PAgKKen2YCY Signed-off-by: Joel Stanley <joel@jms.id.au> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
|---|---|---|
| .. | ||
| dts | ||
| .gitignore | ||
| 4xx.c | ||
| 4xx.h | ||
| 44x.h | ||
| addnote.c | ||
| bamboo.c | ||
| cpm-serial.c | ||
| crt0.S | ||
| crtsavres.S | ||
| cuboot-8xx.c | ||
| cuboot-52xx.c | ||
| cuboot-83xx.c | ||
| cuboot-85xx-cpm2.c | ||
| cuboot-85xx.c | ||
| cuboot-824x.c | ||
| cuboot-acadia.c | ||
| cuboot-amigaone.c | ||
| cuboot-bamboo.c | ||
| cuboot-c2k.c | ||
| cuboot-ebony.c | ||
| cuboot-hotfoot.c | ||
| cuboot-katmai.c | ||
| cuboot-kilauea.c | ||
| cuboot-mpc7448hpc2.c | ||
| cuboot-pq2.c | ||
| cuboot-rainier.c | ||
| cuboot-sam440ep.c | ||
| cuboot-sequoia.c | ||
| cuboot-taishan.c | ||
| cuboot-warp.c | ||
| cuboot-yosemite.c | ||
| cuboot.c | ||
| cuboot.h | ||
| dcr.h | ||
| devtree.c | ||
| div64.S | ||
| dummy.c | ||
| ebony.c | ||
| elf.h | ||
| elf_util.c | ||
| ep88xc.c | ||
| ep405.c | ||
| ep8248e.c | ||
| epapr-wrapper.c | ||
| epapr.c | ||
| fixed-head.S | ||
| fsl-soc.c | ||
| fsl-soc.h | ||
| gamecube-head.S | ||
| gamecube.c | ||
| gunzip_util.c | ||
| gunzip_util.h | ||
| hack-coff.c | ||
| holly.c | ||
| install.sh | ||
| io.h | ||
| libfdt-wrapper.c | ||
| libfdt_env.h | ||
| main.c | ||
| Makefile | ||
| mktree.c | ||
| mpc8xx.c | ||
| mpc8xx.h | ||
| mpc52xx-psc.c | ||
| mpsc.c | ||
| mv64x60.c | ||
| mv64x60.h | ||
| mv64x60_i2c.c | ||
| mvme5100.c | ||
| ns16550.c | ||
| of.c | ||
| of.h | ||
| ofconsole.c | ||
| oflib.c | ||
| ops.h | ||
| page.h | ||
| planetcore.c | ||
| planetcore.h | ||
| ppc_asm.h | ||
| ppcboot-hotfoot.h | ||
| ppcboot.h | ||
| pq2.c | ||
| pq2.h | ||
| ps3-head.S | ||
| ps3-hvcall.S | ||
| ps3.c | ||
| pseries-head.S | ||
| README | ||
| redboot-8xx.c | ||
| redboot-83xx.c | ||
| redboot.h | ||
| reg.h | ||
| rs6000.h | ||
| serial.c | ||
| simple_alloc.c | ||
| simpleboot.c | ||
| stdio.c | ||
| stdio.h | ||
| stdlib.c | ||
| stdlib.h | ||
| string.h | ||
| string.S | ||
| swab.h | ||
| treeboot-akebono.c | ||
| treeboot-bamboo.c | ||
| treeboot-currituck.c | ||
| treeboot-ebony.c | ||
| treeboot-iss4xx.c | ||
| treeboot-walnut.c | ||
| types.h | ||
| uartlite.c | ||
| ugecon.c | ||
| ugecon.h | ||
| util.S | ||
| virtex.c | ||
| virtex405-head.S | ||
| wii-head.S | ||
| wii.c | ||
| wrapper | ||
| zImage.coff.lds.S | ||
| zImage.lds.S | ||
| zImage.ps3.lds.S | ||
To extract the kernel vmlinux, System.map, .config or initrd from the zImage binary: objcopy -j .kernel:vmlinux -O binary zImage vmlinux.gz objcopy -j .kernel:System.map -O binary zImage System.map.gz objcopy -j .kernel:.config -O binary zImage config.gz objcopy -j .kernel:initrd -O binary zImage.initrd initrd.gz Peter