android_kernel_oneplus_msm8998/drivers/usb/wusbcore
Julia Lawall ef9211bb9a usb: wusbcore: security: cast sizeof to int for comparison
[ Upstream commit d3ac5598c5010a8999978ebbcca3b1c6188ca36b ]

Comparing an int to a size, which is unsigned, causes the int to become
unsigned, giving the wrong result.  usb_get_descriptor can return a
negative error code.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
int x;
expression e,e1;
identifier f;
@@

*x = f(...);
... when != x = e1
    when != if (x < 0 || ...) { ... return ...; }
*x < sizeof(e)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-10-10 08:52:05 +02:00
..
cbaf.c
crypto.c
dev-sysfs.c
devconnect.c
Kconfig
Makefile
mmc.c
pal.c
reservation.c
rh.c
security.c usb: wusbcore: security: cast sizeof to int for comparison 2018-10-10 08:52:05 +02:00
wa-hc.c
wa-hc.h
wa-nep.c
wa-rpipe.c
wa-xfer.c
wusbhc.c
wusbhc.h