Ming Lei 84f34c638d blk-mq: fix kernel oops in blk_mq_tag_idle() ... [ Upstream commit 8ab0b7dc73e1b3e2987d42554b2bff503f692772 ] HW queues may be unmapped in some cases, such as blk_mq_update_nr_hw_queues(), then we need to check it before calling blk_mq_tag_idle(), otherwise the following kernel oops can be triggered, so fix it by checking if the hw queue is unmapped since it doesn't make sense to idle the tags any more after hw queues are unmapped. [ 440.771298] Workqueue: nvme-wq nvme_rdma_del_ctrl_work [nvme_rdma] [ 440.779104] task: ffff894bae755ee0 ti: ffff893bf9bc8000 task.ti: ffff893bf9bc8000 [ 440.788359] RIP: 0010:[<ffffffffb730e2b4>] [<ffffffffb730e2b4>] __blk_mq_tag_idle+0x24/0x40 [ 440.798697] RSP: 0018:ffff893bf9bcbd10 EFLAGS: 00010286 [ 440.805538] RAX: 0000000000000000 RBX: ffff895bb131dc00 RCX: 000000000000011f [ 440.814426] RDX: 00000000ffffffff RSI: 0000000000000120 RDI: ffff895bb131dc00 [ 440.823301] RBP: ffff893bf9bcbd10 R08: 000000000001b860 R09: 4a51d361c00c0000 [ 440.832193] R10: b5907f32b4cc7003 R11: ffffd6cabfb57000 R12: ffff894bafd1e008 [ 440.841091] R13: 0000000000000001 R14: ffff895baf770000 R15: 0000000000000080 [ 440.849988] FS: 0000000000000000(0000) GS:ffff894bbdcc0000(0000) knlGS:0000000000000000 [ 440.859955] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 440.867274] CR2: 0000000000000008 CR3: 000000103d098000 CR4: 00000000001407e0 [ 440.876169] Call Trace: [ 440.879818] [<ffffffffb7309d68>] blk_mq_exit_hctx+0xd8/0xe0 [ 440.887051] [<ffffffffb730dc40>] blk_mq_free_queue+0xf0/0x160 [ 440.894465] [<ffffffffb72ff679>] blk_cleanup_queue+0xd9/0x150 [ 440.901881] [<ffffffffc08a802b>] nvme_ns_remove+0x5b/0xb0 [nvme_core] [ 440.910068] [<ffffffffc08a811b>] nvme_remove_namespaces+0x3b/0x60 [nvme_core] [ 440.919026] [<ffffffffc08b817b>] __nvme_rdma_remove_ctrl+0x2b/0xb0 [nvme_rdma] [ 440.928079] [<ffffffffc08b8237>] nvme_rdma_del_ctrl_work+0x17/0x20 [nvme_rdma] [ 440.937126] [<ffffffffb70ab58a>] process_one_work+0x17a/0x440 [ 440.944517] [<ffffffffb70ac3a8>] worker_thread+0x278/0x3c0 [ 440.951607] [<ffffffffb70ac130>] ? manage_workers.isra.24+0x2a0/0x2a0 [ 440.959760] [<ffffffffb70b352f>] kthread+0xcf/0xe0 [ 440.966055] [<ffffffffb70b3460>] ? insert_kthread_work+0x40/0x40 [ 440.973715] [<ffffffffb76d8658>] ret_from_fork+0x58/0x90 [ 440.980586] [<ffffffffb70b3460>] ? insert_kthread_work+0x40/0x40 [ 440.988229] Code: 5b 41 5c 5d c3 66 90 0f 1f 44 00 00 48 8b 87 20 01 00 00 f0 0f ba 77 40 01 19 d2 85 d2 75 08 c3 0f 1f 80 00 00 00 00 55 48 89 e5 <f0> ff 48 08 48 8d 78 10 e8 7f 0f 05 00 5d c3 0f 1f 00 66 2e 0f [ 441.011620] RIP [<ffffffffb730e2b4>] __blk_mq_tag_idle+0x24/0x40 [ 441.019301] RSP <ffff893bf9bcbd10> [ 441.024052] CR2: 0000000000000008 Reported-by: Zhang Yi <yizhan@redhat.com> Tested-by: Zhang Yi <yizhan@redhat.com> Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-04-13 19:50:22 +02:00
..
partitions	partitions/msdos: Unable to mount UFS 44bsd partitions	2018-04-08 11:51:56 +02:00
bio-integrity.c	bio-integrity: Do not allocate integrity context for bio w/o data	2018-04-13 19:50:17 +02:00
bio.c	more bio_map_user_iov() leak fixes	2017-12-16 10:33:56 +01:00
blk-cgroup.c	blkcg: fix double free of new_blkg in blkcg_init_queue	2018-03-22 09:23:19 +01:00
blk-core.c	block: wake up all tasks blocked in get_request()	2017-12-16 10:33:55 +01:00
blk-exec.c	block: move PM request support to IDE	2015-05-05 13:40:42 -06:00
blk-flush.c	Revert "blk-flush: Queue through IO scheduler when flush not required"	2015-11-25 10:12:54 -07:00
blk-integrity.c	block: fix blk_integrity_register to use template's interval_exp if not 0	2017-05-20 14:27:00 +02:00
blk-ioc.c	mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd	2015-11-06 17:50:42 -08:00
blk-iopoll.c	Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into next	2014-06-03 12:57:53 -07:00
blk-lib.c	block: re-add discard_granularity and alignment checks	2015-10-28 09:12:58 +09:00
blk-map.c	Don't feed anything but regular iovec's to blk_rq_map_user_iov	2016-12-10 19:07:26 +01:00
blk-merge.c	block: make sure a big bio is split into at most 256 bvecs	2016-09-15 08:27:51 +02:00
blk-mq-cpu.c	blk-mq: add file comments and update copyright notices	2014-05-28 10:15:41 -06:00
blk-mq-cpumap.c	blk-mq: avoid inserting requests before establishing new mapping	2015-09-29 11:32:50 -06:00
blk-mq-sysfs.c	block: add block polling support	2015-11-07 10:40:47 -07:00
blk-mq-tag.c	mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd	2015-11-06 17:50:42 -08:00
blk-mq-tag.h	blk-mq: factor out a helper to iterate all tags for a request_queue	2015-10-01 10:10:57 +02:00
blk-mq.c	blk-mq: fix kernel oops in blk_mq_tag_idle()	2018-04-13 19:50:22 +02:00
blk-mq.h	blk-mq: mark __blk_mq_complete_request() static	2015-11-11 09:36:56 -07:00
blk-settings.c	block: Initialize max_dev_sectors to 0	2016-03-09 15:34:49 -08:00
blk-softirq.c	block: fix regression with block enabled tagging	2014-04-09 21:54:06 -06:00
blk-sysfs.c	Merge branch 'mkp-fixes' into fixes	2015-12-03 09:32:33 -08:00
blk-tag.c	block: support different tag allocation policy	2015-01-23 14:15:46 -07:00
blk-throttle.c	blk-throttle: make sure expire time isn't too big	2018-03-22 09:23:22 +01:00
blk-timeout.c	block: fix blk_abort_request for blk-mq drivers	2015-11-24 15:24:10 -07:00
blk.h	block: protect rw_page against device teardown	2015-11-19 13:47:10 -08:00
bounce.c	Merge branch 'for-linus' of git://git.kernel.dk/linux-block	2015-09-19 18:57:09 -07:00
bsg-lib.c	Revert "bsg-lib: don't free job in bsg_prepare_job"	2017-10-21 17:09:03 +02:00
bsg.c	sg_write()/bsg_write() is not fit to be called under KERNEL_DS	2017-01-09 08:07:53 +01:00
cfq-iosched.c	block: cfq_cpd_alloc() should use @gfp	2017-01-19 20:17:22 +01:00
cmdline-parser.c	block: remove unrelated header files and export symbol	2014-01-21 20:18:26 -08:00
compat_ioctl.c	block, bdi: an active gendisk always has a request_queue associated with it	2014-09-08 10:00:35 -06:00
deadline-iosched.c	block: Stop abusing csd.list for fifo_time	2014-02-24 14:46:32 -08:00
elevator.c	block: check bio_mergeable() early before merging	2015-10-21 15:00:54 -06:00
genhd.c	block: fix del_gendisk() vs blkdev_ioctl crash	2017-04-27 09:09:34 +02:00
ioctl.c	block: add an API for Persistent Reservations	2015-10-21 14:46:56 -06:00
ioprio.c	block: fix use-after-free in sys_ioprio_get()	2016-08-10 11:49:28 +02:00
Kconfig	block: Add T10 Protection Information functions	2014-09-27 09:14:59 -06:00
Kconfig.iosched	blkcg: make CONFIG_BLK_CGROUP bool	2012-03-06 21:27:21 +01:00
Makefile	block: Add T10 Protection Information functions	2014-09-27 09:14:59 -06:00
noop-iosched.c	elevator: use list_{first,prev,next}_entry	2015-11-16 15:21:48 -07:00
partition-generic.c	block: fix an error code in add_partition()	2018-04-13 19:50:10 +02:00
scsi_ioctl.c	block: allow WRITE_SAME commands with the SG_IO ioctl	2017-03-30 09:35:20 +02:00
t10-pi.c	block: Consolidate static integrity profile properties	2015-10-21 14:42:38 -06:00