android_kernel_oneplus_msm8998/fs/pstore
Joel Fernandes (Google) f250e4c562 pstore/ram: Do not treat empty buffers as valid
[ Upstream commit 30696378f68a9e3dad6bfe55938b112e72af00c2 ]

The ramoops backend currently calls persistent_ram_save_old() even
if a buffer is empty. While this appears to work, it is does not seem
like the right thing to do and could lead to future bugs so lets avoid
that. It also prevents misleading prints in the logs which claim the
buffer is valid.

I got something like:

	found existing buffer, size 0, start 0

When I was expecting:

	no valid data in buffer (sig = ...)

This bails out early (and reports with pr_debug()), since it's an
acceptable state.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Co-developed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-01-26 09:42:53 +01:00
..
ftrace.c pstore: add pstore unregister 2015-10-22 08:59:18 -07:00
inode.c pstore: drop file opened reference count 2016-10-07 15:23:44 +02:00
internal.h pstore: Fix return type of pstore_is_mounted() 2015-10-22 10:57:33 -07:00
Kconfig pstore: add pstore unregister 2015-10-22 08:59:18 -07:00
Makefile pstore: add pstore unregister 2015-10-22 08:59:18 -07:00
platform.c pstore: Convert console write to use ->write_buf 2018-12-17 21:55:12 +01:00
pmsg.c pstore: add pstore unregister 2015-10-22 08:59:18 -07:00
ram.c pstore: Allow prz to control need for locking 2017-08-06 19:19:43 -07:00
ram_core.c pstore/ram: Do not treat empty buffers as valid 2019-01-26 09:42:53 +01:00