android_kernel_oneplus_msm8998/drivers/gpu
Gustavo A. R. Silva 3f951709eb drm/bufs: Fix Spectre v1 vulnerability
[ Upstream commit a37805098900a6e73a55b3a43b7d3bcd987bb3f4 ]

idx can be indirectly controlled by user-space, hence leading to a
potential exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

drivers/gpu/drm/drm_bufs.c:1420 drm_legacy_freebufs() warn: potential
spectre issue 'dma->buflist' [r] (local cap)

Fix this by sanitizing idx before using it to index dma->buflist

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20181016095549.GA23586@embeddedor.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-02-20 10:13:03 +01:00
..
drm drm/bufs: Fix Spectre v1 vulnerability 2019-02-20 10:13:03 +01:00
host1x gpu: host1x: fix error return code in host1x_probe() 2018-11-10 07:41:39 -08:00
ipu-v3 drm/imx: Match imx-ipuv3-crtc components using device node in platform data 2016-06-07 18:14:37 -07:00
vga vgaarb: fix signal handling in vga_get() 2015-12-11 14:04:44 +10:00
Makefile