android_kernel_oneplus_msm8998/sound/firewire
Takashi Sakamoto e6c4138bc1 ALSA: fireworks: accessing to user space outside spinlock
commit 6b1ca4bcadf9ef077cc5f03c6822ba276ed14902 upstream.

In hwdep interface of fireworks driver, accessing to user space is in a
critical section with disabled local interrupt. Depending on architecture,
accessing to user space can cause page fault exception. Then local
processor stores machine status and handles the synchronous event. A
handler corresponding to the event can call task scheduler to wait for
preparing pages. In a case of usage of single core processor, the state to
disable local interrupt is worse because it don't handle usual interrupts
from hardware.

This commit fixes this bug, performing the accessing outside spinlock. This
commit also gives up counting the number of queued response messages to
simplify ring-buffer management.

Reported-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Fixes: 555e8a8f7f14('ALSA: fireworks: Add command/response functionality into hwdep interface')
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-09-15 08:27:53 +02:00
..
bebob ALSA: bebob: Use a signed return type for get_formation_index 2016-02-17 12:30:58 -08:00
dice ALSA: dice: fix detection of Loud devices 2015-11-14 17:50:57 +01:00
digi00x ALSA: firewire-digi00x: add another rawmidi character device for MIDI control ports 2015-10-30 19:34:44 +01:00
fireworks ALSA: fireworks: accessing to user space outside spinlock 2016-09-15 08:27:53 +02:00
oxfw ALSA: oxfw: add an entry for TASCAM FireOne 2015-10-19 12:01:22 +02:00
tascam ALSA: firewire-tascam: accessing to user space outside spinlock 2016-09-15 08:27:53 +02:00
amdtp-am824.c ALSA: firewire-lib: process_rx_data_blocks() can be static 2015-09-29 16:52:52 +02:00
amdtp-am824.h ALSA: firewire-lib: complete AM824 data block processing layer 2015-09-29 12:51:20 +02:00
amdtp-stream.c ALSA: firewire-lib: continue packet processing at detecting wrong CIP headers 2015-10-11 18:14:01 +02:00
amdtp-stream.h ALSA: firewire-lib: complete AM824 data block processing layer 2015-09-29 12:51:20 +02:00
cmp.c ALSA: firewire-lib: fix kerneldoc errors 2014-11-18 18:10:23 +01:00
cmp.h ALSA: firewire-lib: Add a new function to check others' connection 2014-05-26 14:22:46 +02:00
fcp.c ALSA: firewire-lib: rename 'amdtp' to 'amdtp-stream' to prepare for functional separation 2015-09-29 12:47:11 +02:00
fcp.h ALSA: firewire-lib: Add some AV/C general commands 2014-05-26 14:23:13 +02:00
isight.c ALSA: pcm: Add snd_pcm_stop_xrun() helper 2014-11-09 18:20:40 +01:00
iso-resources.c ALSA: firewire-lib: leave unit reference counting completely 2015-03-10 15:27:19 +01:00
iso-resources.h firewire: octlet AT payloads can be stack-allocated 2011-05-10 22:53:44 +02:00
Kconfig ALSA: oxfw: add an comment to Kconfig for TASCAM FireOne 2015-11-08 09:04:36 +01:00
lib.c ALSA: firewire-lib: avoid NULL pointer dereference after closing MIDI port 2015-10-19 11:58:21 +02:00
lib.h ALSA: firewire-lib: avoid endless loop to transfer MIDI messages at fatal error 2015-10-09 09:57:06 +02:00
Makefile ALSA: oxfw: remove a meaningless entry from firewire Makefile 2015-10-18 09:10:11 +02:00
packets-buffer.c sound: Add export.h for THIS_MODULE/EXPORT_SYMBOL where needed 2011-10-31 19:31:22 -04:00
packets-buffer.h
scs1x.c ALSA: firewire: Convert to snd_card_new() with a device pointer 2014-02-14 08:13:31 +01:00