Tobin C. Harding 5c9a20390c btrfs: sysfs: don't leak memory when failing add fsid ... commit e32773357d5cc271b1d23550b3ed026eb5c2a468 upstream. A failed call to kobject_init_and_add() must be followed by a call to kobject_put(). Currently in the error path when adding fs_devices we are missing this call. This could be fixed by calling btrfs_sysfs_remove_fsid() if btrfs_sysfs_add_fsid() returns an error or by adding a call to kobject_put() directly in btrfs_sysfs_add_fsid(). Here we choose the second option because it prevents the slightly unusual error path handling requirements of kobject from leaking out into btrfs functions. Add a call to kobject_put() in the error path of kobject_add_and_init(). This causes the release method to be called if kobject_init_and_add() fails. open_tree() is the function that calls btrfs_sysfs_add_fsid() and the error code in this function is already written with the assumption that the release method is called during the error path of open_tree() (as seen by the call to btrfs_sysfs_remove_fsid() under the fail_fsdev_sysfs label). Cc: stable@vger.kernel.org # v4.4+ Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Tobin C. Harding <tobin@kernel.org> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-06-11 12:23:52 +02:00
..
tests	btrfs: tests/qgroup: Fix wrong tree backref level	2018-05-30 07:49:09 +02:00
acl.c	btrfs: preserve i_mode if __btrfs_set_acl() fails	2018-03-11 16:19:47 +01:00
async-thread.c	btrfs: limit async_work allocation and worker func duration	2017-01-06 11:16:06 +01:00
async-thread.h	btrfs: limit async_work allocation and worker func duration	2017-01-06 11:16:06 +01:00
backref.c	Btrfs: do not start a transaction at iterate_extent_inodes()	2019-06-11 12:23:38 +02:00
backref.h	btrfs: cleanup, remove inode_item_info helper	2015-01-14 19:23:47 +01:00
btrfs_inode.h	Btrfs: Direct I/O: Fix space accounting	2015-09-21 13:47:55 -07:00
check-integrity.c	Merge branch 'cleanups/for-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.4	2015-10-21 18:21:40 -07:00
check-integrity.h
compression.c	btrfs: assign error values to the correct bio structs	2016-10-22 12:26:54 +02:00
compression.h	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00
ctree.c	Btrfs: memset to avoid stale content in btree leaf	2019-01-16 22:16:07 +01:00
ctree.h	btrfs: tree-checker: Verify block_group_item	2019-01-16 22:16:09 +01:00
delayed-inode.c	btrfs: limit async_work allocation and worker func duration	2017-01-06 11:16:06 +01:00
delayed-inode.h	btrfs: properly set the termination value of ctx->pos in readdir	2016-02-25 12:01:15 -08:00
delayed-ref.c	btrfs: qgroup: Fix a race in delayed_ref which leads to abort trans	2015-10-26 19:44:39 -07:00
delayed-ref.h	btrfs: qgroup: Fix a race in delayed_ref which leads to abort trans	2015-10-26 19:44:39 -07:00
dev-replace.c	btrfs: cleanup, stop casting for extent_map->lookup everywhere	2019-01-16 22:16:06 +01:00
dev-replace.h
dir-item.c	Btrfs: make xattr replace operations atomic	2014-11-20 17:20:07 -08:00
disk-io.c	btrfs: wait on ordered extents on abort cleanup	2019-01-26 09:42:50 +01:00
disk-io.h	btrfs: don't create or leak aliased root while cleaning up orphans	2018-11-10 07:41:36 -08:00
export.c	BTRFS: support NFSv2 export	2015-10-06 06:55:23 -07:00
export.h
extent-tree.c	btrfs: Honour FITRIM range constraints during free space trim	2019-06-11 12:23:50 +02:00
extent-tree.h	btrfs: qgroup: Add new qgroup calculation function	2015-06-10 09:25:49 -07:00
extent_io.c	Btrfs: fix corruption reading shared and compressed extents after hole punching	2019-03-23 08:44:36 +01:00
extent_io.h	btrfs: struct-funcs, constify readers	2019-01-16 22:16:07 +01:00
extent_map.c	btrfs: cleanup, stop casting for extent_map->lookup everywhere	2019-01-16 22:16:06 +01:00
extent_map.h	btrfs: cleanup, stop casting for extent_map->lookup everywhere	2019-01-16 22:16:06 +01:00
file-item.c	Merge branch 'cleanups-post-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.1	2015-03-25 10:52:48 -07:00
file.c	Btrfs: fix race between ranged fsync and writeback of adjacent ranges	2019-06-11 12:23:52 +02:00
free-space-cache.c	Btrfs: fix use-after-free when dumping free space	2018-12-13 09:21:32 +01:00
free-space-cache.h	Btrfs: keep track of largest extent in bitmaps	2015-10-21 18:55:40 -07:00
hash.c	btrfs: LLVMLinux: Remove VLAIS	2014-10-14 10:51:22 +02:00
hash.h
inode-item.c	Btrfs: consolidate btrfs_error() to btrfs_std_error()	2015-09-29 16:30:00 +02:00
inode-map.c	Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots	2016-03-03 15:07:12 -08:00
inode-map.h	Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots	2016-03-03 15:07:12 -08:00
inode.c	Btrfs: fix null pointer dereference on compressed write path error	2018-11-21 09:27:38 +01:00
ioctl.c	btrfs: Ensure btrfs_trim_fs can trim the whole filesystem	2018-12-01 09:46:41 +01:00
Kconfig	rcu: Make SRCU optional by using CONFIG_SRCU	2015-01-06 11:04:29 -08:00
locking.c	btrfs: comment the rest of implicit barriers before waitqueue_active	2015-10-10 18:42:00 +02:00
locking.h	btrfs: fix lockups from btrfs_clear_path_blocking	2014-11-19 10:34:35 -08:00
lzo.c	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00
Makefile	btrfs: Move leaf and node validation checker to tree-checker.c	2019-01-16 22:16:08 +01:00
math.h	btrfs: cleanup 64bit/32bit divs, compile time constants	2015-03-03 17:23:57 +01:00
ordered-data.c	Btrfs: change how we wait for pending ordered extents	2015-10-21 18:51:40 -07:00
ordered-data.h	Btrfs: change how we wait for pending ordered extents	2015-10-21 18:51:40 -07:00
orphan.c	btrfs: kill the key type accessor helpers	2014-09-17 13:37:12 -07:00
print-tree.c	btrfs: remove parameter blocksize from read_tree_block	2014-10-02 17:14:50 +02:00
print-tree.h
props.c	btrfs: cleanup iterating over prop_handlers array	2015-10-21 18:28:48 +02:00
props.h
qgroup.c	btrfs: qgroup: Dirty all qgroups before rescan	2018-11-21 09:27:38 +01:00
qgroup.h	btrfs: waiting on qgroup rescan should not always be interruptible	2016-09-07 08:32:43 +02:00
raid56.c	btrfs: raid56: properly unmap parity page in finish_parity_scrub()	2019-04-03 06:23:26 +02:00
raid56.h	Btrfs: add RAID 5/6 BTRFS_RBIO_REBUILD_MISSING operation	2015-08-09 07:34:26 -07:00
rcu-string.h
reada.c	btrfs: reada: Fix returned errno code	2015-10-21 18:29:50 +02:00
relocation.c	btrfs: Handle owner mismatch gracefully when walking up tree	2018-11-21 09:27:37 +01:00
root-tree.c	btrfs: don't create or leak aliased root while cleaning up orphans	2018-11-10 07:41:36 -08:00
scrub.c	btrfs: cleanup, stop casting for extent_map->lookup everywhere	2019-01-16 22:16:06 +01:00
send.c	Btrfs: send, fix infinite loop due to directory rename dependencies	2018-12-17 21:55:10 +01:00
send.h
struct-funcs.c	btrfs: struct-funcs, constify readers	2019-01-16 22:16:07 +01:00
super.c	Btrfs: ensure path name is null terminated at btrfs_control_ioctl	2018-12-13 09:21:26 +01:00
sysfs.c	btrfs: sysfs: don't leak memory when failing add fsid	2019-06-11 12:23:52 +02:00
sysfs.h	Btrfs: rename btrfs_kobj_rm_device to btrfs_sysfs_rm_device_link	2015-09-29 16:29:59 +02:00
transaction.c	btrfs: release metadata before running delayed refs	2018-12-13 09:21:27 +01:00
transaction.h	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-07-27 09:47:33 -07:00
tree-checker.c	btrfs: tree-checker: Fix misleading group system information	2019-01-16 22:16:10 +01:00
tree-checker.h	btrfs: tree-checker: Fix false panic for sanity test	2019-01-16 22:16:08 +01:00
tree-defrag.c	Btrfs: cleanup: remove unnecessary check before btrfs_free_path is called	2015-08-31 11:46:41 -07:00
tree-log.c	btrfs: remove WARN_ON in log_dir_items	2019-04-03 06:23:26 +02:00
tree-log.h	Btrfs: fix metadata inconsistencies after directory fsync	2015-03-26 17:56:23 -07:00
ulist.c	btrfs: ulist: Add ulist_del() function.	2015-06-10 09:26:17 -07:00
ulist.h	btrfs: ulist: Add ulist_del() function.	2015-06-10 09:26:17 -07:00
uuid-tree.c	btrfs: return the actual error value from from btrfs_uuid_tree_iterate	2017-11-30 08:37:28 +00:00
volumes.c	btrfs: ensure that a DUP or RAID1 block group has exactly two stripes	2019-03-23 08:44:36 +01:00
volumes.h	btrfs: tree-checker: Verify block_group_item	2019-01-16 22:16:09 +01:00
xattr.c	Btrfs: fix race when listing an inode's xattrs	2015-11-09 18:34:40 +00:00
xattr.h
zlib.c	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00