Luis Henriques bb7031c7e5 ceph: fix memory leak in __ceph_setxattr() ... commit eeca958dce0a9231d1969f86196653eb50fcc9b3 upstream. The ceph_inode_xattr needs to be released when removing an xattr. Easily reproducible running the 'generic/020' test from xfstests or simply by doing: attr -s attr0 -V 0 /mnt/test && attr -r attr0 /mnt/test While there, also fix the error path. Here's the kmemleak splat: unreferenced object 0xffff88001f86fbc0 (size 64): comm "attr", pid 244, jiffies 4294904246 (age 98.464s) hex dump (first 32 bytes): 40 fa 86 1f 00 88 ff ff 80 32 38 1f 00 88 ff ff @........28..... 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de ................ backtrace: [<ffffffff81560199>] kmemleak_alloc+0x49/0xa0 [<ffffffff810f3e5b>] kmem_cache_alloc+0x9b/0xf0 [<ffffffff812b157e>] __ceph_setxattr+0x17e/0x820 [<ffffffff812b1c57>] ceph_set_xattr_handler+0x37/0x40 [<ffffffff8111fb4b>] __vfs_removexattr+0x4b/0x60 [<ffffffff8111fd37>] vfs_removexattr+0x77/0xd0 [<ffffffff8111fdd1>] removexattr+0x41/0x60 [<ffffffff8111fe65>] path_removexattr+0x75/0xa0 [<ffffffff81120aeb>] SyS_lremovexattr+0xb/0x10 [<ffffffff81564b20>] entry_SYSCALL_64_fastpath+0x13/0x94 [<ffffffffffffffff>] 0xffffffffffffffff Signed-off-by: Luis Henriques <lhenriques@suse.com> Reviewed-by: "Yan, Zheng" <zyan@redhat.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-05-20 14:27:01 +02:00
..
acl.c	posix_acl: Clear SGID bit when setting file permissions	2016-10-31 04:13:58 -06:00
addr.c	mm, fs: introduce mapping_gfp_constraint()	2015-11-06 17:50:42 -08:00
cache.c	ceph: fix a comment typo	2015-11-02 23:36:47 +01:00
cache.h	ceph: fscache: add an interface to synchronize object store limit	2014-04-03 10:33:53 +08:00
caps.c	ceph: make fsync() wait unsafe requests that created/modified inode	2015-11-02 23:36:48 +01:00
ceph_frag.c	ceph: factor out libceph from Ceph file system	2010-10-20 15:37:28 -07:00
debugfs.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dir.c	ceph: rework dcache readdir	2015-06-25 11:49:32 +03:00
export.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
file.c	ceph: fix error handling in ceph_read_iter	2016-10-28 03:01:35 -04:00
inode.c	ceph: fix race during filling readdir cache	2016-10-07 15:23:42 +02:00
ioctl.c	ceph: fix divide-by-zero in __validate_layout()	2014-10-14 12:57:05 -07:00
ioctl.h	ceph: fully initialize new layout	2012-05-16 14:28:27 -05:00
Kconfig	ceph: add acl for cephfs	2013-12-31 20:32:01 +02:00
locks.c	Move locks API users to locks_lock_inode_wait()	2015-10-22 14:57:36 -04:00
Makefile	ceph: add acl for cephfs	2013-12-31 20:32:01 +02:00
mds_client.c	ceph: remove req from unsafe list when unregistering it	2017-03-15 09:57:13 +08:00
mds_client.h	ceph: make fsync() wait unsafe requests that created/modified inode	2015-11-02 23:36:48 +01:00
mdsmap.c	fs/ceph: replace pr_warning by pr_warn	2014-06-06 16:08:06 -07:00
snap.c	ceph: fix queuing inode to mdsdir's snaprealm	2015-09-08 23:14:29 +03:00
strings.c	ceph: rename snapshot support	2015-04-22 18:33:41 +03:00
super.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client	2015-09-11 12:33:03 -07:00
super.h	ceph: make fsync() wait unsafe requests that created/modified inode	2015-11-02 23:36:48 +01:00
xattr.c	ceph: fix memory leak in __ceph_setxattr()	2017-05-20 14:27:01 +02:00