android_kernel_oneplus_msm8998/net/lapb
Jeremy Sowden 709d8771fa lapb: fixed leak of control-blocks.
[ Upstream commit 6be8e297f9bcea666ea85ac7a6cd9d52d6deaf92 ]

lapb_register calls lapb_create_cb, which initializes the control-
block's ref-count to one, and __lapb_insert_cb, which increments it when
adding the new block to the list of blocks.

lapb_unregister calls __lapb_remove_cb, which decrements the ref-count
when removing control-block from the list of blocks, and calls lapb_put
itself to decrement the ref-count before returning.

However, lapb_unregister also calls __lapb_devtostruct to look up the
right control-block for the given net_device, and __lapb_devtostruct
also bumps the ref-count, which means that when lapb_unregister returns
the ref-count is still 1 and the control-block is leaked.

Call lapb_put after __lapb_devtostruct to fix leak.

Reported-by: syzbot+afb980676c836b4a0afa@syzkaller.appspotmail.com
Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-06-22 08:18:25 +02:00
..
Kconfig net/lapb: remove depends on CONFIG_EXPERIMENTAL 2013-01-11 11:40:01 -08:00
lapb_iface.c lapb: fixed leak of control-blocks. 2019-06-22 08:18:25 +02:00
lapb_in.c lapb: Neaten debugging 2012-05-17 18:45:20 -04:00
lapb_out.c lapb: Neaten debugging 2012-05-17 18:45:20 -04:00
lapb_subr.c lapb: Neaten debugging 2012-05-17 18:45:20 -04:00
lapb_timer.c net/lapb: re-send packets on timeout 2013-09-23 16:52:45 -04:00
Makefile Net: lapb: Makefile: Remove deprecated kbuild goal definitions 2010-11-22 08:16:14 -08:00