Kinglong Mee 5424427100 NFSv4: fix a reference leak caused WARNING messages ... commit 366a1569bff3fe14abfdf9285e31e05e091745f5 upstream. Because nfs4_opendata_access() has close the state when access is denied, so the state isn't leak. Rather than revert the commit a974deee47, I'd like clean the strange state close. [ 1615.094218] ------------[ cut here ]------------ [ 1615.094607] WARNING: CPU: 0 PID: 23702 at lib/list_debug.c:31 __list_add_valid+0x8e/0xa0 [ 1615.094913] list_add double add: new=ffff9d7901d9f608, prev=ffff9d7901d9f608, next=ffff9d7901ee8dd0. [ 1615.095458] Modules linked in: nfsv4(E) nfs(E) nfsd(E) tun bridge stp llc fuse ip_set nfnetlink vmw_vsock_vmci_transport vsock f2fs snd_seq_midi snd_seq_midi_event fscrypto coretemp ppdev crct10dif_pclmul crc32_pclmul ghash_clmulni_intel intel_rapl_perf vmw_balloon snd_ens1371 joydev gameport snd_ac97_codec ac97_bus snd_seq snd_pcm snd_rawmidi snd_timer snd_seq_device snd soundcore nfit parport_pc parport acpi_cpufreq tpm_tis tpm_tis_core tpm i2c_piix4 vmw_vmci shpchp auth_rpcgss nfs_acl lockd(E) grace sunrpc(E) xfs libcrc32c vmwgfx drm_kms_helper ttm drm crc32c_intel mptspi e1000 serio_raw scsi_transport_spi mptscsih mptbase ata_generic pata_acpi fjes [last unloaded: nfs] [ 1615.097663] CPU: 0 PID: 23702 Comm: fstest Tainted: G W E 4.11.0-rc1+ #517 [ 1615.098015] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 [ 1615.098807] Call Trace: [ 1615.099183] dump_stack+0x63/0x86 [ 1615.099578] __warn+0xcb/0xf0 [ 1615.099967] warn_slowpath_fmt+0x5f/0x80 [ 1615.100370] __list_add_valid+0x8e/0xa0 [ 1615.100760] nfs4_put_state_owner+0x75/0xc0 [nfsv4] [ 1615.101136] __nfs4_close+0x109/0x140 [nfsv4] [ 1615.101524] nfs4_close_state+0x15/0x20 [nfsv4] [ 1615.101949] nfs4_close_context+0x21/0x30 [nfsv4] [ 1615.102691] __put_nfs_open_context+0xb8/0x110 [nfs] [ 1615.103155] put_nfs_open_context+0x10/0x20 [nfs] [ 1615.103586] nfs4_file_open+0x13b/0x260 [nfsv4] [ 1615.103978] do_dentry_open+0x20a/0x2f0 [ 1615.104369] ? nfs4_copy_file_range+0x30/0x30 [nfsv4] [ 1615.104739] vfs_open+0x4c/0x70 [ 1615.105106] ? may_open+0x5a/0x100 [ 1615.105469] path_openat+0x623/0x1420 [ 1615.105823] do_filp_open+0x91/0x100 [ 1615.106174] ? __alloc_fd+0x3f/0x170 [ 1615.106568] do_sys_open+0x130/0x220 [ 1615.106920] ? __put_cred+0x3d/0x50 [ 1615.107256] SyS_open+0x1e/0x20 [ 1615.107588] entry_SYSCALL_64_fastpath+0x1a/0xa9 [ 1615.107922] RIP: 0033:0x7fab599069b0 [ 1615.108247] RSP: 002b:00007ffcf0600d78 EFLAGS: 00000246 ORIG_RAX: 0000000000000002 [ 1615.108575] RAX: ffffffffffffffda RBX: 00007fab59bcfae0 RCX: 00007fab599069b0 [ 1615.108896] RDX: 0000000000000200 RSI: 0000000000000200 RDI: 00007ffcf060255e [ 1615.109211] RBP: 0000000000040010 R08: 0000000000000000 R09: 0000000000000016 [ 1615.109515] R10: 00000000000006a1 R11: 0000000000000246 R12: 0000000000041000 [ 1615.109806] R13: 0000000000040010 R14: 0000000000001000 R15: 0000000000002710 [ 1615.110152] ---[ end trace 96ed63b1306bf2f3 ]--- Fixes: a974deee47 ("NFSv4: Fix memory and state leak in...") Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Cc: Trond Myklebust <trond.myklebust@primarydata.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-07-05 14:37:15 +02:00
..
blocklayout	nfs/blocklayout: Fix bad using of page offset in bl_read_pagelist	2015-10-21 15:55:47 -05:00
filelayout	NFSv4.1: nfs4_fl_prepare_ds must be careful about reporting success.	2017-01-19 20:17:22 +01:00
flexfilelayout	pNFS/flexfiles: Fix layoutcommit after a commit to DS	2016-10-07 15:23:45 +02:00
objlayout	osd fs: __r4w_get_page rely on PageUptodate for uptodate	2015-12-12 10:15:34 -08:00
cache_lib.c
cache_lib.h
callback.c	NFSv4.x: hide array-bounds warning	2016-12-02 09:09:01 +01:00
callback.h	NFS: Remove the left function defines in callback.h	2015-10-21 15:49:22 -05:00
callback_proc.c	NFS: Remove unneeded NFS_DEBUG checking before define NFSDBG_FACILITY	2015-10-21 15:49:23 -05:00
callback_xdr.c	NFS: Don't drop CB requests with invalid principals	2016-10-07 15:23:45 +02:00
client.c	nfs: get clone_blksize when probing fsinfo	2015-10-15 16:08:18 -04:00
delegation.c	NFSv4: nfs4_copy_delegation_stateid() must fail if the delegation is invalid	2016-10-28 03:01:31 -04:00
delegation.h
dir.c	NFSv4: Don't perform cached access checks before we've OPENed the file	2017-06-14 13:16:26 +02:00
direct.c
dns_resolve.c
dns_resolve.h
file.c	nfs_write_end(): fix handling of short copies	2017-01-09 08:07:52 +01:00
fscache-index.c
fscache.c
fscache.h
getroot.c
inode.c	nfs: use file_dentry()	2016-04-20 15:42:13 +09:00
internal.h	sched/wait: Fix the signal handling fix	2015-12-13 14:30:59 -08:00
iostat.h
Kconfig
Makefile
mount_clnt.c	NFS: Remove unneeded NFS_DEBUG checking before define NFSDBG_FACILITY	2015-10-21 15:49:23 -05:00
namespace.c
netns.h
nfs.h
nfs2super.c
nfs2xdr.c
nfs3_fs.h
nfs3acl.c
nfs3client.c
nfs3proc.c
nfs3super.c
nfs3xdr.c
nfs4_fs.h	NFSv4: Refactor NFSv4 error handling	2015-10-08 10:45:51 -04:00
nfs4client.c	nfs4: start callback_ident at idr 1	2015-11-23 21:59:42 -05:00
nfs4file.c	nfs: use file_dentry()	2016-04-20 15:42:13 +09:00
nfs4getroot.c
nfs4idmap.c	KEYS: Merge the type-specific data with the payload data	2015-10-21 15:18:36 +01:00
nfs4idmap.h
nfs4namespace.c
nfs4proc.c	NFSv4: fix a reference leak caused WARNING messages	2017-07-05 14:37:15 +02:00
nfs4renewd.c
nfs4session.c
nfs4session.h
nfs4state.c	nfs: Fix "Don't increment lock sequence ID after NFS4ERR_MOVED"	2017-06-17 06:39:38 +02:00
nfs4super.c
nfs4sysctl.c
nfs4trace.c
nfs4trace.h	NFS: Fix a tracepoint NULL-pointer dereference	2015-10-06 18:56:25 -04:00
nfs4xdr.c	NFSv4: fix getacl head length estimation	2017-03-12 06:37:30 +01:00
nfs42.h	nfs42: add CLONE proc functions	2015-10-15 16:07:36 -04:00
nfs42proc.c	NFSv4.2: Fix a reference leak in nfs42_proc_layoutstats_generic	2016-10-28 03:01:31 -04:00
nfs42xdr.c	nfs42: add CLONE xdr functions	2015-10-15 16:07:21 -04:00
nfsroot.c	nfsroot: make nfsroot to accept the 1024 bytes long directory name	2015-10-21 15:49:19 -05:00
nfstrace.c
nfstrace.h
pagelist.c	sched/wait: Fix the signal handling fix	2015-12-13 14:30:59 -08:00
pnfs.c	pNFS: Fix race in pnfs_wait_on_layoutreturn	2017-01-19 20:17:22 +01:00
pnfs.h
pnfs_dev.c
pnfs_nfs.c
proc.c
read.c	NFSv4.1/pnfs: Retry through MDS when getting bad length of data	2015-10-21 15:55:47 -05:00
super.c	NFS: Remove the left global variable nfs_callback_tcpport	2015-10-21 15:49:22 -05:00
symlink.c
sysctl.c
unlink.c
write.c	nfs: don't create zero-length requests	2016-08-20 18:09:21 +02:00