android_kernel_oneplus_msm8998/net/rfkill
Johannes Berg 33bf18e4aa rfkill: fix rfkill_fop_read wait_event usage
commit 6736fde9672ff6717ac576e9bba2fd5f3dfec822 upstream.

The code within wait_event_interruptible() is called with
!TASK_RUNNING, so mustn't call any functions that can sleep,
like mutex_lock().

Since we re-check the list_empty() in a loop after the wait,
it's safe to simply use list_empty() without locking.

This bug has existed forever, but was only discovered now
because all userspace implementations, including the default
'rfkill' tool, use poll() or select() to get a readable fd
before attempting to read.

Fixes: c64fb01627 ("rfkill: create useful userspace interface")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-03-03 15:07:26 -08:00
..
core.c rfkill: fix rfkill_fop_read wait_event usage 2016-03-03 15:07:26 -08:00
input.c rfkill: don't use [delayed_]work_pending() 2012-12-28 13:40:16 -08:00
Kconfig rfkill: Allow compile test of GPIO consumers if !GPIOLIB 2015-08-13 10:48:52 +02:00
Makefile
rfkill-gpio.c net: rfkill: gpio: Remove BCM2E39 support 2015-08-11 21:26:27 +02:00
rfkill-regulator.c net: rfkill: drop owner assignment from platform_drivers 2014-10-20 16:21:58 +02:00
rfkill.h