Gaurav Kohli a5e204282a kthread/smpboot: Serialize kthread parking against wakeup ... The control cpu thread which initiates hotplug calls kthread_park() for hotplug thread and sets KTHREAD_SHOULD_PARK. After this control thread wakes up the hotplug thread. There is a chance that wakeup code sees the hotplug thread (running on AP core) in INTERRUPTIBLE state, but sets its state to RUNNING after hotplug thread has entered kthread_parkme() and changed its state to TASK_PARKED. This can result in panic later on in kthread_unpark(), as it sees KTHREAD_IS_PARKED flag set but fails to rebind the kthread, due to it being not in TASK_PARKED state. Fix this, by serializing wakeup state change, against state change before parking the kthread. Below is the possible race: Control thread Hotplug Thread kthread_park() set KTHREAD_SHOULD_PARK smpboot_thread_fn set_current_state(TASK_INTERRUPTIBLE); kthread_parkme wake_up_process() raw_spin_lock_irqsave(&p->pi_lock, flags); if (!(p->state & state)) -> this will fail goto out; __kthread_parkme __set_current_state(TASK_PARKED); if (p->on_rq && ttwu_remote(p, wake_flags)) ttwu_remote() p->state = TASK_RUNNING; schedule(); So to avoid this race, take pi_lock to serial state changes. Change-Id: Ie71645d37046f7ee74df880dbead29efbaad199a Suggested-by: Pavankumar Kondeti <pkondeti@codeaurora.org> Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org> Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>		2018-09-07 04:49:36 -07:00
..
bpf	bpf: fix references to free_bpf_prog_info() in comments	2018-08-06 16:24:37 +02:00
configs	UPSTREAM: config: android-base: disable CONFIG_NFSD and CONFIG_NFS_FS	2018-02-05 08:58:36 -08:00
debug	This is the 4.4.134 stable release	2018-05-30 13:25:24 +02:00
events	Merge android-4.4.135 (c9d74f2) into msm-4.4	2018-06-27 14:42:55 +05:30
gcov	gcov: disable for COMPILE_TEST	2018-01-23 19:50:10 +01:00
irq	Merge android-4.4.148 (f057ff9) into msm-4.4	2018-08-24 00:07:01 +05:30
livepatch
locking	Merge android-4.4.153 (5e24b4e) into msm-4.4	2018-08-28 17:28:39 +05:30
power	Revert "power: wakeup_reason: send uevent to user space"	2018-08-06 20:47:40 +08:00
printk	printk: Make the console flush configurable in hotplug path	2018-09-06 04:04:46 -07:00
rcu	Merge android-4.4.107 (79f138a) into msm-4.4	2018-01-18 12:49:58 +05:30
sched	Merge "Merge android-4.4.142 (8ec9fd8) into msm-4.4"	2018-08-14 08:35:05 -07:00
time	Merge android-4.4.148 (f057ff9) into msm-4.4	2018-08-24 00:07:01 +05:30
trace	Merge android-4.4.153 (5e24b4e) into msm-4.4	2018-08-28 17:28:39 +05:30
.gitignore
acct.c	kernel/acct.c: fix the acct->needcheck check in check_free_space()	2018-01-10 09:27:08 +01:00
async.c	kernel/async.c: revert "async: simplify lowest_in_progress()"	2018-02-16 20:09:45 +01:00
audit.c	This is the 4.4.134 stable release	2018-05-30 13:25:24 +02:00
audit.h
audit_fsnotify.c
audit_tree.c
audit_watch.c	audit: Fix use after free in audit_remove_watch_rule()	2017-08-24 17:02:35 -07:00
auditfilter.c	audit: allow not equal op for audit by executable	2018-08-06 16:24:38 +02:00
auditsc.c	Merge android-4.4.146 (13962260) into msm-4.4	2018-08-07 15:36:56 +05:30
backtracetest.c
bounds.c
capability.c
cgroup.c	cgroup: Fix deadlock in cpu hotplug path	2018-08-13 23:21:04 -07:00
cgroup_freezer.c
cgroup_pids.c
compat.c
configs.c
context_tracking.c
cpu.c	cgroup/cpuset: remove circular dependency deadlock	2017-09-13 00:24:53 -07:00
cpu_pm.c
cpuset.c	Merge android-4.4@73a2b70 (v4.4.92) into msm-4.4	2017-10-20 02:11:57 -07:00
crash_dump.c
cred.c
delayacct.c
dma.c
elfcore.c
exec_domain.c
exit.c	Merge android-4.4.142 (8ec9fd8) into msm-4.4	2018-08-03 16:59:20 +05:30
extable.c	kernel/extable.c: mark core_kernel_text notrace	2017-07-21 07:44:56 +02:00
fork.c	Merge android-4.4.142 (8ec9fd8) into msm-4.4	2018-08-03 16:59:20 +05:30
freezer.c
futex.c	Merge android-4.4.133 (3f51ea2) into msm-4.4	2018-05-31 12:28:38 +05:30
futex_compat.c
groups.c	kernel: make groups_sort calling a responsibility group_info allocators	2018-01-10 09:27:10 +01:00
hung_task.c
irq_work.c
jump_label.c	jump_label: Invoke jump_label_test() via early_initcall()	2017-12-16 10:33:55 +01:00
kallsyms.c
kcmp.c
Kconfig.freezer
Kconfig.hz
Kconfig.locks
Kconfig.preempt
kcov.c	UPSTREAM: kcov: fix comparison callback signature	2017-12-18 09:41:57 -08:00
kexec.c
kexec_core.c
kexec_file.c
kexec_internal.h
kmod.c
kprobes.c	kprobes/x86: Fix to set RWX bits correctly before releasing trampoline	2018-04-08 11:51:56 +02:00
ksysfs.c
kthread.c	UPSTREAM: kthread: Pin the stack via try_get_task_stack()/put_task_stack() in to_live_kthread() function	2017-08-09 15:23:22 +01:00
latencytop.c
Makefile	BACKPORT: kernel: add kcov code coverage	2017-12-18 09:41:57 -08:00
membarrier.c
memremap.c
module-internal.h
module.c	Merge android-4.4.118 (5f7f76a) into msm-4.4	2018-03-01 17:20:34 +05:30
module_signing.c
notifier.c
nsproxy.c
padata.c	padata: free correct variable	2017-05-20 14:27:02 +02:00
panic.c	soc: qcom: dump current task stack and task_struct for minidump	2017-09-01 02:51:08 -07:00
params.c
pid.c	pidns: disable pid allocation if pid_ns_prepare_proc() is failed in alloc_pid()	2018-04-13 19:50:03 +02:00
pid_namespace.c	pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes	2017-05-25 14:30:11 +02:00
profile.c	profile: hide unused functions when !CONFIG_PROC_FS	2018-02-25 11:03:44 +01:00
ptrace.c	ptrace: Properly initialize ptracer_cred on fork	2017-06-14 13:16:20 +02:00
range.c
reboot.c
relay.c	kernel/relay.c: limit kmalloc size to KMALLOC_MAX_SIZE	2018-05-30 07:49:00 +02:00
resource.c	Merge android-4.4.129 (b1c4836) into msm-4.4	2018-04-24 19:07:57 +05:30
seccomp.c	seccomp: Move speculation migitation control to arch code	2018-07-25 10:18:27 +02:00
signal.c	kernel/signal.c: avoid undefined behaviour in kill_something_info	2018-05-30 07:48:52 +02:00
smp.c
smpboot.c	kthread/smpboot: Serialize kthread parking against wakeup	2018-09-07 04:49:36 -07:00
smpboot.h
softirq.c	softirq: Don't defer all softirq during RT task	2018-03-22 23:20:10 -07:00
stacktrace.c
stop_machine.c
sys.c	kernel/sys.c: fix merge error with 4.4.144	2018-07-31 20:28:27 +02:00
sys_ni.c
sysctl.c	trace/irq: Add trace point to track IRQs disable callers	2018-04-24 11:33:20 +05:30
sysctl_binary.c	netfilter: nf_defrag_ipv4: Add sysctl to disable per interface	2018-01-10 13:57:22 -07:00
task_work.c
taskstats.c	taskstats: fix the length of cgroupstats_cmd_get_policy	2018-05-03 14:03:24 -07:00
test_kprobes.c
torture.c
tracepoint.c	tracepoint: Do not warn on ENOMEM	2018-05-16 10:06:47 +02:00
tsacct.c
uid16.c	kernel: make groups_sort calling a responsibility group_info allocators	2018-01-10 09:27:10 +01:00
up.c
user-return-notifier.c
user.c	ANDROID: proc: Add /proc/uid directory	2018-03-06 20:39:55 +00:00
user_namespace.c
utsname.c
utsname_sysctl.c
watchdog.c
workqueue.c	Merge android-4.4.135 (c9d74f2) into msm-4.4	2018-06-27 14:42:55 +05:30
workqueue_internal.h	workqueue: Fix NULL pointer dereference	2017-11-15 17:13:11 +01:00