Catalin Marinas d2e646c723 arm64: Add trace_hardirqs_off annotation in ret_to_user ... commit db3899a6477a4dccd26cbfb7f408b6be2cc068e0 upstream. When a kernel is built with CONFIG_TRACE_IRQFLAGS the following warning is produced when entering userspace for the first time: WARNING: at /work/Linux/linux-2.6-aarch64/kernel/locking/lockdep.c:3519 Modules linked in: CPU: 1 PID: 1 Comm: systemd Not tainted 4.4.0-rc3+ #639 Hardware name: Juno (DT) task: ffffffc9768a0000 ti: ffffffc9768a8000 task.ti: ffffffc9768a8000 PC is at check_flags.part.22+0x19c/0x1a8 LR is at check_flags.part.22+0x19c/0x1a8 pc : [<ffffffc0000fba6c>] lr : [<ffffffc0000fba6c>] pstate: 600001c5 sp : ffffffc9768abe10 x29: ffffffc9768abe10 x28: ffffffc9768a8000 x27: 0000000000000000 x26: 0000000000000001 x25: 00000000000000a6 x24: ffffffc00064be6c x23: ffffffc0009f249e x22: ffffffc9768a0000 x21: ffffffc97fea5480 x20: 00000000000001c0 x19: ffffffc00169a000 x18: 0000005558cc7b58 x17: 0000007fb78e3180 x16: 0000005558d2e238 x15: ffffffffffffffff x14: 0ffffffffffffffd x13: 0000000000000008 x12: 0101010101010101 x11: 7f7f7f7f7f7f7f7f x10: fefefefefefeff63 x9 : 7f7f7f7f7f7f7f7f x8 : 6e655f7371726964 x7 : 0000000000000001 x6 : ffffffc0001079c4 x5 : 0000000000000000 x4 : 0000000000000001 x3 : ffffffc001698438 x2 : 0000000000000000 x1 : ffffffc9768a0000 x0 : 000000000000002e Call trace: [<ffffffc0000fba6c>] check_flags.part.22+0x19c/0x1a8 [<ffffffc0000fc440>] lock_is_held+0x80/0x98 [<ffffffc00064bafc>] __schedule+0x404/0x730 [<ffffffc00064be6c>] schedule+0x44/0xb8 [<ffffffc000085bb0>] ret_to_user+0x0/0x24 possible reason: unannotated irqs-off. irq event stamp: 502169 hardirqs last enabled at (502169): [<ffffffc000085a98>] el0_irq_naked+0x1c/0x24 hardirqs last disabled at (502167): [<ffffffc0000bb3bc>] __do_softirq+0x17c/0x298 softirqs last enabled at (502168): [<ffffffc0000bb43c>] __do_softirq+0x1fc/0x298 softirqs last disabled at (502143): [<ffffffc0000bb830>] irq_exit+0xa0/0xf0 This happens because we disable interrupts in ret_to_user before calling schedule() in work_resched. This patch adds the necessary trace_hardirqs_off annotation. Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> Reported-by: Mark Rutland <mark.rutland@arm.com> Cc: Will Deacon <will.deacon@arm.com> Signed-off-by: Will Deacon <will.deacon@arm.com> Cc: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-09-29 03:08:54 -07:00
..
alpha	sys: don't hold uts_sem while accessing userspace memory	2018-09-09 20:04:35 +02:00
arc	ARC: [plat-axs*]: Enable SWAP	2018-09-19 22:48:56 +02:00
arm	ARM: hisi: check of_iomap and fix missing of_node_put	2018-09-26 08:35:09 +02:00
arm64	arm64: Add trace_hardirqs_off annotation in ret_to_user	2018-09-29 03:08:54 -07:00
avr32	avr32: off by one in at32_init_pio()	2016-10-07 15:23:45 +02:00
blackfin	pinctrl: adi2: Fix Kconfig build problem	2017-12-20 10:05:00 +01:00
c6x	c6x/ptrace: Remove useless PTRACE_SETREGSET implementation	2017-03-31 09:49:53 +02:00
cris	cris: Only build flash rescue image if CONFIG_ETRAX_AXISFLASHMAP is selected	2017-01-12 11:22:48 +01:00
frv	futex: Remove duplicated code and fix undefined behaviour	2018-05-26 08:48:50 +02:00
h8300	h8300/ptrace: Fix incorrect register transfer count	2017-03-31 09:49:53 +02:00
hexagon	futex: Remove duplicated code and fix undefined behaviour	2018-05-26 08:48:50 +02:00
ia64	futex: Remove duplicated code and fix undefined behaviour	2018-05-26 08:48:50 +02:00
m32r	m32r: fix __get_user()	2016-09-24 10:07:43 +02:00
m68k	m68k: fix "bad page state" oops on ColdFire boot	2018-08-24 13:26:57 +02:00
metag	metag/uaccess: Check access_ok in strncpy_from_user	2017-05-25 14:30:16 +02:00
microblaze	microblaze: Fix simpleImage format generation	2018-08-06 16:24:39 +02:00
mips	MIPS: VDSO: Match data page cache colouring when D$ aliases	2018-09-26 08:35:10 +02:00
mn10300	mn10300/misalignment: Use SIGSEGV SEGV_MAPERR to report a failed user copy	2018-02-16 20:09:47 +01:00
nios2	nios2: reserve boot memory for device tree	2017-04-12 12:38:34 +02:00
openrisc	kthread: fix boot hang (regression) on MIPS/OpenRISC	2018-09-19 22:48:55 +02:00
parisc	parisc: Remove unnecessary barriers from spinlock.h	2018-08-24 13:27:01 +02:00
powerpc	powerpc/powernv: opal_put_chars partial write fix	2018-09-26 08:35:06 +02:00
s390	s390/lib: use expoline for all bcr instructions	2018-09-15 09:40:42 +02:00
score	score: fix copy_from_user() and friends	2016-09-24 10:07:44 +02:00
sh	sh: New gcc support	2018-06-06 16:46:20 +02:00
sparc	sys: don't hold uts_sem while accessing userspace memory	2018-09-09 20:04:35 +02:00
tile	futex: Remove duplicated code and fix undefined behaviour	2018-05-26 08:48:50 +02:00
um	um: Use POSIX ucontext_t instead of struct ucontext	2018-04-24 09:32:08 +02:00
unicore32	pwm: Changes for v4.4-rc1	2015-11-11 09:16:10 -08:00
x86	xen/x86/vpmu: Zero struct pt_regs before calling into sample handling code	2018-09-29 03:08:51 -07:00
xtensa	signal/xtensa: Consistenly use SIGBUS in do_unaligned_user	2018-07-03 11:21:26 +02:00
.gitignore
Kconfig