Borislav Petkov 9d01e4cd7e ide-tape: fix proc warning ... ide_tape_chrdev_get() was missing an ide_device_get() refcount increment which lead to the following warning: [ 278.147906] ------------[ cut here ]------------ [ 278.152685] WARNING: at fs/proc/generic.c:847 remove_proc_entry+0x199/0x1b8() [ 278.160070] Hardware name: P4I45PE 1.00 [ 278.160076] remove_proc_entry: removing non-empty directory 'ide0/hdb', leaking at least 'name' [ 278.160080] Modules linked in: rtc intel_agp pcspkr thermal processor thermal_sys parport_pc parport agpgart button [ 278.160100] Pid: 2312, comm: mt Not tainted 2.6.30-rc2 #3 [ 278.160105] Call Trace: [ 278.160117] [<c012141d>] warn_slowpath+0x71/0xa0 [ 278.160126] [<c035f219>] ? _spin_unlock_irqrestore+0x29/0x2c [ 278.160132] [<c011c686>] ? try_to_wake_up+0x1b6/0x1c0 [ 278.160141] [<c011c69b>] ? default_wake_function+0xb/0xd [ 278.160149] [<c0177ead>] ? pollwake+0x4a/0x55 [ 278.160156] [<c035f240>] ? _spin_unlock+0x24/0x26 [ 278.160163] [<c0165d38>] ? add_partial+0x44/0x49 [ 278.160169] [<c01669e8>] ? __slab_free+0xba/0x29c [ 278.160177] [<c01a13d8>] ? sysfs_delete_inode+0x0/0x3c [ 278.160184] [<c019ca92>] remove_proc_entry+0x199/0x1b8 [ 278.160191] [<c01a297e>] ? remove_dir+0x27/0x2e [ 278.160199] [<c025f3ab>] ide_proc_unregister_device+0x40/0x4c [ 278.160207] [<c02599cd>] drive_release_dev+0x14/0x47 [ 278.160214] [<c0250538>] device_release+0x35/0x5a [ 278.160221] [<c01f8bed>] kobject_release+0x40/0x50 [ 278.160226] [<c01f8bad>] ? kobject_release+0x0/0x50 [ 278.160232] [<c01f96ac>] kref_put+0x3c/0x4a [ 278.160238] [<c01f8b29>] kobject_put+0x37/0x3c [ 278.160243] [<c025020c>] put_device+0xf/0x11 [ 278.160249] [<c025789f>] ide_device_put+0x2d/0x30 [ 278.160255] [<c02658da>] ide_tape_put+0x24/0x32 [ 278.160261] [<c0266e0c>] idetape_chrdev_release+0x17f/0x18e [ 278.160269] [<c016c4f5>] __fput+0xca/0x175 [ 278.160275] [<c016c5b9>] fput+0x19/0x1b [ 278.160280] [<c0169d19>] filp_close+0x51/0x5b [ 278.160286] [<c0169d96>] sys_close+0x73/0xad [ 278.160293] [<c0102a61>] syscall_call+0x7/0xb [ 278.160298] ---[ end trace f16d907ea1f89336 ]--- Instead of trivially fixing it by adding the missing call, ide_tape_chrdev_get() and ide_tape_get() were merged into one function since both were almost identical. The only difference was that ide_tape_chrdev_get() was accessing the ide-tape reference through the idetape_devs[] array of minors instead of through the gendisk. Accomodate that by adding two additional parameters to ide_tape_get() to annotate the call site and invoke the proper behavior. As a result, remove ide_tape_chrdev_get(). Signed-off-by: Borislav Petkov <petkovbb@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>		2009-06-08 22:03:03 +02:00
..
accessibility
acpi	Revert "ACPI battery: fix async boot oops"	2009-04-11 12:45:20 -07:00
amba
ata	[libata] fix build error on drivers/ata/pata_legacy.c	2009-04-17 19:05:33 -04:00
atm	Replace all DMA_nBIT_MASK macro with DMA_BIT_MASK(n)	2009-04-13 15:04:33 -07:00
auxdisplay
base	driver core: prevent device_for_each_child from oopsing	2009-04-16 16:17:11 -07:00
block	USB: add reset endpoint operations	2009-04-17 10:50:27 -07:00
bluetooth
cdrom
char	Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	2009-04-17 09:56:11 -07:00
clocksource
connector
cpufreq
cpuidle
crypto	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
dca
dio
dma	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
edac	edac: use to_delayed_work()	2009-04-13 15:04:34 -07:00
eisa
firewire
firmware	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
gpio
gpu	Merge branch 'drm-intel-next' of git://git.kernel.org/pub/scm/linux/kernel/git/anholt/drm-intel	2009-04-14 13:16:40 -07:00
hid
hwmon	hwmon: sht15 humidity sensor driver	2009-04-13 15:04:29 -07:00
i2c	i2c: Let new-style drivers implement attach_adapter	2009-04-13 17:02:14 +02:00
ide	ide-tape: fix proc warning	2009-06-08 22:03:03 +02:00
idle	dma-mapping: replace all DMA_64BIT_MASK macro with DMA_BIT_MASK(64)	2009-04-07 08:31:10 -07:00
ieee1394	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
infiniband	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband	2009-04-09 16:42:26 -07:00
input	Merge branch 'next' into for-linus	2009-04-16 08:51:52 -07:00
isdn	USB: add reset endpoint operations	2009-04-17 10:50:27 -07:00
leds	leds: just ignore invalid GPIOs in leds-gpio	2009-04-08 14:13:48 +01:00
lguest
macintosh	mediabay: fix build for CONFIG_BLOCK=n	2009-04-22 20:33:41 +02:00
mca
md	block: move bio list helpers into bio.h	2009-04-15 08:28:09 +02:00
media	USB: add reset endpoint operations	2009-04-17 10:50:27 -07:00
memstick	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
message	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
mfd
misc	sgi-xpc: clean up numerous globals	2009-04-13 15:04:33 -07:00
mmc	mmc_spi: support for non-byte-aligned cards	2009-04-08 20:45:51 +02:00
mtd
net	Merge master.kernel.org:/home/rmk/linux-2.6-arm	2009-04-17 13:51:14 -07:00
nubus
of
oprofile
parisc	parport: Fix various uses of parport_pc	2009-04-14 08:48:50 -07:00
parport	parport: Use the PCI IRQ if offered	2009-04-07 08:44:06 -07:00
pci	Merge git://git.infradead.org/iommu-2.6	2009-04-13 11:35:50 -07:00
pcmcia
platform	Merge branches 'release', 'APERF', 'ARAT', 'misc', 'kelvin', 'device-lock' and 'bjorn.notify' into release	2009-04-07 18:18:42 -04:00
pnp	dma-mapping: replace all DMA_24BIT_MASK macro with DMA_BIT_MASK(24)	2009-04-07 08:31:12 -07:00
power	Merge git://git.infradead.org/battery-2.6	2009-04-08 17:45:02 -07:00
ps3
rapidio	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
regulator
rtc
s390	[S390] dasd: fix idaw boundary checking for track based ccw	2009-04-14 15:37:25 +02:00
sbus	sbus: changed ioctls to unlocked	2009-04-14 19:46:19 -07:00
scsi	Fix lpfc_parse_bg_err()'s use of do_div()	2009-04-14 09:58:17 -07:00
serial	[ARM] 5449/1: S3C: Use disable_irq_nosync() to fix boot lockups	2009-04-15 10:01:02 +01:00
sh
sn	dma-mapping: replace all DMA_64BIT_MASK macro with DMA_BIT_MASK(64)	2009-04-07 08:31:10 -07:00
spi	Merge branch 'fix' of git://git.kernel.org/pub/scm/linux/kernel/git/ycmiao/pxa-linux-2.6	2009-04-15 09:58:21 +01:00
ssb
staging	staging: slicoss: update README	2009-04-17 11:06:31 -07:00
tc
telephony
thermal
uio	UIO: fix specific device driver missing statement for depmod	2009-04-16 16:17:11 -07:00
usb	WUSB: correct format of wusb_chid sysfs file	2009-04-17 10:50:29 -07:00
uwb	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
video	intelfb: support i854	2009-04-13 15:04:32 -07:00
virtio
w1
watchdog	[WATCHDOG] omap_wdt.c: move probe function to .devinit.text	2009-04-08 06:21:57 +00:00
xen	xen: honour VCPU availability on boot	2009-04-08 14:25:51 -07:00
zorro
Kconfig
Makefile