Junxiao Bi dc3e6de00b ocfs2: fix posix_acl_create deadlock ... commit c25a1e0671fbca7b2c0d0757d533bd2650d6dc0c upstream. Commit 702e5bc68a ("ocfs2: use generic posix ACL infrastructure") refactored code to use posix_acl_create. The problem with this function is that it is not mindful of the cluster wide inode lock making it unsuitable for use with ocfs2 inode creation with ACLs. For example, when used in ocfs2_mknod, this function can cause deadlock as follows. The parent dir inode lock is taken when calling posix_acl_create -> get_acl -> ocfs2_iop_get_acl which takes the inode lock again. This can cause deadlock if there is a blocked remote lock request waiting for the lock to be downconverted. And same deadlock happened in ocfs2_reflink. This fix is to revert back using ocfs2_init_acl. Fixes: 702e5bc68a ("ocfs2: use generic posix ACL infrastructure") Signed-off-by: Tariq Saeed <tariq.x.saeed@oracle.com> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com> Cc: Mark Fasheh <mfasheh@suse.de> Cc: Joel Becker <jlbec@evilplan.org> Cc: Joseph Qi <joseph.qi@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2016-05-18 17:06:44 -07:00
..
cluster	Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2015-11-13 20:04:17 -08:00
dlm	ocfs2/dlm: fix BUG in dlm_move_lockres_to_recovery_list	2016-04-12 09:09:04 -07:00
dlmfs	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
acl.c	ocfs2: fix posix_acl_create deadlock	2016-05-18 17:06:44 -07:00
acl.h	ocfs2: fix posix_acl_create deadlock	2016-05-18 17:06:44 -07:00
alloc.c	ocfs2: clean up redundant NULL checks before kfree	2015-09-04 16:54:41 -07:00
alloc.h	ocfs2: reflink: fix slow unlink for refcounted file	2014-12-18 19:08:11 -08:00
aops.c	ocfs2: unlock inode if deleting inode from orphan fails	2016-03-03 15:07:10 -08:00
aops.h	ocfs2: remove OCFS2_IOCB_SEM lock type in direct io	2015-06-24 17:49:39 -07:00
blockcheck.c
blockcheck.h
buffer_head_io.c	ocfs2: clear the rest of the buffers on error	2015-09-04 16:54:41 -07:00
buffer_head_io.h
dcache.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dcache.h	ocfs2: revert iput deferring code in ocfs2_drop_dentry_lock	2014-04-03 16:20:55 -07:00
dir.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
dir.h	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
dlmglue.c	ocfs2: NFS hangs in __ocfs2_cluster_lock due to race with ocfs2_unblock_lock	2016-02-17 12:30:55 -08:00
dlmglue.h	ocfs2: avoid blocking in ocfs2_mark_lockres_freeing() in downconvert thread	2014-04-03 16:20:55 -07:00
export.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
export.h
extent_map.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
extent_map.h
file.c	ocfs2: revert using ocfs2_acl_chmod to avoid inode cluster lock hang	2016-05-18 17:06:43 -07:00
file.h	ocfs2: prepare some interfaces used in append direct io	2015-02-16 17:56:04 -08:00
heartbeat.c
heartbeat.h
inode.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
inode.h	ocfs2: only take lock if dio entry when recover orphans	2015-11-05 19:34:48 -08:00
ioctl.c	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
ioctl.h
journal.c	ocfs2: add uuid to ocfs2 thread name for problem analysis	2015-11-05 19:34:48 -08:00
journal.h	ocfs2: add functions to add and remove inode in orphan dir	2015-02-16 17:56:04 -08:00
Kconfig
localalloc.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
localalloc.h
locks.c	ocfs2: fix flock panic issue	2015-12-29 17:45:49 -08:00
locks.h
Makefile
mmap.c	mm: drop vm_ops->remap_pages and generic_file_remap_pages() stub	2015-02-10 14:30:30 -08:00
mmap.h
move_extents.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
move_extents.h
namei.c	ocfs2: fix posix_acl_create deadlock	2016-05-18 17:06:44 -07:00
namei.h	ocfs2: do not include dio entry in case of orphan scan	2015-11-05 19:34:48 -08:00
ocfs1_fs_compat.h
ocfs2.h	ocfs2: add errors=continue	2015-09-04 16:54:41 -07:00
ocfs2_fs.h	treewide: fix typos in comment blocks	2015-08-07 14:46:24 +02:00
ocfs2_ioctl.h
ocfs2_lockid.h
ocfs2_lockingver.h
ocfs2_trace.h	ocfs2: fix a tiny race when running dirop_fileop_racer	2014-06-23 16:47:45 -07:00
quota.h	ocfs2: Move OLQF_CLEAN flag out of generic quota flags	2015-01-21 19:21:30 +01:00
quota_global.c	ocfs2: Don't use MAXQUOTAS value	2014-09-17 11:59:12 +02:00
quota_local.c	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
refcounttree.c	ocfs2: fix posix_acl_create deadlock	2016-05-18 17:06:44 -07:00
refcounttree.h
reservations.c	ocfs2: make resv_lock spinlock static	2015-02-10 14:30:29 -08:00
reservations.h
resize.c	ocfs2: fix BUG when calculate new backup super	2015-12-29 17:45:49 -08:00
resize.h
slot_map.c	ocfs2: one function call less in ocfs2_init_slot_info() after error detection	2015-04-14 16:48:57 -07:00
slot_map.h
stack_o2cb.c	ocfs2: avoid a pointless delay in o2cb_cluster_check()	2015-04-14 16:48:57 -07:00
stack_user.c	char: make misc_deregister a void function	2015-08-05 10:35:49 -07:00
stackglue.c	ocfs2: remove NULL assignments on static	2014-06-04 16:53:53 -07:00
stackglue.h
suballoc.c	ocfs2: improve performance for localalloc	2015-11-05 19:34:48 -08:00
suballoc.h	ocfs2: rollback alloc_dinode counts when ocfs2_block_group_set_bits() failed	2014-04-03 16:20:56 -07:00
super.c	fs: create and use seq_show_option for escaping	2015-09-04 16:54:41 -07:00
super.h	ocfs2: neaten do_error, ocfs2_error and ocfs2_abort	2015-09-04 16:54:41 -07:00
symlink.c
symlink.h
sysfile.c	ocfs2: avoid system inode ref confusion by adding mutex lock	2014-04-03 16:20:57 -07:00
sysfile.h
uptodate.c	ocfs2: remove NULL assignments on static	2014-06-04 16:53:53 -07:00
uptodate.h
xattr.c	ocfs2: fix posix_acl_create deadlock	2016-05-18 17:06:44 -07:00
xattr.h	ocfs2: fix posix_acl_create deadlock	2016-05-18 17:06:44 -07:00