Goldwyn Rodrigues ee5dd68788 btrfs: qgroup: Prevent qgroup->reserved from going subzero ... commit 0b34c261e235a5c74dcf78bd305845bd15fe2b42 upstream. While free'ing qgroup->reserved resources, we much check if the page has not been invalidated by a truncate operation by checking if the page is still dirty before reducing the qgroup resources. Resources in such a case are free'd when the entire extent is released by delayed_ref. This fixes a double accounting while releasing resources in case of truncating a file, reproduced by the following testcase. SCRATCH_DEV=/dev/vdb SCRATCH_MNT=/mnt mkfs.btrfs -f $SCRATCH_DEV mount -t btrfs $SCRATCH_DEV $SCRATCH_MNT cd $SCRATCH_MNT btrfs quota enable $SCRATCH_MNT btrfs subvolume create a btrfs qgroup limit 500m a $SCRATCH_MNT sync for c in {1..15}; do dd if=/dev/zero bs=1M count=40 of=$SCRATCH_MNT/a/file; done sleep 10 sync sleep 5 touch $SCRATCH_MNT/a/newfile echo "Removing file" rm $SCRATCH_MNT/a/file Fixes: b9d0b38928 ("btrfs: Add handler for invalidate page") Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2016-11-18 10:48:37 +01:00
..
tests	Btrfs: tests: checking for NULL instead of IS_ERR()	2015-11-25 05:19:50 -08:00
acl.c	posix_acl: Clear SGID bit when setting file permissions	2016-10-31 04:13:58 -06:00
async-thread.c	btrfs: async-thread: Fix a use-after-free error for trace	2016-03-09 15:34:49 -08:00
async-thread.h	btrfs: async_thread: Fix workqueue 'max_active' value when initializing	2015-08-31 11:46:40 -07:00
backref.c	Btrfs: fix hang on extent buffer lock caused by the inode_paths ioctl	2016-02-25 12:01:15 -08:00
backref.h
btrfs_inode.h	Btrfs: Direct I/O: Fix space accounting	2015-09-21 13:47:55 -07:00
check-integrity.c	Merge branch 'cleanups/for-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.4	2015-10-21 18:21:40 -07:00
check-integrity.h
compression.c	btrfs: assign error values to the correct bio structs	2016-10-22 12:26:54 +02:00
compression.h
ctree.c	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-07-27 09:47:33 -07:00
ctree.h	btrfs: properly track when rescan worker is running	2016-09-07 08:32:43 +02:00
delayed-inode.c	btrfs: properly set the termination value of ctx->pos in readdir	2016-02-25 12:01:15 -08:00
delayed-inode.h	btrfs: properly set the termination value of ctx->pos in readdir	2016-02-25 12:01:15 -08:00
delayed-ref.c	btrfs: qgroup: Fix a race in delayed_ref which leads to abort trans	2015-10-26 19:44:39 -07:00
delayed-ref.h	btrfs: qgroup: Fix a race in delayed_ref which leads to abort trans	2015-10-26 19:44:39 -07:00
dev-replace.c	Merge branch 'fix/waitqueue-barriers' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.4	2015-10-12 16:24:40 -07:00
dev-replace.h
dir-item.c
disk-io.c	btrfs: properly track when rescan worker is running	2016-09-07 08:32:43 +02:00
disk-io.h	Btrfs: add btrfs_read_dev_one_super() to read one specific SB	2015-10-01 17:29:38 +02:00
export.c	BTRFS: support NFSv2 export	2015-10-06 06:55:23 -07:00
export.h
extent-tree.c	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-07-27 09:47:33 -07:00
extent-tree.h
extent_io.c	block: add missing group association in bio-cloning functions	2016-08-20 18:09:24 +02:00
extent_io.h	btrfs: qgroup: Introduce btrfs_qgroup_reserve_data function	2015-10-21 18:37:45 -07:00
extent_map.c
extent_map.h
file-item.c
file.c	btrfs: Continue write in case of can_not_nocow	2016-09-15 08:27:47 +02:00
free-space-cache.c	Merge branch 'for-linus-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2015-12-18 15:35:08 -08:00
free-space-cache.h	Btrfs: keep track of largest extent in bitmaps	2015-10-21 18:55:40 -07:00
hash.c
hash.h
inode-item.c	Btrfs: consolidate btrfs_error() to btrfs_std_error()	2015-09-29 16:30:00 +02:00
inode-map.c	Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots	2016-03-03 15:07:12 -08:00
inode-map.h	Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots	2016-03-03 15:07:12 -08:00
inode.c	btrfs: qgroup: Prevent qgroup->reserved from going subzero	2016-11-18 10:48:37 +01:00
ioctl.c	btrfs: ensure that file descriptor used with subvol ioctls is a dir	2016-09-30 10:18:38 +02:00
Kconfig
locking.c	btrfs: comment the rest of implicit barriers before waitqueue_active	2015-10-10 18:42:00 +02:00
locking.h
lzo.c
Makefile
math.h
ordered-data.c	Btrfs: change how we wait for pending ordered extents	2015-10-21 18:51:40 -07:00
ordered-data.h	Btrfs: change how we wait for pending ordered extents	2015-10-21 18:51:40 -07:00
orphan.c
print-tree.c
print-tree.h
props.c	btrfs: cleanup iterating over prop_handlers array	2015-10-21 18:28:48 +02:00
props.h
qgroup.c	btrfs: properly track when rescan worker is running	2016-09-07 08:32:43 +02:00
qgroup.h	btrfs: waiting on qgroup rescan should not always be interruptible	2016-09-07 08:32:43 +02:00
raid56.c	btrfs: comment waitqueue_active implied by locks	2015-10-10 18:35:10 +02:00
raid56.h	Btrfs: add RAID 5/6 BTRFS_RBIO_REBUILD_MISSING operation	2015-08-09 07:34:26 -07:00
rcu-string.h
reada.c	btrfs: reada: Fix returned errno code	2015-10-21 18:29:50 +02:00
relocation.c	Btrfs: fix regression running delayed references when using qgroups	2015-10-25 19:53:26 +00:00
root-tree.c	Btrfs: fix loading of orphan roots leading to BUG_ON	2016-03-09 15:34:53 -08:00
scrub.c	Btrfs: fix scrub preventing unused block groups from being deleted	2015-11-25 05:22:08 -08:00
send.c	Btrfs: send, don't BUG_ON() when an empty symlink is found	2016-03-03 15:07:11 -08:00
send.h
struct-funcs.c
super.c	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-07-27 09:47:33 -07:00
sysfs.c	Btrfs: rename super_kobj to fsid_kobj	2015-09-29 16:29:59 +02:00
sysfs.h	Btrfs: rename btrfs_kobj_rm_device to btrfs_sysfs_rm_device_link	2015-09-29 16:29:59 +02:00
transaction.c	Btrfs: fix unprotected list move from unused_bgs to deleted_bgs list	2015-12-10 11:22:38 +00:00
transaction.h	btrfs: account for non-CoW'd blocks in btrfs_abort_transaction	2016-07-27 09:47:33 -07:00
tree-defrag.c	Btrfs: cleanup: remove unnecessary check before btrfs_free_path is called	2015-08-31 11:46:41 -07:00
tree-log.c	btrfs: fix races on root_log_ctx lists	2016-11-10 16:36:33 +01:00
tree-log.h
ulist.c
ulist.h
uuid-tree.c
volumes.c	btrfs: initialize the seq counter in struct btrfs_device	2016-03-03 15:07:12 -08:00
volumes.h	btrfs: fix clashing number of the enhanced balance usage filter	2015-11-25 05:19:50 -08:00
xattr.c	Btrfs: fix race when listing an inode's xattrs	2015-11-09 18:34:40 +00:00
xattr.h
zlib.c