Chris Wilson aec0f78596 e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails ... [ Upstream commit 833521ebc65b1c3092e5c0d8a97092f98eec595d ] An error during suspend (e100e_pm_suspend), [ 429.994338] ACPI : EC: event blocked [ 429.994633] e1000e: EEE TX LPI TIMER: 00000011 [ 430.955451] pci_pm_suspend(): e1000e_pm_suspend+0x0/0x30 [e1000e] returns -2 [ 430.955454] dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2 [ 430.955458] PM: Device 0000:00:19.0 failed to suspend async: error -2 [ 430.955581] PM: Some devices failed to suspend, or early wake event detected [ 430.957709] ACPI : EC: event unblocked lead to complete failure: [ 432.585002] ------------[ cut here ]------------ [ 432.585013] WARNING: CPU: 3 PID: 8372 at kernel/irq/manage.c:1478 __free_irq+0x9f/0x280 [ 432.585015] Trying to free already-free IRQ 20 [ 432.585016] Modules linked in: cdc_ncm usbnet x86_pkg_temp_thermal intel_powerclamp coretemp mii crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hwdep lpc_ich snd_hda_core snd_pcm mei_me mei sdhci_pci sdhci i915 mmc_core e1000e ptp pps_core prime_numbers [ 432.585042] CPU: 3 PID: 8372 Comm: kworker/u16:40 Tainted: G U 4.10.0-rc8-CI-Patchwork_3870+ #1 [ 432.585044] Hardware name: LENOVO 2356GCG/2356GCG, BIOS G7ET31WW (1.13 ) 07/02/2012 [ 432.585050] Workqueue: events_unbound async_run_entry_fn [ 432.585051] Call Trace: [ 432.585058] dump_stack+0x67/0x92 [ 432.585062] __warn+0xc6/0xe0 [ 432.585065] warn_slowpath_fmt+0x4a/0x50 [ 432.585070] ? _raw_spin_lock_irqsave+0x49/0x60 [ 432.585072] __free_irq+0x9f/0x280 [ 432.585075] free_irq+0x34/0x80 [ 432.585089] e1000_free_irq+0x65/0x70 [e1000e] [ 432.585098] e1000e_pm_freeze+0x7a/0xb0 [e1000e] [ 432.585106] e1000e_pm_suspend+0x21/0x30 [e1000e] [ 432.585113] pci_pm_suspend+0x71/0x140 [ 432.585118] dpm_run_callback+0x6f/0x330 [ 432.585122] ? pci_pm_freeze+0xe0/0xe0 [ 432.585125] __device_suspend+0xea/0x330 [ 432.585128] async_suspend+0x1a/0x90 [ 432.585132] async_run_entry_fn+0x34/0x160 [ 432.585137] process_one_work+0x1f4/0x6d0 [ 432.585140] ? process_one_work+0x16e/0x6d0 [ 432.585143] worker_thread+0x49/0x4a0 [ 432.585145] kthread+0x107/0x140 [ 432.585148] ? process_one_work+0x6d0/0x6d0 [ 432.585150] ? kthread_create_on_node+0x40/0x40 [ 432.585154] ret_from_fork+0x2e/0x40 [ 432.585156] ---[ end trace 6712df7f8c4b9124 ]--- The unwind failures stems from commit 2800209994 ("e1000e: Refactor PM flows"), but it may be a later patch that introduced the non-recoverable behaviour. Fixes: 2800209994 ("e1000e: Refactor PM flows") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-04-13 19:50:19 +02:00
..
accessibility
acpi	ACPI, PCI, irq: remove redundant check for null string pointer	2018-04-08 11:51:56 +02:00
amba
android	binder: add missing binder_unlock()	2018-02-28 10:17:23 +01:00
ata	ata: libahci: properly propagate return value of platform_get_irq()	2018-04-13 19:50:06 +02:00
atm	atm: horizon: Fix irq release error	2017-12-16 10:33:55 +01:00
auxdisplay
base	drivers: base: cacheinfo: fix boot error message when acpi is enabled	2018-01-31 12:06:08 +01:00
bcma	bcma: use (get|put)_device when probing/removing device driver	2017-03-12 06:37:30 +01:00
block	Revert "mtip32xx: use runtime tag to initialize command header"	2018-04-08 11:52:02 +02:00
bluetooth	Bluetooth: btusb: Fix quirk for Atheros 1525/QCA6174	2018-03-28 18:40:13 +02:00
bus	bus: brcmstb_gisb: correct support for 64-bit address output	2018-04-13 19:50:05 +02:00
cdrom
char	fix race in drivers/char/random.c:get_reg()	2018-04-13 19:50:11 +02:00
clk	clk: Fix __set_clk_rates error print-string	2018-04-13 19:50:16 +02:00
clocksource	clockevents/drivers/cs5535: Improve resilience to spurious interrupts	2017-10-27 10:23:17 +02:00
connector
cpufreq	Revert "cpufreq: Fix governor module removal race"	2018-04-08 11:52:02 +02:00
cpuidle	cpuidle: fix broadcast control when broadcast can not be entered	2017-12-25 14:22:15 +01:00
crypto	crypto: s5p-sss - Fix kernel Oops in AES-ECB mode	2018-02-25 11:03:55 +01:00
dca
devfreq	PM / devfreq: Propagate error from devfreq_add_device()	2018-02-22 15:44:58 +01:00
dio
dma	dmaengine: imx-sdma: Handle return value of clk_prepare_enable	2018-04-13 19:50:14 +02:00
dma-buf
edac	EDAC, octeon: Fix an uninitialized variable warning	2018-02-16 20:09:47 +01:00
eisa
extcon	extcon: palmas: Check the parent instance to prevent the NULL	2017-11-21 09:21:18 +01:00
firewire
firmware	efi/esrt: Cleanup bad memory map log messages	2017-12-20 10:04:56 +01:00
fmc
fpga
gpio	gpio: label descriptors using the device name	2018-04-13 19:50:14 +02:00
gpu	drm/omap: fix tiled buffer stride calculations	2018-04-13 19:50:16 +02:00
hid	HID: elo: clear BTN_LEFT mapping	2018-03-22 09:23:27 +01:00
hsi	HSI: ssi_protocol: double free in ssip_pn_xmit()	2018-03-24 10:58:42 +01:00
hv	Drivers: hv: vmbus: fix build warning	2018-02-25 11:03:46 +01:00
hwmon	hwmon: (ina2xx) Make calibration register value fixed	2018-04-13 19:50:13 +02:00
hwspinlock
hwtracing	coresight: Fix disabling of CoreSight TPIU	2018-03-24 10:58:48 +01:00
i2c	i2c: i2c-scmi: add a MS HID	2018-03-24 10:58:41 +01:00
ide
idle	idle: i7300: add PCI dependency	2018-02-25 11:03:51 +01:00
iio	iio: hi8435: cleanup reset gpio	2018-04-13 19:50:08 +02:00
infiniband	IB/srpt: Fix abort handling	2018-04-13 19:50:01 +02:00
input	Input: elan_i2c - clear INT before resetting controller	2018-04-13 19:50:11 +02:00
iommu	iommu/vt-d: clean up pr_irq if request_threaded_irq fails	2018-03-24 10:58:48 +01:00
ipack
irqchip	irqchip/gic-v3-its: Ensure nr_ites >= nr_lpis	2018-03-22 09:23:31 +01:00
isdn	mISDN: Fix a sleep-in-atomic bug	2018-04-13 19:50:16 +02:00
leds	leds: pca955x: Correct I2C Functionality	2018-04-13 19:50:09 +02:00
lguest
lightnvm
macintosh
mailbox	mailbox: handle empty message in tx_tick	2017-08-06 19:19:41 -07:00
mcb
md	md-cluster: fix potential lock issue in add_new_disk	2018-04-13 19:50:09 +02:00
media	mceusb: sporadic RX truncation corruption fix	2018-04-13 19:50:18 +02:00
memory	ARM: OMAP2+: gpmc-onenand: propagate error on initialization failure	2017-12-16 10:33:51 +01:00
memstick
message	mptfusion: hide unused seq_mpt_print_ioc_summary function	2018-02-25 11:03:45 +01:00
mfd	mfd: palmas: Reset the POWERHOLD mux during power off	2018-03-24 10:58:44 +01:00
misc	drivers/misc/vmw_vmci/vmci_queue_pair.c: fix a couple integer overflow tests	2018-04-13 19:50:02 +02:00
mmc	mmc: dw_mmc: fix falling from idmac to PIO mode when dw_mci_reset occurs	2018-03-28 18:40:13 +02:00
mtd	mtd: jedec_probe: Fix crash in jedec_read_mfr()	2018-04-08 11:51:55 +02:00
net	e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails	2018-04-13 19:50:19 +02:00
nfc	NFC: nfcmrvl: double free on error path	2018-03-22 09:23:23 +01:00
ntb	ntb_transport: fix bug calculating num_qps_mw	2017-08-30 10:19:29 +02:00
nubus
nvdimm	libnvdimm, namespace: make 'resource' attribute only readable by root	2017-11-30 08:37:23 +00:00
nvme	nvme: Fix managing degraded controllers	2018-02-16 20:09:47 +01:00
nvmem	nvmem: imx-ocotp: Fix wrong register size	2017-08-06 19:19:46 -07:00
of	of: fix of_device_get_modalias returned length when truncating buffers	2018-03-22 09:23:21 +01:00
oprofile
parisc	parisc: Hide Diva-built-in serial aux and graphics card	2018-01-02 20:33:20 +01:00
parport	parport_pc: Add support for WCH CH382L PCI-E single parallel port card.	2018-04-08 11:52:00 +02:00
pci	Revert "PCI/MSI: Stop disabling MSI/MSI-X in pci_device_shutdown()"	2018-04-08 11:52:01 +02:00
pcmcia
perf	drivers/perf: arm_pmu: handle no platform_device	2018-03-22 09:23:26 +01:00
phy	phy: work around 'phys' references to usb-nop-xceiv devices	2018-01-23 19:50:16 +01:00
pinctrl	pinctrl: Really force states during suspend/resume	2018-03-24 10:58:48 +01:00
platform	platform/chrome: Use proper protocol transfer function	2018-03-24 10:58:47 +01:00
pnp
power	power: supply: pda_power: move from timer to delayed_work	2018-03-24 10:58:45 +01:00
powercap	PowerCap: Fix an error code in powercap_register_zone()	2018-04-13 19:50:05 +02:00
pps
ps3
ptp	time: Change posix clocks ops interfaces to use timespec64	2018-03-24 10:58:40 +01:00
pwm	pwm: tegra: Increase precision in PWM rate calculation	2018-03-22 09:23:27 +01:00
rapidio
ras
regulator	regulator: anatop: set default voltage selector for pcie	2018-03-24 10:58:40 +01:00
remoteproc
reset
rpmsg
rtc	rtc: interface: Validate alarm-time before handling rollover	2018-04-13 19:50:15 +02:00
s390	s390/qeth: on channel error, reject further cmd requests	2018-03-31 18:12:34 +02:00
sbus
scsi	scsi: mpt3sas: Proper handling of set/clear of "ATA command pending" flag.	2018-04-13 19:50:13 +02:00
sfi
sh
sn
soc
spi	spi: davinci: fix up dma_mapping_error() incorrect patch	2018-04-08 11:52:02 +02:00
spmi	spmi: Include OF based modalias in device uevent	2017-07-27 15:06:10 -07:00
ssb	ssb: mark ssb_bus_register as __maybe_unused	2018-02-25 11:03:44 +01:00
staging	staging: wlan-ng: prism2mgmt.c: fixed a double endian conversion before calling hfa384x_drvr_setconfig16, also fixes relative sparse warning	2018-04-13 19:50:05 +02:00
target	tcm_fileio: Prevent information leak for short reads	2018-03-24 10:58:45 +01:00
tc
thermal	thermal: power_allocator: fix one race condition issue for thermal_instances list	2018-04-13 19:50:12 +02:00
thunderbolt
tty	Fix serial console on SNI RM400 machines	2018-04-13 19:50:17 +02:00
uio
usb	USB: ene_usb6250: fix SCSI residue overwriting	2018-04-13 19:50:07 +02:00
uwb	uwb: ensure that endpoint is interrupt	2017-10-12 11:27:35 +02:00
vfio	vfio-pci: Handle error from pci_iomap	2017-08-06 19:19:46 -07:00
vhost	vhost_net: stop device during reset owner	2018-02-16 20:09:38 +01:00
video	vfb: fix video mode and line_length being set when loaded	2018-04-13 19:50:13 +02:00
virt
virtio	virtio_balloon: prevent uninitialized variable use	2018-02-25 11:03:42 +01:00
vlynq
vme	vme: Fix wrong pointer utilization in ca91cx42_slave_get	2017-01-19 20:17:21 +01:00
w1	w1: ds2490: USB transfer buffers need to be DMAable	2017-03-12 06:37:29 +01:00
watchdog	watchdog: hpwdt: fix unused variable warning	2018-03-18 11:17:50 +01:00
xen	xen/gntdev: Fix partial gntdev_mmap() cleanup	2018-03-03 10:19:45 +01:00
zorro
Kconfig
Makefile	usb: build drivers/usb/common/ when USB_SUPPORT is set	2018-02-25 11:03:38 +01:00