Chuck Lever 1d13f37f6a nfsd: Close race between nfsd4_release_lockowner and nfsd4_lock ... commit 885848186fbc2d1d8fb6d2fdc2156638ae289a46 upstream. nfsd4_release_lockowner finds a lock owner that has no lock state, and drops cl_lock. Then release_lockowner picks up cl_lock and unhashes the lock owner. During the window where cl_lock is dropped, I don't see anything preventing a concurrent nfsd4_lock from finding that same lock owner and adding lock state to it. Move release_lockowner() into nfsd4_release_lockowner and hang onto the cl_lock until after the lock owner's state cannot be found again. Found by inspection, we don't currently have a reproducer. Fixes: 2c41beb0e5 ("nfsd: reduce cl_lock thrashing in ... ") Reviewed-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2016-09-24 10:07:36 +02:00
..
acl.h
auth.c
auth.h
blocklayout.c	nfsd/blocklayout: accept any minlength	2015-10-09 16:11:40 -04:00
blocklayoutxdr.c	pnfs: move common blocklayout XDR defintions to nfs4.h	2015-08-17 13:22:49 -05:00
blocklayoutxdr.h	pnfs: move common blocklayout XDR defintions to nfs4.h	2015-08-17 13:22:49 -05:00
cache.h	nfsd: Remove the cache_hash list	2014-08-17 12:00:12 -04:00
current_stateid.h
export.c	sunrpc/nfsd: Remove redundant code by exports seq_operations functions	2015-08-13 08:59:02 -04:00
export.h	nfsd: include linux/nfs4.h in export.h	2015-08-13 10:21:21 -04:00
fault_inject.c	nfsd: remove old fault injection infrastructure	2014-08-05 10:55:10 -04:00
idmap.h	nfsd: Remove duplicate define of IDMAP_NAMESZ/IDMAP_TYPE_xx	2015-07-20 14:58:46 -04:00
Kconfig	Merge branch 'for-4.1' of git://linux-nfs.org/~bfields/linux	2015-04-24 07:46:05 -07:00
lockd.c
Makefile	nfsd: pNFS block layout driver	2015-02-05 14:35:18 +01:00
netns.h	nfsd: New counter for generating client confirm verifier	2015-08-10 16:05:47 -04:00
nfs2acl.c	nfsd: check permissions when setting ACLs	2016-07-27 09:47:30 -07:00
nfs3acl.c	nfsd: check permissions when setting ACLs	2016-07-27 09:47:30 -07:00
nfs3proc.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
nfs3xdr.c	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
nfs4acl.c	nfsd: check permissions when setting ACLs	2016-07-27 09:47:30 -07:00
nfs4callback.c	nfsd4/rpc: move backchannel create logic into rpc code	2016-07-27 09:47:30 -07:00
nfs4idmap.c	nfsd: Remove duplicate define of IDMAP_NAMESZ/IDMAP_TYPE_xx	2015-07-20 14:58:46 -04:00
nfs4layouts.c	nfsd: don't hold ls_mutex across a layout recall	2015-12-16 11:49:58 -05:00
nfs4proc.c	nfsd: fix deadlock secinfo+readdir compound	2016-04-12 09:09:03 -07:00
nfs4recover.c	nfsd: don't WARN/backtrace for invalid container deployment.	2015-08-31 16:32:08 -04:00
nfs4state.c	nfsd: Close race between nfsd4_release_lockowner and nfsd4_lock	2016-09-24 10:07:36 +02:00
nfs4xdr.c	nfsd4: fix bad bounds checking	2016-04-12 09:09:03 -07:00
nfscache.c	nfsd: remove recurring workqueue job to clean DRC	2015-11-10 09:25:51 -05:00
nfsctl.c	nfsd: fix nsfd startup race triggering BUG_ON	2015-04-21 16:16:03 -04:00
nfsd.h	nfsd: eliminate NFSD_DEBUG	2015-04-21 16:16:02 -04:00
nfsfh.c	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
nfsfh.h	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
nfsproc.c	nfsd: Disable NFSv2 timestamp workaround for NFSv3+	2015-05-29 11:04:01 -04:00
nfssvc.c	nfsd/sunrpc: abstract out svc_set_num_threads to sv_ops	2015-08-10 16:05:43 -04:00
nfsxdr.c	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
pnfs.h	nfsd4: fix v3-less build	2015-02-16 11:43:13 -05:00
state.h	nfsd: Always lock state exclusively.	2016-07-27 09:47:30 -07:00
stats.c
stats.h
trace.c	nfsd: move include of state.h from trace.c to trace.h	2015-10-23 15:57:29 -04:00
trace.h	nfsd: move include of state.h from trace.c to trace.h	2015-10-23 15:57:29 -04:00
vfs.c	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
vfs.h	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
xdr.h
xdr3.h
xdr4.h	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
xdr4cb.h	nfsd: implement pNFS layout recalls	2015-02-02 18:09:43 +01:00