Darrick J. Wong 6d43e485e0 xfs: clear _XBF_PAGES from buffers when readahead page ... commit 2aa6ba7b5ad3189cc27f14540aa2f57f0ed8df4b upstream. If we try to allocate memory pages to back an xfs_buf that we're trying to read, it's possible that we'll be so short on memory that the page allocation fails. For a blocking read we'll just wait, but for readahead we simply dump all the pages we've collected so far. Unfortunately, after dumping the pages we neglect to clear the _XBF_PAGES state, which means that the subsequent call to xfs_buf_free thinks that b_pages still points to pages we own. It then double-frees the b_pages pages. This results in screaming about negative page refcounts from the memory manager, which xfs oughtn't be triggering. To reproduce this case, mount a filesystem where the size of the inodes far outweighs the availalble memory (a ~500M inode filesystem on a VM with 300MB memory did the trick here) and run bulkstat in parallel with other memory eating processes to put a huge load on the system. The "check summary" phase of xfs_scrub also works for this purpose. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Eric Sandeen <sandeen@redhat.com> Cc: Ivan Kozik <ivan@ludios.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2017-03-30 09:35:19 +02:00
..
libxfs	xfs: don't allow di_size with high bit set	2017-03-30 09:35:18 +02:00
Kconfig
kmem.c	xfs: more info from kmem deadlocks and high-level error msgs	2015-10-12 16:04:45 +11:00
kmem.h
Makefile	xfs: stats are no longer dependent on CONFIG_PROC_FS	2015-10-19 08:42:46 +11:00
mrlock.h
uuid.c
uuid.h
xfs.h
xfs_acl.c	posix_acl: Clear SGID bit when setting file permissions	2016-10-31 04:13:58 -06:00
xfs_acl.h	xfs: Fix error path in xfs_get_acl	2015-11-10 10:09:45 +11:00
xfs_aops.c	Merge branch 'xfs-dax-updates' into for-next	2015-11-03 13:28:41 +11:00
xfs_aops.h	xfs: DAX does not use IO completion callbacks	2015-11-03 12:37:02 +11:00
xfs_attr.h
xfs_attr_inactive.c	Merge branch 'xfs-misc-fixes-for-4.2-3' into for-next	2015-06-23 08:49:01 +10:00
xfs_attr_list.c	xfs: fix two memory leaks in xfs_attr_list.c error paths	2016-04-12 09:08:56 -07:00
xfs_bmap_util.c	xfs: fix up xfs_swap_extent_forks inline extent handling	2017-03-30 09:35:18 +02:00
xfs_bmap_util.h
xfs_buf.c	xfs: clear _XBF_PAGES from buffers when readahead page	2017-03-30 09:35:19 +02:00
xfs_buf.h	xfs: print name of verifier if it fails	2016-06-07 18:14:38 -07:00
xfs_buf_item.c	Merge branch 'xfs-misc-fixes-for-4.3-3' into for-next	2015-08-25 10:13:35 +10:00
xfs_buf_item.h	xfs: fix non-debug build warnings	2015-08-25 10:05:13 +10:00
xfs_dir2_readdir.c	xfs: per-filesystem stats counter implementation	2015-10-12 18:21:22 +11:00
xfs_discard.c
xfs_discard.h
xfs_dquot.c	xfs: per-filesystem stats counter implementation	2015-10-12 18:21:22 +11:00
xfs_dquot.h
xfs_dquot_item.c
xfs_dquot_item.h
xfs_error.c	xfs: print name of verifier if it fails	2016-06-07 18:14:38 -07:00
xfs_error.h	xfs: remove inst_t	2015-06-22 09:44:02 +10:00
xfs_export.c
xfs_export.h
xfs_extent_busy.c
xfs_extent_busy.h
xfs_extfree_item.c	xfs: add helper to conditionally remove items from the AIL	2015-08-19 10:01:08 +10:00
xfs_extfree_item.h	xfs: fix efi/efd error handling to avoid fs shutdown hangs	2015-08-19 09:51:16 +10:00
xfs_file.c	xfs: updates for 4.4-rc1	2015-11-11 20:18:48 -08:00
xfs_filestream.c	xfs: clean up XFS_MIN_FREELIST macros	2015-06-22 10:13:30 +10:00
xfs_filestream.h
xfs_fsops.c	xfs: Don't wrap growfs AGFL indexes	2016-06-07 18:14:38 -07:00
xfs_fsops.h
xfs_globals.c
xfs_icache.c	xfs: per-filesystem stats counter implementation	2015-10-12 18:21:22 +11:00
xfs_icache.h
xfs_icreate_item.c
xfs_icreate_item.h
xfs_inode.c	xfs: skip stale inodes in xfs_iflush_cluster	2016-06-07 18:14:38 -07:00
xfs_inode.h	xfs: clean up inode lockdep annotations	2015-08-19 10:32:49 +10:00
xfs_inode_item.c	xfs: optimise away log forces on timestamp updates for fdatasync	2015-11-03 13:14:59 +11:00
xfs_inode_item.h	xfs: optimise away log forces on timestamp updates for fdatasync	2015-11-03 13:14:59 +11:00
xfs_ioctl.c	Merge branch 'xfs-misc-fixes-for-4.4-2' into for-next	2015-11-03 13:27:58 +11:00
xfs_ioctl.h
xfs_ioctl32.c	xfs: prefix XATTR_LIST_MAX with XFS_	2015-10-12 16:02:56 +11:00
xfs_ioctl32.h
xfs_iomap.c	Merge branch 'xfs-dax-updates' into for-next	2015-11-03 13:28:41 +11:00
xfs_iomap.h
xfs_iops.c	xfs: per-filesystem stats counter implementation	2015-10-12 18:21:22 +11:00
xfs_iops.h
xfs_itable.c	xfs: fix btree cursor error cleanups	2015-08-19 10:00:53 +10:00
xfs_itable.h
xfs_linux.h	xfs: pass xfsstats structures to handlers and macros	2015-10-12 05:19:45 +11:00
xfs_log.c	Merge branch 'xfs-logging-fixes' into for-next	2015-10-12 18:37:58 +11:00
xfs_log.h	xfs: validate metadata LSNs against log on v5 superblocks	2015-10-12 15:59:25 +11:00
xfs_log_cil.c	xfs: close xc_cil list_empty() races with cil commit sequence	2015-07-29 11:51:01 +10:00
xfs_log_priv.h	xfs: validate metadata LSNs against log on v5 superblocks	2015-10-12 15:59:25 +11:00
xfs_log_recover.c	xfs: set AGI buffer type in xlog_recover_clear_agi_bucket	2017-01-06 11:16:17 +01:00
xfs_message.c	xfs: more info from kmem deadlocks and high-level error msgs	2015-10-12 16:04:45 +11:00
xfs_message.h
xfs_mount.c	Merge branch 'xfs-misc-fixes-for-4.4-2' into for-next	2015-11-03 13:27:58 +11:00
xfs_mount.h	Merge branch 'xfs-dax-updates' into for-next	2015-11-03 13:28:41 +11:00
xfs_mru_cache.c
xfs_mru_cache.h
xfs_pnfs.c	xfs: add missing ilock around dio write last extent alignment	2015-10-12 15:34:20 +11:00
xfs_pnfs.h
xfs_qm.c	xfs: updates for 4.4-rc1	2015-11-11 20:18:48 -08:00
xfs_qm.h
xfs_qm_bhv.c
xfs_qm_syscalls.c	xfs: saner xfs_trans_commit interface	2015-06-04 13:48:08 +10:00
xfs_quota.h	xfs: fix quota block reservation leak when tp allocates and frees blocks	2015-06-01 07:15:37 +10:00
xfs_quotaops.c
xfs_rtalloc.c	xfs: add missing bmap cancel calls in error paths	2015-08-19 10:01:40 +10:00
xfs_rtalloc.h
xfs_stats.c	xfs: stats are no longer dependent on CONFIG_PROC_FS	2015-10-19 08:42:46 +11:00
xfs_stats.h	xfs: per-filesystem stats counter implementation	2015-10-12 18:21:22 +11:00
xfs_super.c	xfs: disallow rw remount on fs with unknown ro-compat features	2016-06-07 18:14:38 -07:00
xfs_super.h
xfs_symlink.c	Merge branch 'xfs-misc-fixes-for-4.3-2' into for-next	2015-08-20 09:28:45 +10:00
xfs_symlink.h
xfs_sysctl.c	xfs: pass xfsstats structures to handlers and macros	2015-10-12 05:19:45 +11:00
xfs_sysctl.h
xfs_sysfs.c	xfs: pass xfsstats structures to handlers and macros	2015-10-12 05:19:45 +11:00
xfs_sysfs.h	xfs: create global stats and stats_clear in sysfs	2015-10-12 05:15:45 +11:00
xfs_trace.c
xfs_trace.h	Merge branch 'xfs-dax-updates' into for-next	2015-11-03 13:28:41 +11:00
xfs_trans.c	xfs: per-filesystem stats counter implementation	2015-10-12 18:21:22 +11:00
xfs_trans.h	xfs: ensure EFD trans aborts on log recovery extent free failure	2015-08-19 09:51:43 +10:00
xfs_trans_ail.c	Revert "xfs: clear PF_NOFREEZE for xfsaild kthread"	2016-02-25 12:01:24 -08:00
xfs_trans_buf.c
xfs_trans_dquot.c	xfs: Clean up xfs_trans_dup_dqinfo	2015-06-01 10:50:00 +10:00
xfs_trans_extfree.c	xfs: ensure EFD trans aborts on log recovery extent free failure	2015-08-19 09:51:43 +10:00
xfs_trans_inode.c	xfs: optimise away log forces on timestamp updates for fdatasync	2015-11-03 13:14:59 +11:00
xfs_trans_priv.h	xfs: add helper to conditionally remove items from the AIL	2015-08-19 10:01:08 +10:00
xfs_xattr.c	Merge branch 'for-linus-3' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-11-13 18:02:30 -08:00