Imre Deak bcdb72ac7c drm/i915: fix pch pci device enumeration ... pci_get_class(class, from) drops the refcount for 'from', so the extra pci_dev_put we do on it will result in a use after free bug starting with the WARN below. Regression introduced in commit 6a9c4b35e6 Author: Rui Guo <firemeteor@users.sourceforge.net> Date: Wed Jun 19 21:10:23 2013 +0800 drm/i915: Fix PCH detect with multiple ISA bridges in VM [ 164.338460] WARNING: CPU: 1 PID: 2094 at include/linux/kref.h:47 klist_next+0xae/0x110() [ 164.347731] CPU: 1 PID: 2094 Comm: modprobe Tainted: G O 3.13.0-imre+ #354 [ 164.356468] Hardware name: Intel Corp. VALLEYVIEW B0 PLATFORM/NOTEBOOK, BIOS BYTICRB1.X64.0062.R70.1310112051 10/11/2013 [ 164.368796] Call Trace: [ 164.371609] [<ffffffff816a32a6>] dump_stack+0x4e/0x7a [ 164.377447] [<ffffffff8104f75d>] warn_slowpath_common+0x7d/0xa0 [ 164.384238] [<ffffffff8104f83a>] warn_slowpath_null+0x1a/0x20 [ 164.390851] [<ffffffff8169aeae>] klist_next+0xae/0x110 [ 164.396777] [<ffffffff8130a110>] ? pci_do_find_bus+0x70/0x70 [ 164.403286] [<ffffffff813cb4a9>] bus_find_device+0x89/0xc0 [ 164.409719] [<ffffffff8130a373>] pci_get_dev_by_id+0x63/0xa0 [ 164.416238] [<ffffffff8130a4e4>] pci_get_class+0x44/0x50 [ 164.422433] [<ffffffffa034821f>] intel_dsm_detect+0x16f/0x1f0 [i915] [ 164.429801] [<ffffffffa03482ae>] intel_register_dsm_handler+0xe/0x10 [i915] [ 164.437831] [<ffffffffa02d30fe>] i915_driver_load+0xafe/0xf30 [i915] [ 164.445126] [<ffffffff8158a150>] ? intel_alloc_coherent+0x110/0x110 [ 164.452340] [<ffffffffa0148c07>] drm_dev_register+0xc7/0x150 [drm] [ 164.459462] [<ffffffffa014b23f>] drm_get_pci_dev+0x11f/0x1f0 [drm] [ 164.466554] [<ffffffff816abb81>] ? _raw_spin_unlock_irqrestore+0x51/0x70 [ 164.474287] [<ffffffffa02cf7a6>] i915_pci_probe+0x56/0x60 [i915] [ 164.481185] [<ffffffff8130a028>] pci_device_probe+0x78/0xf0 [ 164.487603] [<ffffffff813cd495>] driver_probe_device+0x155/0x350 [ 164.494505] [<ffffffff813cd74e>] __driver_attach+0x6e/0xa0 [ 164.500826] [<ffffffff813cd6e0>] ? __device_attach+0x50/0x50 [ 164.507333] [<ffffffff813cb2be>] bus_for_each_dev+0x6e/0xc0 [ 164.513752] [<ffffffff813ccefe>] driver_attach+0x1e/0x20 [ 164.519870] [<ffffffff813cc958>] bus_add_driver+0x138/0x260 [ 164.526289] [<ffffffffa0188000>] ? 0xffffffffa0187fff [ 164.532116] [<ffffffff813cde78>] driver_register+0x98/0xe0 [ 164.538558] [<ffffffffa0188000>] ? 0xffffffffa0187fff [ 164.544389] [<ffffffff813087b0>] __pci_register_driver+0x60/0x70 [ 164.551336] [<ffffffffa014b37d>] drm_pci_init+0x6d/0x120 [drm] [ 164.558040] [<ffffffffa0188000>] ? 0xffffffffa0187fff [ 164.563928] [<ffffffffa018806a>] i915_init+0x6a/0x6c [i915] [ 164.570363] [<ffffffff810002da>] do_one_initcall+0xaa/0x160 [ 164.576783] [<ffffffff8103b140>] ? set_memory_nx+0x40/0x50 [ 164.583100] [<ffffffff810ce7f5>] load_module+0x1fb5/0x2550 [ 164.589410] [<ffffffff810caab0>] ? store_uevent+0x40/0x40 [ 164.595628] [<ffffffff810cee7d>] SyS_init_module+0xed/0x100 [ 164.602048] [<ffffffff816b3c52>] system_call_fastpath+0x16/0x1b v2: simplify the loop further (Chris) Signed-off-by: Imre Deak <imre.deak@intel.com> Cc: Jesse Barnes <jbarnes@virtuousgeek.org> Reported-by: Jesse Barnes <jbarnes@virtuousgeek.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=65652 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74161 Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: stable@vger.kernel.org Signed-off-by: Jani Nikula <jani.nikula@intel.com>		2014-03-03 11:51:16 +02:00
..
dvo.h
dvo_ch7xxx.c
dvo_ch7017.c
dvo_ivch.c
dvo_ns2501.c	drm/i915/ns2501: Rip out the reenable hack	2013-11-04 16:32:31 +01:00
dvo_sil164.c
dvo_tfp410.c
i915_debugfs.c	drm/i915/vlv: Add drpc debugfs support for valleyview	2014-01-10 18:00:14 +01:00
i915_dma.c	i915: remove pm_qos request on error	2014-01-25 12:52:48 +01:00
i915_drv.c	drm/i915: fix pch pci device enumeration	2014-03-03 11:51:16 +02:00
i915_drv.h	Merge tag 'drm-intel-fixes-2014-02-11' of ssh://git.freedesktop.org/git/drm-intel into drm-next	2014-02-12 09:51:16 +10:00
i915_gem.c	drm/i915: Wait for completion of pending flips when starved of fences	2014-01-22 10:34:40 +01:00
i915_gem_context.c	Merge commit origin/master into drm-intel-next	2014-01-16 22:06:30 +01:00
i915_gem_debug.c
i915_gem_dmabuf.c	drm/i915: Pin pages whilst allocating for dma-buf vmap()	2013-11-29 15:51:20 +01:00
i915_gem_evict.c	drm/i915: Repeat evictions whilst pageflip completions are outstanding	2014-01-22 10:34:41 +01:00
i915_gem_execbuffer.c	drm/i915: Clarify relocation errnos	2014-01-22 09:58:25 +01:00
i915_gem_gtt.c	Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux	2014-01-29 20:49:12 -08:00
i915_gem_stolen.c	drm/i915: Resolving the memory region conflict for Stolen area	2014-03-03 11:51:15 +02:00
i915_gem_tiling.c
i915_gpu_error.c	drm/i915: Pair va_copy with va_end in i915_error_vprintf	2014-02-11 11:53:15 +01:00
i915_ioc32.c
i915_irq.c	drm/i915: Fix intel_pipe_to_cpu_transcoder for UMS	2014-02-11 11:53:09 +01:00
i915_reg.h	Revert "drm/i915: Mask reserved bits in display/sprite address registers"	2014-01-24 17:22:00 +01:00
i915_suspend.c	drm/i915: Drop I915_ prefix from HAS_FBC	2014-01-10 10:28:28 +01:00
i915_sysfs.c	drm/i915: add some runtime PM get/put calls	2013-12-10 22:50:17 +01:00
i915_trace.h
i915_trace_points.c
i915_ums.c	drm/i915: do not save/restore backlight registers in KMS	2013-11-14 12:22:32 +01:00
intel_acpi.c	Merge branch 'acpi-dsm'	2014-01-12 23:45:52 +01:00
intel_bios.c	drm/i915: parse backlight modulation frequency from the BIOS VBT	2013-12-16 10:02:48 +01:00
intel_bios.h	drm/i915: parse backlight modulation frequency from the BIOS VBT	2013-12-16 10:02:48 +01:00
intel_crt.c	drm/i915: Return a drm_mode_status enum in the mode_valid vfuncs	2013-11-28 16:49:33 +01:00
intel_ddi.c	Merge branch 'drm-intel-next' of git://people.freedesktop.org/~danvet/drm-intel into drm-next	2014-01-20 10:21:54 +10:00
intel_display.c	Merge tag 'drm-intel-fixes-2014-02-14' of ssh://git.freedesktop.org/git/drm-intel into drm-fixes	2014-02-18 16:21:49 +10:00
intel_dp.c	drm/i915/dp: add native aux defer retry limit	2014-02-13 16:12:42 +01:00
intel_drv.h	drm/i915: Wait for completion of pending flips when starved of fences	2014-01-22 10:34:40 +01:00
intel_dsi.c	drm/i915: Parametrize the dphy and other spec specific parameters	2013-12-11 23:52:20 +01:00
intel_dsi.h	drm/i915: Parametrize the dphy and other spec specific parameters	2013-12-11 23:52:20 +01:00
intel_dsi_cmd.c
intel_dsi_cmd.h
intel_dsi_pll.c	drm/i915: Try harder to get best m, n, p values with minimal error	2013-12-11 23:52:18 +01:00
intel_dvo.c	drm/i915: Return a drm_mode_status enum in the mode_valid vfuncs	2013-11-28 16:49:33 +01:00
intel_fbdev.c	drm/i915: remove duplicate MODULE_LICENSE definition	2014-01-07 10:20:47 +01:00
intel_hdmi.c	drm/i915: Don't cast away const from infoframe buffer	2013-12-10 14:49:04 +01:00
intel_i2c.c	drm/i915: Disable dp aux irq on g4x	2014-02-07 16:40:07 +01:00
intel_lvds.c	drm/i915: Make downclock deduction common for all panels	2013-12-10 13:26:15 +01:00
intel_modes.c
intel_opregion.c	Merge tag 'drm-intel-fixes-2014-02-06' of ssh://git.freedesktop.org/git/drm-intel into drm-next	2014-02-11 12:57:27 +10:00
intel_overlay.c	drm/i915: No panel fitter on 830M or non-mobile gen2/3 platforms	2014-01-10 18:03:17 +01:00
intel_panel.c	drm/i915: use backlight legacy combination mode also for i915gm/i945gm	2014-03-03 11:51:15 +02:00
intel_pm.c	Merge commit origin/master into drm-intel-next	2014-01-16 22:06:30 +01:00
intel_ringbuffer.c	drm/i915: Add intel_ring_cachline_align()	2014-02-11 23:00:19 +01:00
intel_ringbuffer.h	drm/i915: Add intel_ring_cachline_align()	2014-02-11 23:00:19 +01:00
intel_sdvo.c	drm/i915: Don't cast away const from infoframe buffer	2013-12-10 14:49:04 +01:00
intel_sdvo_regs.h	drm/i915: use __packed instead of __attribute__((packed))	2013-12-03 18:19:49 +01:00
intel_sideband.c	drm/i915: Use FLISDSI interface for band gap reset	2013-12-11 23:52:17 +01:00
intel_sprite.c	Revert "drm/i915: Mask reserved bits in display/sprite address registers"	2014-01-24 17:22:00 +01:00
intel_tv.c	drm/i915/tv: add ->get_config callback	2013-11-18 22:24:33 +01:00
intel_uncore.c	drm/i915: Allow reading the TIMESTAMP register on Gen8.	2014-01-22 10:48:09 +01:00
Kconfig	i915, fbdev: Fix Kconfig typo	2013-11-21 21:59:02 +01:00
Makefile	Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux	2014-01-29 20:49:12 -08:00