Eric Dumazet c696a3abda ip_tunnel: better validate user provided tunnel names ... [ Upstream commit 9cb726a212a82c88c98aa9f0037fd04777cd8fe5 ] Use dev_valid_name() to make sure user does not provide illegal device name. syzbot caught the following bug : BUG: KASAN: stack-out-of-bounds in strlcpy include/linux/string.h:300 [inline] BUG: KASAN: stack-out-of-bounds in __ip_tunnel_create+0xca/0x6b0 net/ipv4/ip_tunnel.c:257 Write of size 20 at addr ffff8801ac79f810 by task syzkaller268107/4482 CPU: 0 PID: 4482 Comm: syzkaller268107 Not tainted 4.16.0+ #1 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b9/0x29f lib/dump_stack.c:53 print_address_description+0x6c/0x20b mm/kasan/report.c:256 kasan_report_error mm/kasan/report.c:354 [inline] kasan_report.cold.7+0xac/0x2f5 mm/kasan/report.c:412 check_memory_region_inline mm/kasan/kasan.c:260 [inline] check_memory_region+0x13e/0x1b0 mm/kasan/kasan.c:267 memcpy+0x37/0x50 mm/kasan/kasan.c:303 strlcpy include/linux/string.h:300 [inline] __ip_tunnel_create+0xca/0x6b0 net/ipv4/ip_tunnel.c:257 ip_tunnel_create net/ipv4/ip_tunnel.c:352 [inline] ip_tunnel_ioctl+0x818/0xd40 net/ipv4/ip_tunnel.c:861 ipip_tunnel_ioctl+0x1c5/0x420 net/ipv4/ipip.c:350 dev_ifsioc+0x43e/0xb90 net/core/dev_ioctl.c:334 dev_ioctl+0x69a/0xcc0 net/core/dev_ioctl.c:525 sock_ioctl+0x47e/0x680 net/socket.c:1015 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:500 [inline] do_vfs_ioctl+0x1cf/0x1650 fs/ioctl.c:684 ksys_ioctl+0xa9/0xd0 fs/ioctl.c:701 SYSC_ioctl fs/ioctl.c:708 [inline] SyS_ioctl+0x24/0x30 fs/ioctl.c:706 do_syscall_64+0x29e/0x9d0 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x42/0xb7 Fixes: c544193214 ("GRE: Refactor GRE tunneling code.") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-04-13 19:50:26 +02:00
..
6lowpan	6lowpan: put mcast compression in an own function	2015-10-21 00:49:25 +02:00
9p	net/9p: Switch to wait_event_killable()	2017-11-30 08:37:25 +00:00
802
8021q	vlan: also check phy_driver ts_info for vlan's real device	2018-04-13 19:50:25 +02:00
appletalk
atm	atm: deal with setting entry before mkip was called	2015-09-17 22:13:32 -07:00
ax25	ax25: Fix segfault after sock connection timeout	2017-02-04 09:45:09 +01:00
batman-adv	batman-adv: handle race condition for claims between gateways	2018-03-22 09:23:21 +01:00
bluetooth	Bluetooth: Send HCI Set Event Mask Page 2 command only when needed	2018-04-13 19:50:21 +02:00
bridge	netfilter: bridge: ebt_among: add more missing match size checks	2018-04-08 11:51:59 +02:00
caif	net: caif: Fix a sleep-in-atomic bug in cfpkt_create_pfx	2017-07-05 14:37:14 +02:00
can	can: af_can: canfd_rcv(): replace WARN_ONCE by pr_warn_once	2018-01-31 12:06:08 +01:00
ceph	libceph: NULL deref on crush_decode() error path	2018-04-13 19:50:10 +02:00
core	net: fool proof dev_valid_name()	2018-04-13 19:50:26 +02:00
dcb	net/dcb: make dcbnl.c explicitly non-modular	2015-10-09 07:52:27 -07:00
dccp	dccp: check sk for closed state in dccp_sendmsg()	2018-03-31 18:12:33 +02:00
decnet	dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock	2018-02-25 11:03:38 +01:00
dns_resolver	KEYS: Fix race between updating and finding a negative key	2017-10-27 10:23:18 +02:00
dsa	net: dsa: select NET_SWITCHDEV	2017-11-15 17:13:11 +01:00
ethernet	net: introduce device min_header_len	2017-02-18 16:39:27 +01:00
hsr	net/hsr: fix a warning message	2015-11-23 14:56:15 -05:00
ieee802154	net: ieee802154: fix net_device reference release too early	2018-04-13 19:50:10 +02:00
ipv4	ip_tunnel: better validate user provided tunnel names	2018-04-13 19:50:26 +02:00
ipv6	net/ipv6: Fix route leaking between VRFs	2018-04-13 19:50:24 +02:00
ipx	ipx: call ipxitf_put() in ioctl error path	2017-05-25 14:30:13 +02:00
irda	irda: do not leak initialized list.dev to userspace	2017-08-30 10:19:21 +02:00
iucv	net/iucv: Free memory obtained by kzalloc	2018-03-31 18:12:33 +02:00
key	af_key: Fix slab-out-of-bounds in pfkey_compile_policy.	2018-04-13 19:50:01 +02:00
l2tp	l2tp: fix missing print session offset info	2018-04-13 19:50:12 +02:00
l3mdev	net: Add netif_is_l3_slave	2015-10-07 04:27:43 -07:00
lapb
llc	net: llc: add lock_sock in llc_ui_bind to avoid a race condition	2018-04-13 19:50:12 +02:00
mac80211	mac80211: bail out from prep_connection() if a reconfig is ongoing	2018-04-13 19:50:01 +02:00
mac802154	mac802154: llsec: use kzfree	2015-10-21 00:49:24 +02:00
mpls	mpls, nospec: Sanitize array index in mpls_label_ok()	2018-03-11 16:19:47 +01:00
netfilter	netfilter: ctnetlink: fix incorrect nf_ct_put during hash resize	2018-04-13 19:50:10 +02:00
netlabel	netlabel: add address family checks to netlbl_{sock,req}_delattr()	2016-08-20 18:09:22 +02:00
netlink	netlink: make sure nladdr has correct size in netlink_connect()	2018-04-13 19:50:24 +02:00
netrom
nfc	NFC: fix device-allocation error return	2017-11-30 08:37:23 +00:00
openvswitch	openvswitch: Delete conntrack entry clashing with an expectation.	2018-03-24 10:58:43 +01:00
packet	net/packet: fix a race in packet_bind() and packet_notifier()	2017-12-16 10:33:56 +01:00
phonet	phonet: properly unshare skbs in phonet_rcv()	2016-01-31 11:29:00 -08:00
rds	rds; Reset rs->rs_bound_addr in rds_add_bound() failure path	2018-04-13 19:50:13 +02:00
rfkill	rfkill: fix rfkill_fop_read wait_event usage	2016-03-03 15:07:26 -08:00
rose
rxrpc	rxrpc: check return value of skb_to_sgvec always	2018-04-13 19:50:23 +02:00
sched	net/sched: fix NULL dereference in the error path of tcf_bpf_init()	2018-04-13 19:50:25 +02:00
sctp	sctp: sctp_sockaddr_af must check minimal addr length for AF_INET6	2018-04-13 19:50:25 +02:00
sunrpc	SUNRPC: ensure correct error is reported by xs_tcp_setup_socket()	2018-04-13 19:50:15 +02:00
switchdev	switchdev: pass pointer to fib_info instead of copy	2016-06-24 10:18:16 -07:00
tipc	tipc: fix memory leak in tipc_accept_from_sock()	2017-12-16 10:33:56 +01:00
unix	net/unix: don't show information about sockets from other namespaces	2017-11-18 11:11:06 +01:00
vmw_vsock	vsock: use new wait API for vsock_stream_sendmsg()	2017-11-30 08:37:19 +00:00
wimax	net:wimax: Fix doucble word "the the" in networking.xml	2015-08-09 22:43:52 -07:00
wireless	nl80211: Sanitize array index in parse_txq_params	2018-02-25 11:03:53 +01:00
x25	net: x25: fix one potential use-after-free issue	2018-04-13 19:50:07 +02:00
xfrm	xfrm: fix state migration copy replay sequence numbers	2018-04-13 19:50:08 +02:00
compat.c	audit: log 32-bit socketcalls	2017-10-08 10:14:18 +02:00
Kconfig	Make DST_CACHE a silent config option	2018-02-25 11:03:37 +01:00
Makefile	net: Introduce L3 Master device abstraction	2015-09-29 20:40:32 -07:00
socket.c	bpf: introduce BPF_JIT_ALWAYS_ON config	2018-02-03 17:04:24 +01:00
sysctl_net.c	net: Use ns_capable_noaudit() when determining net sysctl permissions	2016-09-15 08:27:50 +02:00