Dave Chinner 16925957b8 fs: don't scan the inode cache before SB_BORN is set ... commit 79f546a696bff2590169fb5684e23d65f4d9f591 upstream. We recently had an oops reported on a 4.14 kernel in xfs_reclaim_inodes_count() where sb->s_fs_info pointed to garbage and so the m_perag_tree lookup walked into lala land. It produces an oops down this path during the failed mount: radix_tree_gang_lookup_tag+0xc4/0x130 xfs_perag_get_tag+0x37/0xf0 xfs_reclaim_inodes_count+0x32/0x40 xfs_fs_nr_cached_objects+0x11/0x20 super_cache_count+0x35/0xc0 shrink_slab.part.66+0xb1/0x370 shrink_node+0x7e/0x1a0 try_to_free_pages+0x199/0x470 __alloc_pages_slowpath+0x3a1/0xd20 __alloc_pages_nodemask+0x1c3/0x200 cache_grow_begin+0x20b/0x2e0 fallback_alloc+0x160/0x200 kmem_cache_alloc+0x111/0x4e0 The problem is that the superblock shrinker is running before the filesystem structures it depends on have been fully set up. i.e. the shrinker is registered in sget(), before ->fill_super() has been called, and the shrinker can call into the filesystem before fill_super() does it's setup work. Essentially we are exposed to both use-after-free and use-before-initialisation bugs here. To fix this, add a check for the SB_BORN flag in super_cache_count. In general, this flag is not set until ->fs_mount() completes successfully, so we know that it is set after the filesystem setup has completed. This matches the trylock_super() behaviour which will not let super_cache_scan() run if SB_BORN is not set, and hence will not allow the superblock shrinker from entering the filesystem while it is being set up or after it has failed setup and is being torn down. Cc: stable@kernel.org Signed-Off-By: Dave Chinner <dchinner@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Aaron Lu <aaron.lu@linux.alibaba.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-02-06 19:43:08 +01:00
..
9p	v9fs_dir_readdir: fix double-free on p9stat_read error	2018-12-01 09:46:33 +01:00
adfs
affs	affs_lookup(): close a race with affs_remove_link()	2018-05-30 07:48:51 +02:00
afs	afs: Fix afs_kill_pages()	2017-12-20 10:04:56 +01:00
autofs4	autofs: fix autofs_sbi() does not check super block type	2018-09-19 22:49:00 +02:00
befs
bfs	bfs: add sanity check at bfs_fill_super()	2018-12-01 09:46:33 +01:00
btrfs	btrfs: wait on ordered extents on abort cleanup	2019-01-26 09:42:50 +01:00
cachefiles	fscache, cachefiles: remove redundant variable 'cache'	2018-12-17 21:55:12 +01:00
ceph	ceph: don't update importing cap's mseq when handing cap export	2019-01-13 10:05:33 +01:00
cifs	cifs: Always resolve hostname before reconnecting	2019-02-06 19:43:07 +01:00
coda	coda: fix 'kernel memory exposure attempt' in fsync	2017-11-24 08:32:25 +01:00
configfs	configfs: replace strncpy with memcpy	2018-11-21 09:27:44 +01:00
cramfs	Cramfs: fix abad comparison when wrap-arounds occur	2018-11-21 09:27:37 +01:00
debugfs	dentry name snapshots	2017-08-06 19:19:42 -07:00
devpts	devpts: clean up interface to pty drivers	2016-08-16 09:30:49 +02:00
dlm	dlm: memory leaks on error path in dlm_user_request()	2019-01-13 10:05:33 +01:00
ecryptfs	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:48:52 +02:00
efivarfs	efi: Make efivarfs entries immutable by default	2016-03-03 15:07:09 -08:00
efs
exofs	fs/exofs: fix potential memory leak in mount option parsing	2018-11-27 16:08:00 +01:00
exportfs	exportfs: do not read dentry after free	2018-12-17 21:55:10 +01:00
ext2	ext2: fix potential use after free	2018-12-13 09:21:27 +01:00
ext4	ext4: fix a potential fiemap/page fault deadlock w/ inline_data	2019-01-16 22:16:12 +01:00
f2fs	f2fs: read page index before freeing	2019-02-06 19:43:05 +01:00
fat	fs/fat/fatent.c: add cond_resched() to fat_count_free_clusters()	2018-11-10 07:41:40 -08:00
freevxfs
fscache	fscache: fix race between enablement and dropping of object	2018-12-17 21:55:11 +01:00
fuse	fuse: fix leaked notify reply	2018-11-21 09:27:44 +01:00
gfs2	gfs2: Revert "Fix loop in gfs2_rbm_find"	2019-02-06 19:43:07 +01:00
hfs	hfs: do not free node before using	2018-12-17 21:55:12 +01:00
hfsplus	hfsplus: do not free node before using	2018-12-17 21:55:12 +01:00
hostfs	hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common()	2016-09-30 10:18:39 +02:00
hpfs	hpfs: implement the show_options method	2016-06-01 12:15:54 -07:00
hugetlbfs	hugetlbfs: fix bug in pgoff overflow checking	2018-12-17 21:55:15 +01:00
isofs	isofs: fix timestamps beyond 2027	2017-11-30 08:37:20 +00:00
jbd2	jbd2: fix use after free in jbd2_log_do_checkpoint()	2018-11-21 09:27:34 +01:00
jffs2	jffs2: Fix use of uninitialized delayed_work, lockdep breakage	2019-01-26 09:42:53 +01:00
jfs	jfs: Fix inconsistency between memory allocation and ea_buf->max_size	2018-08-09 12:19:28 +02:00
kernfs	kernfs: Replace strncpy with memcpy	2018-12-13 09:21:29 +01:00
lockd	lockd: fix access beyond unterminated strings in prints	2018-11-21 09:27:36 +01:00
logfs
minix
ncpfs	staging: ncpfs: memory corruption in ncp_read_kernel()	2018-03-28 18:40:15 +02:00
nfs	NFSv4.1: Fix the r/wsize checking	2018-11-21 09:27:35 +01:00
nfs_common	lockd: fix "list_add double add" caused by legacy signal interface	2018-02-03 17:04:28 +01:00
nfsd	nfsd: fix corrupted reply to badly ordered compound	2018-10-10 08:52:07 +02:00
nilfs2	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:48:52 +02:00
nls
notify	fanotify: fix logic of events on child	2018-04-24 09:32:11 +02:00
ntfs
ocfs2	ocfs2: fix panic due to unrecovered local alloc	2019-01-26 09:42:55 +01:00
omfs
openpromfs
overlayfs	ovl: proper cleanup of workdir	2018-09-15 09:40:41 +02:00
proc	proc: Remove empty line in /proc/self/status	2019-01-26 09:42:49 +01:00
pstore	pstore/ram: Do not treat empty buffers as valid	2019-01-26 09:42:53 +01:00
qnx4
qnx6
quota	fs/quota: Fix spectre gadget in do_quotactl	2018-09-09 20:04:36 +02:00
ramfs
reiserfs	reiserfs: propagate errors from fill_with_dentries() properly	2018-11-27 16:08:00 +01:00
romfs	romfs: use different way to generate fsid for BLOCK or MTD	2017-06-17 06:39:38 +02:00
squashfs	squashfs: more metadata hardenings	2018-08-06 16:24:42 +02:00
sysfs	scsi: sysfs: Introduce sysfs_{un,}break_active_protection()	2018-09-05 09:18:40 +02:00
sysv	sysv: return 'err' instead of 0 in __sysv_write_inode	2018-12-17 21:55:09 +01:00
tracefs
ubifs	ubifs: Check for name being NULL while mounting	2018-10-13 09:11:34 +02:00
udf	udf: Detect incorrect directory size	2018-07-03 11:21:34 +02:00
ufs	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:48:52 +02:00
xfs	xfs: don't fail when converting shortform attr to long form during ATTR_REPLACE	2019-01-26 09:42:52 +01:00
aio.c	aio: fix spectre gadget in lookup_ioctx	2018-12-21 14:09:50 +01:00
anon_inodes.c
attr.c	vfs: move permission checking into notify_change() for utimes(NULL)	2016-10-22 12:26:56 +02:00
bad_inode.c
binfmt_aout.c
binfmt_elf.c	fs, elf: make sure to page align bss in load_elf_library	2018-11-21 09:27:41 +01:00
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c	fs/binfmt_misc.c: do not allow offset overflow	2018-07-03 11:21:26 +02:00
binfmt_script.c
block_dev.c	fs/block_dev: always invalidate cleancache in invalidate_bdev()	2017-05-20 14:27:01 +02:00
buffer.c	fs: add i_blocksize()	2017-06-14 13:16:24 +02:00
char_dev.c
compat.c
compat_binfmt_elf.c	binfmt_elf: compat: avoid unused function warning	2018-02-25 11:03:51 +01:00
compat_ioctl.c	fs: compat: Remove warning from COMPATIBLE_IOCTL	2018-04-08 11:51:57 +02:00
coredump.c	coredump: Ensure proper size of sparse core files	2017-07-05 14:37:20 +02:00
dax.c
dcache.c	fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()	2019-02-06 19:43:07 +01:00
dcookies.c
direct-io.c	direct-io: Prevent NULL pointer access in submit_page_section	2017-10-18 09:20:42 +02:00
drop_caches.c
eventfd.c
eventpoll.c	epoll: fix race between ep_poll_callback(POLLFREE) and ep_free()/ep_remove()	2017-09-07 08:34:10 +02:00
exec.c	mm: replace get_user_pages() write/force parameters with gup_flags	2018-12-17 21:55:16 +01:00
fcntl.c	fs/fcntl: f_setown, avoid undefined behaviour	2018-01-31 12:06:11 +01:00
fhandle.c	fs/coredump: prevent fsuid=0 dumps into user-controlled directories	2016-04-12 09:08:58 -07:00
file.c
file_table.c
filesystems.c
fs-writeback.c	bdi: Fix oops in wb_workfn()	2018-05-16 10:06:51 +02:00
fs_pin.c
fs_struct.c
inode.c	Fix up non-directory creation in SGID directories	2018-07-17 11:31:43 +02:00
internal.h
ioctl.c
Kconfig
Kconfig.binfmt
libfs.c
locks.c	locks: don't check for race with close when setting OFD lock	2018-01-17 09:35:27 +01:00
Makefile
mbcache.c
mount.h	mnt: In propgate_umount handle visiting mounts in any order	2017-07-21 07:44:57 +02:00
mpage.c	fs: add i_blocksize()	2017-06-14 13:16:24 +02:00
namei.c	namei: allow restricted O_CREAT of FIFOs and regular files	2018-12-01 09:46:41 +01:00
namespace.c	mount: Prevent MNT_DETACH from disconnecting locked mounts	2018-11-21 09:27:44 +01:00
no-block.c
nsfs.c	nsfs: mark dentry with DCACHE_RCUACCESS	2018-02-16 20:09:43 +01:00
open.c	fs: completely ignore unknown open flags	2017-07-15 11:57:44 +02:00
pipe.c	pipe: cap initial pipe capacity according to pipe-max-size limit	2018-05-26 08:48:51 +02:00
pnode.c	mnt: Make propagate_umount less slow for overlapping mount propagation trees	2017-07-21 07:44:58 +02:00
pnode.h	mnt: Add a per mount namespace limit on the number of mounts	2017-04-30 05:49:28 +02:00
posix_acl.c	tmpfs: clear S_ISGID when setting posix ACLs	2017-01-26 08:23:47 +01:00
proc_namespace.c	vfs: show_vfsstat: do not ignore errors from show_devname method	2016-04-12 09:08:55 -07:00
read_write.c	fs: add the fsnotify call to vfs_iter_write	2019-02-06 19:43:06 +01:00
readdir.c
select.c	fs/select: add vmalloc fallback for select(2)	2018-01-31 12:06:09 +01:00
seq_file.c	Make file credentials available to the seqfile interfaces	2017-08-06 19:19:42 -07:00
signalfd.c
splice.c	vfs: fix uninitialized flags in splice_to_pipe()	2017-02-23 17:43:09 +01:00
stack.c
stat.c	ufs: restore maintaining ->i_blocks	2017-06-14 13:16:24 +02:00
statfs.c
super.c	fs: don't scan the inode cache before SB_BORN is set	2019-02-06 19:43:08 +01:00
sync.c
timerfd.c	timerfd: Protect the might cancel mechanism proper	2017-05-08 07:46:01 +02:00
userfaultfd.c	userfaultfd: shmem: __do_fault requires VM_FAULT_NOPAGE	2017-12-20 10:04:53 +01:00
utimes.c	vfs: move permission checking into notify_change() for utimes(NULL)	2016-10-22 12:26:56 +02:00
xattr.c	getxattr: use correct xattr length	2018-09-09 20:04:36 +02:00