android_kernel_oneplus_msm8998/net/tipc
Junwei Hu 5bce46edeb tipc: fix modprobe tipc failed after switch order of device registration -v2
commit 526f5b851a96566803ee4bee60d0a34df56c77f8 upstream.

Error message printed:
modprobe: ERROR: could not insert 'tipc': Address family not
supported by protocol.
when modprobe tipc after the following patch: switch order of
device registration, commit 7e27e8d6130c
("tipc: switch order of device registration to fix a crash")

Because sock_create_kern(net, AF_TIPC, ...) called by
tipc_topsrv_create_listener() in the initialization process
of tipc_init_net(), so tipc_socket_init() must be execute before that.
Meanwhile, tipc_net_id need to be initialized when sock_create()
called, and tipc_socket_init() is no need to be called for each namespace.

I add a variable tipc_topsrv_net_ops, and split the
register_pernet_subsys() of tipc into two parts, and split
tipc_socket_init() with initialization of pernet params.

By the way, I fixed resources rollback error when tipc_bcast_init()
failed in tipc_init_net().

Fixes: 7e27e8d6130c ("tipc: switch order of device registration to fix a crash")
Signed-off-by: Junwei Hu <hujunwei4@huawei.com>
Reported-by: Wang Wang <wangwang2@huawei.com>
Reported-by: syzbot+1e8114b61079bfe9cbc5@syzkaller.appspotmail.com
Reviewed-by: Kang Zhou <zhoukang7@huawei.com>
Reviewed-by: Suanming Mou <mousuanming@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-06-11 12:24:07 +02:00
..
addr.c
addr.h
bcast.c
bcast.h
bearer.c
bearer.h
core.c tipc: fix modprobe tipc failed after switch order of device registration -v2 2019-06-11 12:24:07 +02:00
core.h
discover.c
discover.h
eth_media.c
ib_media.c
Kconfig
link.c tipc: fix link attribute propagation bug 2017-11-18 11:11:07 +01:00
link.h tipc: fix link attribute propagation bug 2017-11-18 11:11:07 +01:00
Makefile
msg.c tipc: use only positive error codes in messages 2017-10-21 17:09:03 +02:00
msg.h
name_distr.c
name_distr.h
name_table.c
name_table.h
net.c tipc: add policy for TIPC_NLA_NET_ADDR 2018-04-29 07:50:06 +02:00
net.h
netlink.c
netlink.h
netlink_compat.c tipc: check link name with right length in tipc_nl_compat_link_set 2019-05-16 19:44:52 +02:00
node.c
node.h
server.c tipc: fix memory leak in tipc_accept_from_sock() 2017-12-16 10:33:56 +01:00
server.h
socket.c
socket.h
subscr.c tipc: fix modprobe tipc failed after switch order of device registration -v2 2019-06-11 12:24:07 +02:00
subscr.h tipc: fix modprobe tipc failed after switch order of device registration -v2 2019-06-11 12:24:07 +02:00
sysctl.c
udp_media.c