9a35bc2ae5
commit 48dc5fb3ba53b20418de8514700f63d88c5de3a3 upstream.
The driver reads a value from hfa384x_from_bap(), which may fail,
and then assigns the value to a local variable. gcc detects that
in in the failure case, the 'rlen' variable now contains
uninitialized data:
In file included from ../drivers/net/wireless/intersil/hostap/hostap_pci.c:220:0:
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 'hfa384x_get_rid':
drivers/net/wireless/intersil/hostap/hostap_hw.c:842:5: warning: 'rec' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (le16_to_cpu(rec.len) == 0) {
This restructures the function as suggested by Russell King, to
make it more readable and get more reliable error handling, by
handling each failure mode using a goto.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
||
|---|---|---|
| .. | ||
| hostap.h | ||
| hostap_80211.h | ||
| hostap_80211_rx.c | ||
| hostap_80211_tx.c | ||
| hostap_ap.c | ||
| hostap_ap.h | ||
| hostap_common.h | ||
| hostap_config.h | ||
| hostap_cs.c | ||
| hostap_download.c | ||
| hostap_hw.c | ||
| hostap_info.c | ||
| hostap_ioctl.c | ||
| hostap_main.c | ||
| hostap_pci.c | ||
| hostap_plx.c | ||
| hostap_proc.c | ||
| hostap_wlan.h | ||
| Kconfig | ||
| Makefile | ||