evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
android_kernel_oneplus_msm8998/drivers/virtio
History
Arnd Bergmann 0c4c9449ab virtio_balloon: prevent uninitialized variable use 
commit f0bb2d50dfcc519f06f901aac88502be6ff1df2c upstream.

The latest gcc-7.0.1 snapshot reports a new warning:

virtio/virtio_balloon.c: In function 'update_balloon_stats':
virtio/virtio_balloon.c:258:26: error: 'events[2]' is used uninitialized in this function [-Werror=uninitialized]
virtio/virtio_balloon.c:260:26: error: 'events[3]' is used uninitialized in this function [-Werror=uninitialized]
virtio/virtio_balloon.c:261:56: error: 'events[18]' is used uninitialized in this function [-Werror=uninitialized]
virtio/virtio_balloon.c:262:56: error: 'events[17]' is used uninitialized in this function [-Werror=uninitialized]

This seems absolutely right, so we should add an extra check to
prevent copying uninitialized stack data into the statistics.
>From all I can tell, this has been broken since the statistics code
was originally added in 2.6.34.

Fixes: 9564e138b1 ("virtio: Add memory statistics reporting to the balloon driver (V4)")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ladi Prosek <lprosek@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-02-25 11:03:42 +01:00
..
config.c Remove all #inclusions of asm/system.h 2012-03-28 18:30:03 +01:00
Kconfig Add virtio-input driver. 2015-03-29 12:13:52 +10:30
Makefile Add virtio-input driver. 2015-03-29 12:13:52 +10:30
virtio.c virtio: release virtio index when fail to device_register 2017-12-16 10:33:48 +01:00
virtio_balloon.c virtio_balloon: prevent uninitialized variable use 2018-02-25 11:03:42 +01:00
virtio_input.c virtio-input: reset device and detach unused during remove 2015-08-06 10:40:35 +03:00
virtio_mmio.c virtio_mmio: add ACPI probing 2015-09-08 13:30:28 +03:00
virtio_pci_common.c virtio_pci: fix use after free on release 2016-03-03 15:07:18 -08:00
virtio_pci_common.h virtio-pci: alloc only resources actually used. 2015-06-24 08:15:09 +02:00
virtio_pci_legacy.c virtio-pci: alloc only resources actually used. 2015-06-24 08:15:09 +02:00
virtio_pci_modern.c virtio: virtio 1.0 cs04 spec compliance for reset 2016-04-20 15:42:10 +09:00
virtio_ring.c virtio_ring: Make interrupt suppression spec compliant 2016-11-10 16:36:34 +01:00