Nikolay Aleksandrov aa5d149531 sch_tbf: fix two null pointer dereferences on init failure ... commit c2d6511e6a4f1f3673d711569c00c3849549e9b0 upstream. sch_tbf calls qdisc_watchdog_cancel() in both its ->reset and ->destroy callbacks but it may fail before the timer is initialized due to missing options (either not supplied by user-space or set as a default qdisc), also q->qdisc is used by ->reset and ->destroy so we need it initialized. Reproduce: $ sysctl net.core.default_qdisc=tbf $ ip l set ethX up Crash log: [ 959.160172] BUG: unable to handle kernel NULL pointer dereference at 0000000000000018 [ 959.160323] IP: qdisc_reset+0xa/0x5c [ 959.160400] PGD 59cdb067 [ 959.160401] P4D 59cdb067 [ 959.160466] PUD 59ccb067 [ 959.160532] PMD 0 [ 959.160597] [ 959.160706] Oops: 0000 [#1] SMP [ 959.160778] Modules linked in: sch_tbf sch_sfb sch_prio sch_netem [ 959.160891] CPU: 2 PID: 1562 Comm: ip Not tainted 4.13.0-rc6+ #62 [ 959.160998] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014 [ 959.161157] task: ffff880059c9a700 task.stack: ffff8800376d0000 [ 959.161263] RIP: 0010:qdisc_reset+0xa/0x5c [ 959.161347] RSP: 0018:ffff8800376d3610 EFLAGS: 00010286 [ 959.161531] RAX: ffffffffa001b1dd RBX: ffff8800373a2800 RCX: 0000000000000000 [ 959.161733] RDX: ffffffff8215f160 RSI: ffffffff8215f160 RDI: 0000000000000000 [ 959.161939] RBP: ffff8800376d3618 R08: 00000000014080c0 R09: 00000000ffffffff [ 959.162141] R10: ffff8800376d3578 R11: 0000000000000020 R12: ffffffffa001d2c0 [ 959.162343] R13: ffff880037538000 R14: 00000000ffffffff R15: 0000000000000001 [ 959.162546] FS: 00007fcc5126b740(0000) GS:ffff88005d900000(0000) knlGS:0000000000000000 [ 959.162844] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 959.163030] CR2: 0000000000000018 CR3: 000000005abc4000 CR4: 00000000000406e0 [ 959.163233] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 959.163436] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 959.163638] Call Trace: [ 959.163788] tbf_reset+0x19/0x64 [sch_tbf] [ 959.163957] qdisc_destroy+0x8b/0xe5 [ 959.164119] qdisc_create_dflt+0x86/0x94 [ 959.164284] ? dev_activate+0x129/0x129 [ 959.164449] attach_one_default_qdisc+0x36/0x63 [ 959.164623] netdev_for_each_tx_queue+0x3d/0x48 [ 959.164795] dev_activate+0x4b/0x129 [ 959.164957] __dev_open+0xe7/0x104 [ 959.165118] __dev_change_flags+0xc6/0x15c [ 959.165287] dev_change_flags+0x25/0x59 [ 959.165451] do_setlink+0x30c/0xb3f [ 959.165613] ? check_chain_key+0xb0/0xfd [ 959.165782] rtnl_newlink+0x3a4/0x729 [ 959.165947] ? rtnl_newlink+0x117/0x729 [ 959.166121] ? ns_capable_common+0xd/0xb1 [ 959.166288] ? ns_capable+0x13/0x15 [ 959.166450] rtnetlink_rcv_msg+0x188/0x197 [ 959.166617] ? rcu_read_unlock+0x3e/0x5f [ 959.166783] ? rtnl_newlink+0x729/0x729 [ 959.166948] netlink_rcv_skb+0x6c/0xce [ 959.167113] rtnetlink_rcv+0x23/0x2a [ 959.167273] netlink_unicast+0x103/0x181 [ 959.167439] netlink_sendmsg+0x326/0x337 [ 959.167607] sock_sendmsg_nosec+0x14/0x3f [ 959.167772] sock_sendmsg+0x29/0x2e [ 959.167932] ___sys_sendmsg+0x209/0x28b [ 959.168098] ? do_raw_spin_unlock+0xcd/0xf8 [ 959.168267] ? _raw_spin_unlock+0x27/0x31 [ 959.168432] ? __handle_mm_fault+0x651/0xdb1 [ 959.168602] ? check_chain_key+0xb0/0xfd [ 959.168773] __sys_sendmsg+0x45/0x63 [ 959.168934] ? __sys_sendmsg+0x45/0x63 [ 959.169100] SyS_sendmsg+0x19/0x1b [ 959.169260] entry_SYSCALL_64_fastpath+0x23/0xc2 [ 959.169432] RIP: 0033:0x7fcc5097e690 [ 959.169592] RSP: 002b:00007ffd0d5c7b48 EFLAGS: 00000246 ORIG_RAX: 000000000000002e [ 959.169887] RAX: ffffffffffffffda RBX: ffffffff810d278c RCX: 00007fcc5097e690 [ 959.170089] RDX: 0000000000000000 RSI: 00007ffd0d5c7b90 RDI: 0000000000000003 [ 959.170292] RBP: ffff8800376d3f98 R08: 0000000000000001 R09: 0000000000000003 [ 959.170494] R10: 00007ffd0d5c7910 R11: 0000000000000246 R12: 0000000000000006 [ 959.170697] R13: 000000000066f1a0 R14: 00007ffd0d5cfc40 R15: 0000000000000000 [ 959.170900] ? trace_hardirqs_off_caller+0xa7/0xcf [ 959.171076] Code: 00 41 c7 84 24 14 01 00 00 00 00 00 00 41 c7 84 24 98 00 00 00 00 00 00 00 41 5c 41 5d 41 5e 5d c3 66 66 66 66 90 55 48 89 e5 53 <48> 8b 47 18 48 89 fb 48 8b 40 48 48 85 c0 74 02 ff d0 48 8b bb [ 959.171637] RIP: qdisc_reset+0xa/0x5c RSP: ffff8800376d3610 [ 959.171821] CR2: 0000000000000018 Fixes: 87b60cfacf9f ("net_sched: fix error recovery at qdisc creation") Fixes: 0fbbeb1ba4 ("[PKT_SCHED]: Fix missing qdisc_destroy() in qdisc_create_dflt()") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Amit Pundir <amit.pundir@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-09-15 09:40:42 +02:00
..
act_api.c	net sched actions: fix dumping which requires several messages to user space	2018-04-13 19:50:27 +02:00
act_bpf.c	net/sched: fix NULL dereference in the error path of tcf_bpf_init()	2018-04-13 19:50:25 +02:00
act_connmark.c	act_connmark: avoid crashing on malformed nlattrs with null parms	2017-03-22 12:04:16 +01:00
act_csum.c	sched: act_csum: don't mangle TCP and UDP GSO packets	2018-03-22 09:23:22 +01:00
act_gact.c
act_ipt.c	net: sched: fix NULL pointer dereference when action calls some targets	2017-08-30 10:19:21 +02:00
act_mirred.c	net_sched: close another race condition in tcf_mirred_release()	2017-05-02 21:19:49 -07:00
act_nat.c	bpf: try harder on clones when writing into skb	2016-07-11 09:31:12 -07:00
act_pedit.c	net/sched: pedit: make sure that offset is valid	2016-12-10 19:07:23 +01:00
act_police.c
act_simple.c
act_skbedit.c
act_vlan.c	net/sched: act_vlan: Push skb->data to mac_header prior calling skb_vlan_*() functions	2016-11-15 07:46:37 +01:00
cls_api.c	net, sched: fix soft lockup in tc_classify	2017-01-15 13:41:34 +01:00
cls_basic.c	net, sched: respect rcu grace period on cls destruction	2016-12-10 19:07:23 +01:00
cls_bpf.c	net, sched: respect rcu grace period on cls destruction	2016-12-10 19:07:23 +01:00
cls_cgroup.c	net, sched: respect rcu grace period on cls destruction	2016-12-10 19:07:23 +01:00
cls_flow.c	net, sched: respect rcu grace period on cls destruction	2016-12-10 19:07:23 +01:00
cls_flower.c	net, sched: respect rcu grace period on cls destruction	2016-12-10 19:07:23 +01:00
cls_fw.c
cls_route.c
cls_rsvp.c
cls_rsvp.h	net, sched: respect rcu grace period on cls destruction	2016-12-10 19:07:23 +01:00
cls_rsvp6.c
cls_tcindex.c	net_sched: fix NULL pointer dereference when delete tcindex filter	2018-08-22 07:48:35 +02:00
cls_u32.c
em_canid.c
em_cmp.c
em_ipset.c
em_meta.c	net_sched: em_meta: use skb_to_full_sk() helper	2015-11-08 20:56:39 -05:00
em_nbyte.c
em_text.c
em_u32.c
ematch.c
Kconfig
Makefile
sch_api.c	net: sched: Fix one possible panic when no destroy callback	2017-07-21 07:44:54 +02:00
sch_atm.c
sch_blackhole.c	net_sched: blackhole: tell upper qdisc about dropped packets	2018-07-22 14:25:53 +02:00
sch_cbq.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_choke.c	net_sched: red: Avoid illegal values	2018-02-25 11:03:40 +01:00
sch_codel.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_drr.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_dsmark.c	sch_dsmark: fix invalid skb_cow() usage	2017-12-25 14:22:10 +01:00
sch_fifo.c	net_sched: fix pfifo_head_drop behavior vs backlog	2016-07-11 09:31:11 -07:00
sch_fq.c	net_sched: fq: take care of throttled flows before reuse	2018-05-26 08:48:47 +02:00
sch_fq_codel.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_generic.c	net: sched: do not requeue a NULL skb	2016-05-18 17:06:35 -07:00
sch_gred.c	net_sched: red: Avoid illegal values	2018-02-25 11:03:40 +01:00
sch_hfsc.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_hhf.c	sch_hhf: fix null pointer dereference on init failure	2018-09-15 09:40:41 +02:00
sch_htb.c	sch_htb: fix crash on init failure	2018-09-15 09:40:41 +02:00
sch_ingress.c
sch_mq.c	net_sched: fix error recovery at qdisc creation	2017-07-21 07:44:54 +02:00
sch_mqprio.c	net_sched: fix error recovery at qdisc creation	2017-07-21 07:44:54 +02:00
sch_multiq.c	sch_multiq: fix double free on init failure	2018-09-15 09:40:41 +02:00
sch_netem.c	sch_netem: avoid null pointer deref on init failure	2018-09-15 09:40:42 +02:00
sch_pie.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_plug.c
sch_prio.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_qfq.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_red.c	net_sched: red: Avoid illegal values	2018-02-25 11:03:40 +01:00
sch_sfb.c	net_sched: update hierarchical backlog too	2016-05-18 17:06:39 -07:00
sch_sfq.c	net_sched: red: Avoid illegal values	2018-02-25 11:03:40 +01:00
sch_tbf.c	sch_tbf: fix two null pointer dereferences on init failure	2018-09-15 09:40:42 +02:00
sch_teql.c