I noticed that errors happening while hotplugging devices from the host were never returned back to the mconsole client. In some cases, success was returned instead of even an information-free error. This patch cleans that up by having the low-level configuration code pass back an error string along with an error code. At the top level, which knows whether it is early boot time or responding to an mconsole request, the string is printk'd or returned to the mconsole client. There are also whitespace and trivial code cleanups in the surrounding code. Signed-off-by: Jeff Dike <jdike@addtoit.com> Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
39 lines
839 B
C
39 lines
839 B
C
/*
|
|
* Copyright (C) 2002 Jeff Dike (jdike@karaya.com)
|
|
* Licensed under the GPL
|
|
*/
|
|
|
|
#include "linux/init.h"
|
|
#include "mconsole_kern.h"
|
|
|
|
#ifdef CONFIG_MCONSOLE
|
|
|
|
extern int gdb_config(char *str, char **error_out);
|
|
extern int gdb_remove(int n, char **error_out);
|
|
|
|
static struct mc_device gdb_mc = {
|
|
.name = "gdb",
|
|
.config = gdb_config,
|
|
.remove = gdb_remove,
|
|
};
|
|
|
|
int gdb_mc_init(void)
|
|
{
|
|
mconsole_register_dev(&gdb_mc);
|
|
return(0);
|
|
}
|
|
|
|
__initcall(gdb_mc_init);
|
|
|
|
#endif
|
|
|
|
/*
|
|
* Overrides for Emacs so that we follow Linus's tabbing style.
|
|
* Emacs will notice this stuff at the end of the file and automatically
|
|
* adjust the settings for this buffer only. This must remain at the end
|
|
* of the file.
|
|
* ---------------------------------------------------------------------------
|
|
* Local variables:
|
|
* c-file-style: "linux"
|
|
* End:
|
|
*/
|