Tang Junhui 3d0dca33a2 bcache: fix kcrashes with fio in RAID5 backend dev ... [ Upstream commit 60eb34ec5526e264c2bbaea4f7512d714d791caf ] Kernel crashed when run fio in a RAID5 backend bcache device, the call trace is bellow: [ 440.012034] kernel BUG at block/blk-ioc.c:146! [ 440.012696] invalid opcode: 0000 [#1] SMP NOPTI [ 440.026537] CPU: 2 PID: 2205 Comm: md127_raid5 Not tainted 4.15.0 #8 [ 440.027441] Hardware name: HP ProLiant MicroServer Gen8, BIOS J06 07/16 /2015 [ 440.028615] RIP: 0010:put_io_context+0x8b/0x90 [ 440.029246] RSP: 0018:ffffa8c882b43af8 EFLAGS: 00010246 [ 440.029990] RAX: 0000000000000000 RBX: ffffa8c88294fca0 RCX: 0000000000 0f4240 [ 440.031006] RDX: 0000000000000004 RSI: 0000000000000286 RDI: ffffa8c882 94fca0 [ 440.032030] RBP: ffffa8c882b43b10 R08: 0000000000000003 R09: ffff949cb8 0c1700 [ 440.033206] R10: 0000000000000104 R11: 000000000000b71c R12: 00000000000 01000 [ 440.034222] R13: 0000000000000000 R14: ffff949cad84db70 R15: ffff949cb11 bd1e0 [ 440.035239] FS: 0000000000000000(0000) GS:ffff949cba280000(0000) knlGS: 0000000000000000 [ 440.060190] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 440.084967] CR2: 00007ff0493ef000 CR3: 00000002f1e0a002 CR4: 00000000001 606e0 [ 440.110498] Call Trace: [ 440.135443] bio_disassociate_task+0x1b/0x60 [ 440.160355] bio_free+0x1b/0x60 [ 440.184666] bio_put+0x23/0x30 [ 440.208272] search_free+0x23/0x40 [bcache] [ 440.231448] cached_dev_write_complete+0x31/0x70 [bcache] [ 440.254468] closure_put+0xb6/0xd0 [bcache] [ 440.277087] request_endio+0x30/0x40 [bcache] [ 440.298703] bio_endio+0xa1/0x120 [ 440.319644] handle_stripe+0x418/0x2270 [raid456] [ 440.340614] ? load_balance+0x17b/0x9c0 [ 440.360506] handle_active_stripes.isra.58+0x387/0x5a0 [raid456] [ 440.380675] ? __release_stripe+0x15/0x20 [raid456] [ 440.400132] raid5d+0x3ed/0x5d0 [raid456] [ 440.419193] ? schedule+0x36/0x80 [ 440.437932] ? schedule_timeout+0x1d2/0x2f0 [ 440.456136] md_thread+0x122/0x150 [ 440.473687] ? wait_woken+0x80/0x80 [ 440.491411] kthread+0x102/0x140 [ 440.508636] ? find_pers+0x70/0x70 [ 440.524927] ? kthread_associate_blkcg+0xa0/0xa0 [ 440.541791] ret_from_fork+0x35/0x40 [ 440.558020] Code: c2 48 00 5b 41 5c 41 5d 5d c3 48 89 c6 4c 89 e7 e8 bb c2 48 00 48 8b 3d bc 36 4b 01 48 89 de e8 7c f7 e0 ff 5b 41 5c 41 5d 5d c3 <0f> 0b 0f 1f 00 0f 1f 44 00 00 55 48 8d 47 b8 48 89 e5 41 57 41 [ 440.610020] RIP: put_io_context+0x8b/0x90 RSP: ffffa8c882b43af8 [ 440.628575] ---[ end trace a1fd79d85643a73e ]-- All the crash issue happened when a bypass IO coming, in such scenario s->iop.bio is pointed to the s->orig_bio. In search_free(), it finishes the s->orig_bio by calling bio_complete(), and after that, s->iop.bio became invalid, then kernel would crash when calling bio_put(). Maybe its upper layer's faulty, since bio should not be freed before we calling bio_put(), but we'd better calling bio_put() first before calling bio_complete() to notify upper layer ending this bio. This patch moves bio_complete() under bio_put() to avoid kernel crash. [mlyle: fixed commit subject for character limits] Reported-by: Matthias Ferdinand <bcache@mfedv.net> Tested-by: Matthias Ferdinand <bcache@mfedv.net> Signed-off-by: Tang Junhui <tang.junhui@zte.com.cn> Reviewed-by: Michael Lyle <mlyle@lyle.org> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-05-30 07:49:02 +02:00
..
accessibility
acpi	ACPI: processor_perflib: Do not send _PPC change notification if not ready	2018-05-30 07:48:56 +02:00
amba	ARM: amba: Don't read past the end of sysfs "driver_override" buffer	2018-05-02 07:53:42 -07:00
android	binder: add missing binder_unlock()	2018-02-28 10:17:23 +01:00
ata	libata: blacklist Micron 500IT SSD with MU01 firmware	2018-05-30 07:48:51 +02:00
atm	atm: zatm: Fix potential Spectre v1	2018-05-16 10:06:52 +02:00
auxdisplay
base	regmap: Fix reversed bounds check in regmap_raw_write()	2018-04-24 09:32:06 +02:00
bcma
block	block/loop: fix deadlock after loop_set_status	2018-04-24 09:32:03 +02:00
bluetooth	Revert "Bluetooth: btusb: Fix quirk for Atheros 1525/QCA6174"	2018-05-16 10:06:52 +02:00
bus	bus: brcmstb_gisb: correct support for 64-bit address output	2018-04-13 19:50:05 +02:00
cdrom	cdrom: information leak in cdrom_ioctl_media_changed()	2018-04-29 07:50:07 +02:00
char	ipmi/powernv: Fix error return code in ipmi_powernv_probe()	2018-05-30 07:48:54 +02:00
clk	clk: bcm2835: De-assert/assert PLL reset signal when appropriate	2018-04-24 09:32:08 +02:00
clocksource	clocksource/drivers/fsl_ftm_timer: Fix error return checking	2018-05-30 07:49:01 +02:00
connector
cpufreq	cpufreq: intel_pstate: Enable HWP by default	2018-05-26 08:48:54 +02:00
cpuidle	cpuidle: coupled: remove unused define cpuidle_coupled_lock	2018-05-26 08:48:53 +02:00
crypto	crypto: s5p-sss - Fix kernel Oops in AES-ECB mode	2018-02-25 11:03:55 +01:00
dca
devfreq	PM / devfreq: Propagate error from devfreq_add_device()	2018-02-22 15:44:58 +01:00
dio
dma	dmaengine: rcar-dmac: fix max_chunk_size for R-Car Gen3	2018-05-30 07:49:02 +02:00
dma-buf
edac	EDAC, mv64x60: Fix an error handling path	2018-04-13 19:50:23 +02:00
eisa
extcon	extcon: palmas: Check the parent instance to prevent the NULL	2017-11-21 09:21:18 +01:00
firewire	firewire-ohci: work around oversized DMA reads on JMicron controllers	2018-05-30 07:48:52 +02:00
firmware	firmware: dmi_scan: Fix handling of empty DMI strings	2018-05-30 07:48:56 +02:00
fmc
fpga
gpio	gpio: rcar: Add Runtime PM handling for interrupts	2018-05-26 08:49:00 +02:00
gpu	virtio-gpu: fix ioctl and expose the fixed status to userspace.	2018-05-30 07:49:02 +02:00
hid	HID: roccat: prevent an out of bounds read in kovaplus_profile_activated()	2018-05-30 07:48:54 +02:00
hsi	HSI: ssi_protocol: double free in ssip_pn_xmit()	2018-03-24 10:58:42 +01:00
hv	Drivers: hv: vmbus: fix build warning	2018-02-25 11:03:46 +01:00
hwmon	hwmon: (ina2xx) Fix access to uninitialized mutex	2018-04-24 09:32:04 +02:00
hwspinlock
hwtracing	coresight: Fix disabling of CoreSight TPIU	2018-03-24 10:58:48 +01:00
i2c	i2c: i2c-scmi: add a MS HID	2018-03-24 10:58:41 +01:00
ide
idle	idle: i7300: add PCI dependency	2018-02-25 11:03:51 +01:00
iio	iio: magnetometer: st_magn_spi: fix spi_device_id table	2018-04-13 19:50:21 +02:00
infiniband	IB/ipoib: Fix for potential no-carrier state	2018-05-30 07:48:55 +02:00
input	Input: atmel_mxt_ts - add touchpad button mapping for Samsung Chromebook Pro	2018-05-16 10:06:48 +02:00
iommu	iommu/vt-d: Fix a potential memory leak	2018-04-24 09:32:08 +02:00
ipack
irqchip	irqchip/gic-v3: Change pr_debug message to pr_devel	2018-05-30 07:48:57 +02:00
isdn	mISDN: Fix a sleep-in-atomic bug	2018-04-13 19:50:16 +02:00
leds	leds: pca955x: Correct I2C Functionality	2018-04-13 19:50:09 +02:00
lguest
lightnvm
macintosh
mailbox	mailbox: handle empty message in tx_tick	2017-08-06 19:19:41 -07:00
mcb
md	bcache: fix kcrashes with fio in RAID5 backend dev	2018-05-30 07:49:02 +02:00
media	media: dmxdev: fix error code for invalid ioctls	2018-05-30 07:49:01 +02:00
memory	ARM: OMAP2+: gpmc-onenand: propagate error on initialization failure	2017-12-16 10:33:51 +01:00
memstick
message	scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()	2018-05-30 07:48:58 +02:00
mfd	mfd: palmas: Reset the POWERHOLD mux during power off	2018-03-24 10:58:44 +01:00
misc	drivers/misc/vmw_vmci/vmci_queue_pair.c: fix a couple integer overflow tests	2018-04-13 19:50:02 +02:00
mmc	mmc: sdhci-iproc: fix 32bit writes for TRANSFER_MODE register	2018-05-30 07:48:51 +02:00
mtd	gpmi-nand: Handle ECC Errors in erased pages	2018-05-16 10:06:47 +02:00
net	r8152: fix tx packets accounting	2018-05-30 07:49:02 +02:00
nfc	NFC: nfcmrvl: double free on error path	2018-03-22 09:23:23 +01:00
ntb	ntb_transport: Fix bug with max_mw_size parameter	2018-05-30 07:48:55 +02:00
nubus
nvdimm	libnvdimm, namespace: make 'resource' attribute only readable by root	2017-11-30 08:37:23 +00:00
nvme	nvme-pci: Fix nvme queue cleanup if IRQ setup fails	2018-05-30 07:49:01 +02:00
nvmem	nvmem: imx-ocotp: Fix wrong register size	2017-08-06 19:19:46 -07:00
of	of: fix of_device_get_modalias returned length when truncating buffers	2018-03-22 09:23:21 +01:00
oprofile
parisc	parisc: Hide Diva-built-in serial aux and graphics card	2018-01-02 20:33:20 +01:00
parport	parport_pc: Add support for WCH CH382L PCI-E single parallel port card.	2018-04-08 11:52:00 +02:00
pci	PCI: Add function 1 DMA alias quirk for Marvell 9128	2018-05-30 07:48:53 +02:00
pcmcia
perf	drivers/perf: arm_pmu: handle no platform_device	2018-03-22 09:23:26 +01:00
phy	phy: work around 'phys' references to usb-nop-xceiv devices	2018-01-23 19:50:16 +01:00
pinctrl	pinctrl: Really force states during suspend/resume	2018-03-24 10:58:48 +01:00
platform	platform/chrome: Use proper protocol transfer function	2018-03-24 10:58:47 +01:00
pnp
power	power: supply: pda_power: move from timer to delayed_work	2018-03-24 10:58:45 +01:00
powercap	PowerCap: Fix an error code in powercap_register_zone()	2018-04-13 19:50:05 +02:00
pps
ps3
ptp	time: Change posix clocks ops interfaces to use timespec64	2018-03-24 10:58:40 +01:00
pwm	pwm: tegra: Increase precision in PWM rate calculation	2018-03-22 09:23:27 +01:00
rapidio
ras
regulator	regulator: anatop: set default voltage selector for pcie	2018-03-24 10:58:40 +01:00
remoteproc
reset
rpmsg
rtc	rtc: interface: Validate alarm-time before handling rollover	2018-04-13 19:50:15 +02:00
s390	s390/cio: clear timer when terminating driver I/O	2018-05-30 07:49:00 +02:00
sbus
scsi	scsi: qla4xxx: skip error recovery in case of register disconnect.	2018-05-30 07:48:58 +02:00
sfi
sh
sn
soc
spi	spi: pxa2xx: Allow 64-bit DMA	2018-05-26 08:48:52 +02:00
spmi	spmi: Include OF based modalias in device uevent	2017-07-27 15:06:10 -07:00
ssb	ssb: mark ssb_bus_register as __maybe_unused	2018-02-25 11:03:44 +01:00
staging	staging: ion : Donnot wakeup kswapd in ion system alloc	2018-04-29 07:50:01 +02:00
target	tcm_fileio: Prevent information leak for short reads	2018-03-24 10:58:45 +01:00
tc
thermal	thermal: imx: Fix race condition in imx_thermal_probe()	2018-04-24 09:32:08 +02:00
thunderbolt	thunderbolt: Resume control channel after hibernation image is created	2018-04-24 09:32:07 +02:00
tty	serial: mctrl_gpio: Add missing module license	2018-05-02 07:53:43 -07:00
uio
usb	usb: musb: fix enumeration after resume	2018-05-30 07:48:59 +02:00
uwb	uwb: ensure that endpoint is interrupt	2017-10-12 11:27:35 +02:00
vfio	vfio/pci: Virtualize Maximum Read Request Size	2018-04-24 09:32:09 +02:00
vhost	vhost: correctly remove wait queue during poll failure	2018-04-13 19:50:25 +02:00
video	vfb: fix video mode and line_length being set when loaded	2018-04-13 19:50:13 +02:00
virt
virtio	virtio_balloon: prevent uninitialized variable use	2018-02-25 11:03:42 +01:00
vlynq
vme
w1
watchdog	watchdog: sp5100_tco: Fix watchdog disable bit	2018-05-30 07:48:53 +02:00
xen	xen/grant-table: Use put_page instead of free_page	2018-05-30 07:48:56 +02:00
zorro
Kconfig
Makefile	usb: build drivers/usb/common/ when USB_SUPPORT is set	2018-02-25 11:03:38 +01:00