Trond Myklebust 498e9066b4 nfsd: Don't release the callback slot unless it was actually held ... commit e6abc8caa6deb14be2a206253f7e1c5e37e9515b upstream. If there are multiple callbacks queued, waiting for the callback slot when the callback gets shut down, then they all currently end up acting as if they hold the slot, and call nfsd4_cb_sequence_done() resulting in interesting side-effects. In addition, the 'retry_nowait' path in nfsd4_cb_sequence_done() causes a loop back to nfsd4_cb_prepare() without first freeing the slot, which causes a deadlock when nfsd41_cb_get_slot() gets called a second time. This patch therefore adds a boolean to track whether or not the callback did pick up the slot, so that it can do the right thing in these 2 cases. Cc: stable@vger.kernel.org Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2019-05-16 19:44:44 +02:00
..
acl.h	nfsd4: remove nfs4_acl_new	2014-07-08 17:14:27 -04:00
auth.c	nfsd: auth: Fix gid sorting when rootsquash enabled	2018-01-31 12:06:14 +01:00
auth.h
blocklayout.c	fs: add i_blocksize()	2017-06-14 13:16:24 +02:00
blocklayoutxdr.c	pnfs: move common blocklayout XDR defintions to nfs4.h	2015-08-17 13:22:49 -05:00
blocklayoutxdr.h	pnfs: move common blocklayout XDR defintions to nfs4.h	2015-08-17 13:22:49 -05:00
cache.h	nfsd: Remove the cache_hash list	2014-08-17 12:00:12 -04:00
current_stateid.h
export.c	sunrpc/nfsd: Remove redundant code by exports seq_operations functions	2015-08-13 08:59:02 -04:00
export.h	nfsd: include linux/nfs4.h in export.h	2015-08-13 10:21:21 -04:00
fault_inject.c	nfsd: remove old fault injection infrastructure	2014-08-05 10:55:10 -04:00
idmap.h	nfsd: Remove duplicate define of IDMAP_NAMESZ/IDMAP_TYPE_xx	2015-07-20 14:58:46 -04:00
Kconfig	Merge branch 'for-4.1' of git://linux-nfs.org/~bfields/linux	2015-04-24 07:46:05 -07:00
lockd.c
Makefile	nfsd: pNFS block layout driver	2015-02-05 14:35:18 +01:00
netns.h	nfsd: New counter for generating client confirm verifier	2015-08-10 16:05:47 -04:00
nfs2acl.c	nfsd: check permissions when setting ACLs	2016-07-27 09:47:30 -07:00
nfs3acl.c	nfsd: check permissions when setting ACLs	2016-07-27 09:47:30 -07:00
nfs3proc.c	nfsd: fix memory corruption caused by readdir	2019-03-23 08:44:39 +01:00
nfs3xdr.c	nfsd: fix memory corruption caused by readdir	2019-03-23 08:44:39 +01:00
nfs4acl.c	nfsd: check permissions when setting ACLs	2016-07-27 09:47:30 -07:00
nfs4callback.c	nfsd: Don't release the callback slot unless it was actually held	2019-05-16 19:44:44 +02:00
nfs4idmap.c	nfsd: Remove duplicate define of IDMAP_NAMESZ/IDMAP_TYPE_xx	2015-07-20 14:58:46 -04:00
nfs4layouts.c	NFSD: Fix a null reference case in find_or_create_lock_stateid()	2017-02-09 08:02:45 +01:00
nfs4proc.c	nfsd: fix corrupted reply to badly ordered compound	2018-10-10 08:52:07 +02:00
nfs4recover.c	nfsd: don't WARN/backtrace for invalid container deployment.	2015-08-31 16:32:08 -04:00
nfs4state.c	lockd: fix "list_add double add" caused by legacy signal interface	2018-02-03 17:04:28 +01:00
nfs4xdr.c	nfsd: fix potential use-after-free in nfsd4_decode_getdeviceinfo	2018-08-06 16:24:30 +02:00
nfscache.c	nfsd: remove recurring workqueue job to clean DRC	2015-11-10 09:25:51 -05:00
nfsctl.c	nfsd: fix wrong check in write_v4_end_grace()	2019-03-23 08:44:39 +01:00
nfsd.h	nfsd: eliminate NFSD_DEBUG	2015-04-21 16:16:02 -04:00
nfsfh.c	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
nfsfh.h	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
nfsproc.c	nfsd: Disable NFSv2 timestamp workaround for NFSv3+	2015-05-29 11:04:01 -04:00
nfssvc.c	NFSD: fix nfsd_reset_versions for NFSv4.	2017-12-20 10:04:53 +01:00
nfsxdr.c	nfsd: stricter decoding of write-like NFSv2/v3 ops	2017-05-08 07:46:02 +02:00
pnfs.h	nfsd4: fix v3-less build	2015-02-16 11:43:13 -05:00
state.h	nfsd: Don't release the callback slot unless it was actually held	2019-05-16 19:44:44 +02:00
stats.c
stats.h
trace.c	nfsd: move include of state.h from trace.c to trace.h	2015-10-23 15:57:29 -04:00
trace.h	nfsd: move include of state.h from trace.c to trace.h	2015-10-23 15:57:29 -04:00
vfs.c	NFS: don't try to cross a mountpount when there isn't one there.	2018-03-24 10:58:44 +01:00
vfs.h	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
xdr.h
xdr3.h
xdr4.h	nfsd: switch unsigned char flags in svc_fh to bools	2015-10-12 17:31:04 -04:00
xdr4cb.h	nfsd: implement pNFS layout recalls	2015-02-02 18:09:43 +01:00