evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

input: touchscreen: Correct return value check in Goodix driver

Browse source 
Correct return value check of gtp_read_fw_version, called in probe
of the Goodix driver. The return value is actually the number of
registers read through gtp_i2c_read() function call.
Also change the error message of gtp_check_product_id.

Change-Id: I0b643e250a487f08a19555237802b020b0873d1a
Signed-off-by: Shantanu Jain <shjain@codeaurora.org>
This commit is contained in:
Shantanu Jain 2013-10-03 14:28:37 +05:30 • committed by Gerrit - the friendly Code Review server
parent 431c5aa98a
commit 4e02797d45
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/input/touchscreen/gt9xx/gt9xx.c
View file

@ -1057,7 +1057,7 @@ static int gtp_check_product_id(struct i2c_client *client)
ret = gtp_i2c_read(client, buf, sizeof(buf));
if (ret < 0) {
dev_err(&client->dev, "GTP read version failed.\n");
dev_err(&client->dev, "GTP read product_id failed.\n");
return -EIO;
}
@ -1740,7 +1740,7 @@ static int goodix_ts_probe(struct i2c_client *client,
dev_info(&client->dev, "GTP works in interrupt mode.\n");
ret = gtp_read_fw_version(client, &version_info);
if (ret != 0)
if (ret != 2)
dev_err(&client->dev, "GTP firmware version read failed.\n");
ret = gtp_check_product_id(client);