evie/android_kernel_oneplus_msm8998
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc: qcom: irq-helper: Add comments to exposed APIs

Browse source 
Add comments and might_sleep() to warn that irq_blacklist_on/off
APIs should not be called in atomic context.

CRs-Fixed: 1063719
Change-Id: Ie6858243a666aeb21cc486208b9dd8221e9ad674
Signed-off-by: Runmin Wang <runminw@codeaurora.org>
This commit is contained in:
Runmin Wang 2016-09-06 16:07:30 -07:00
parent 11d6060fff
commit e7549a9c25
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/soc/qcom/irq-helper.c
View file

@ -78,10 +78,12 @@ IRQ_HELPER_ATTR(irq_blacklist_on, 0444, show_deploy, NULL);
static struct irq_helper *irq_h; static struct irq_helper *irq_h;
/* Do not call this API in an atomic context */
int irq_blacklist_on(void) int irq_blacklist_on(void)
{ {
bool flag = false; bool flag = false;
might_sleep();
if (!irq_h) { if (!irq_h) {
pr_err("%s: init function is not called", __func__); pr_err("%s: init function is not called", __func__);
return -EPERM; return -EPERM;
@ -103,10 +105,12 @@ int irq_blacklist_on(void)
} }
EXPORT_SYMBOL(irq_blacklist_on); EXPORT_SYMBOL(irq_blacklist_on);
/* Do not call this API in an atomic context */
int irq_blacklist_off(void) int irq_blacklist_off(void)
{ {
bool flag = false; bool flag = false;
might_sleep();
if (!irq_h) { if (!irq_h) {
pr_err("%s: init function is not called", __func__); pr_err("%s: init function is not called", __func__);
return -EPERM; return -EPERM;