Commit graph

563773 commits

Author SHA1 Message Date
Hemant Kumar
1abf160f23 usb: dwc3: Allocate TRB pool upon enabling endpoint
Currently gadget driver is by default allocating dma TRB
pool per endpoint for 30 endpoints upon driver probe.
Optimize this by allocating dma memory only for enabled
endpoints.

Change-Id: I378a42d0b84fa43f7c20cd025cd9361c467cb41b
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
2016-03-22 11:06:56 -07:00
Mayank Rana
6fd132c4c0 dwc3: gadget: Use default TX FIFO size as 1024 bytes with each IN eps
Commit d8a39efaa477 ("dwc3: gadget: Improve TX FIFO resize functionality")
is considering USB enumerated speed to allocate TX FIFO size for each IN
endpoints. This change simplifies this by using 1024 bytes as default
TXFIFO size with each IN endpoints.

Change-Id: I55b5886c824d9b689ac8496f50f6e0e784afae98
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:55 -07:00
Mayank Rana
47576f9878 dwc3: gadget: Avoid processing of trb if HWO bit is set
HWO bit signifies that TRB is still pending with hardware. Hence
avoid processing of TRB if HWO bit is set.

Change-Id: I6d4068eb9e6934f68e7b6204cac8f6f3266dabf4
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:54 -07:00
Mayank Rana
feb12aaa55 dwc3: Increase event buffer size to 8KB from 256 bytes
Commit 5da9347825 ("usb: dwc3: decrease event buffer size") has
decreased controller's event buffer size to 256 bytes which results
into multiple overflow events. Receiving of overflow events suggests
that software is not able to process received events fast enough
which results into losing of those events. Fix this issue by
increasing event buffer size to 8KB.

Change-Id: I37f6203f0b6d87098d57b2ce0ba8a3a0b8ef5bd2
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:53 -07:00
Mayank Rana
ef0629fbde dwc3: gadget: Improve TX FIFO resize functionality
This change considers USB device speed to set max_packet size
instead of provided max_packet value from USB function driver.
It doesn't resize ep0IN TxFIFO, and starts with ep1IN TxFIFO only.

Change-Id: Ifce63f5a8570f79bad1e5d3ae6f5d580c34046b5
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:52 -07:00
Mayank Rana
32db5976ed dwc3: gadget: Initialized USB TRBs pool memory with zero
dma_coherent_alloc() API doesn't guaranteed that allocated memory
is initialized with zero. It is observed in some cases where there
is stale data seen with allocated memory for TRB pool and providing
this TRB with USB controller results into different memory access
issues. Fix this issue by using dma_zalloc_coherent() API which
allocates memory and initialized it with zero.

Change-Id: I160e319aace262958a11ba5196f53ec21b98977f
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:51 -07:00
Ido Shayevitz
865addc7d4 drivers: usb: dwc3: Add XMIT_DEV command
Starting with synopsis version 220A the command to wake up the
host changed from 0x3 to 0x7. The code is fixed accordingly.
The problem that was seen is that upon MBIM function
suspend, a remote wakeup from the IPA side wouldn't
wake up the host, and at some point a stall in the IPA would be
seen.

CRs-fixed: 695414
Change-Id: I6ef5c649f263f388a1cc92a3db71c14c741b5b71
Signed-off-by: Lena Salman <esalman@codeaurora.org>
Signed-off-by: Ido Shayevitz <idos@codeaurora.org>
2016-03-22 11:06:50 -07:00
Hemant Kumar
d8a457b42d usb: dwc3-msm: Bring controller out of LPM early upon system resume
In case of host initiated usb bus resume upon system suspend controller
exits from LPM as part of dwc3 PM resume. Since call to dwc3 PM resume
from PM framework involves latency due to which usb device misses the
timeline of response for bus resume. This results into host issuing warm
reset. Hence bring controller out of LPM in power event irq thread context.
Set IRQF_EARLY_RESUME for power event irq which reduces irq level latency
by enabling this irq early during system resume. Also, save power event
irq time stamp to track latency between hard irq and irq thread.

CRs-Fixed: 804476
Change-Id: Ib5470c6046ffbfff55b89e717f040bd6435454da
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
2016-03-22 11:06:49 -07:00
Mayank Rana
2991c5cf8c dwc3: gadget: Ignore suspend event if USB is not into CONFIGURED state
For reboot usecase with some of host machine, it has been observed that
Suspend event is being received in between USB enumeration process which
is highly unlikely case. Although due to this event, device side USB goes
into suspend state which cause USB device enumerates as unknown device
with host machine. Fix this issue by ignoring suspend event until USB
enumeration process is not being completed i.e. device side USB is not
reach into CONFIGURED state.

Add check for CONFIGURED state with controller suspend routine as well
to make sure that if this routine finds controller into L2 state before
it performs LPM functionality, it confirms that state of USB as
CONFIGURED.

CRs-Fixed: 717151
Change-Id: I86925f22edf94c526a3b7504333501b6e27412d7
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:48 -07:00
Mayank Rana
b371a833e6 usb: dwc3: core: Disable internal clock gating conditionally
Currently USB DWC3 controller's internal clock gating is disabled
unconditionally. In few platform, it is possible to enable internal
clock gating with controller. Hence this change adds support to
disable this functionality conditionally using "snps,disable-clk-gating"
device tree property. With this change USB controller's internal clock
gating is enabled by default.

CRs-Fixed: 851877
Change-Id: I17d43a23d3bff0cb516b952c35c4a13af53f7777
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:47 -07:00
Mayank Rana
7d2a036a4e dwc3: gadget: Add NULL check against endpoint's desc in set_halt()
In few instances, dwc3_gadget_ep_set_halt() API is called after USB
endpoint is disabled which results into device crash with NULL pointer
dereference. USB endpoint's descriptors are set to NULL as part of USB
endpoint disable functionality. Hence fix this issue by adding NULL
pointer check against endpoint's descriptor.

CRs-Fixed: 829034
Change-Id: I2e1f67571ed202fab21655bd8f13fc54706419a7
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:47 -07:00
Jack Pham
710341d1cf usb: dwc3: Ignore multiple U3/L2 suspend events
The controller may sometimes generate back-to-back suspend
interrupt events. Ignore the repeated events to avoid calling
the gadget driver's suspend callback multiple times.

Change-Id: I284b461adeab5911388efd8bb7ecbf39a85c86ca
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:46 -07:00
Jack Pham
78c60a7bf6 usb: dwc3: gadget: Keep track of IRQ timing statistics
It may be useful to debug how much time is spent in the
DWC3 hard IRQ context. Add low-overhead statistics counters
which keep a histogram of the last 10 interrupts' time of
occurence, time spent, and number of events read (which will
get processed in the bottom half handler).

Change-Id: I466144d8141f4236b9fb834dded93225b56d0422
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:45 -07:00
Manu Gautam
13a30395d6 DWC3: gadget: Report error if RX buffer not aligned to EP's MTU
Synopsys USB3 Controller (DWC3) has a restriction where size
of OUT requests (TRB) queued to the controller must be aligned
with the endpoint's max packet size. Hence, report error in case
function driver tries to queue an unaligned request.

Change-Id: Id5f4a0ff9d2f9c55bba936d683608c524eadd260
Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
2016-03-22 11:06:44 -07:00
Mayank Rana
fcc26a6a54 usb: dwc3: Fall back to high speed when SSPHY fails
In some cases, it has been observed that SSPHY fails to initialized.
This change detects this condition and configures controller to work
into high speed mode only.

Change-Id: I50c4041d8572d0cdc4535812eebd10fc18b78e98
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:43 -07:00
Jack Pham
0071b357da usb: dwc3: gadget: Fix calculation of request.actual for SG
When a request completes, cleanup_done_trbs() tries to calculate
request.actual by subtracting the TRB remainder from the original
request.length, but does not account for scatter-gather requests
that queued multiple TRBs. In this case, the request.length field
may be used by the function to keep track of the aggregate length
of all the provided SG entries, and thus will produce an incorrect
request.actual. Instead, for scatter-gather, to find the pre-transfer
buffer length of each TRB, get the length field of each SG entry.
Then the number of bytes transfered can be correctly determined as
the difference between that and the bytes remaining in the TRB.

Change-Id: I4c197462ce5b804c9d684240e95c35b532976220
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:42 -07:00
Hemant Kumar
4e32ea8f3b usb: dwc3: Do not call WARN_ON_ONCE from interrupt context
Gadget driver calls WARN_ON_ONCE in some of the APIs which
are called from interrupt context. This may lead to watchdog
bark if repeated WARN_ON_ONCE condition occurs. Hence print
error message and/or log it in debug buffer.

CRs-Fixed: 747698
Change-Id: Ieecd6342135e7d2bad36c82a12958b78054150db
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
2016-03-22 11:06:41 -07:00
Jack Pham
b0b1bb5940 usb: dwc3: gadget: Resolve recursive spinlock during remote wakeup
When a USB function wishes to send new data during USB suspend state, it
needs to issue USB remote wakeup and send a function wakeup notification
after then. This scenario leads to recursive spin locking inside the
_usb_func_wakeup() function, because this function gets called recursively.
This function issues remote wakeup, which internally calls the resume
interrupt callback, which calls the _usb_func_wakeup() function again.
This issue is resolved by performing the remote wakeup in a deferred work
context, and this splits the recursion loop.

CRs-fixed: 700667
Change-Id: I59c8efde098781587d29f08cd60e4aa3521949d8
Signed-off-by: Danny Segal <dsegal@codeaurora.org>
2016-03-22 11:06:41 -07:00
Hemant Kumar
c6d80a92b7 usb: dwc3: gadget: Prevent tx fifo resize before set config
If device took longer than expected time queuing zlp in status
stage host issues bus reset. As a result tx fifio resize happens
at status stage of first control transfer after bus reset. This
causes null pointer dereference for config pointer as device is
not in configured state yet. Hence clear the resize_fifos flag
upon bus reset to avoid this situation. Also add NULL check in
dwc3_gadget_resize_tx_fifos().

CRs-Fixed: 747688
Change-Id: Icd50eaa15f75c1b0bd7e2f8db5550ad54af47ef8
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
2016-03-22 11:06:40 -07:00
Mayank Rana
3bbd6278f2 dwc3: gadget: Clear per endpoint ring buffer when disabling endpoint
Current code is not clearing ring buffer once it is being initialized.
Issue is seen where xferinprogress interrupt is received with
isochronous endpoint due to stale TRB (for isochronous endpoint we
are using LINK TRB), we enqueue new request buffer using update
transfer command. If stale TRB is having HWO bit being set, controller
is trying to execute that particular TRB which results into error on
bus as that request buffer is already being freed or used by other
subsystem. Fix this issue by clearing per endpoint ring buffer when
disabling endpoint.

CRs-Fixed: 782340
Change-Id: I46e6a46400367d6ebf55bdb445a3330c0a4d77e1
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:39 -07:00
Vijayavardhan Vennapusa
4083e89ea0 USB: dwc3: Fix issues in isochronous endpoint handling
If there are no requests queued by function driver when
XFRNRDY interrupt is recieved, pending flag will be set.
Then if function driver queues request, don't queue ENDTXFR
command and wait for XFRNRDY interrupt.

START TRANSFER command will fail if the interval for which
requests are being queued is already expired. Handle this
case by queueing ENDXFER command and waiting till recieves
XFRNRDY interrupt.

Change-Id: I9498be3967e0f80b05cf0830affe5463f07e2976
Signed-off-by: Vijayavardhan Vennapusa <vvreddy@codeaurora.org>
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:38 -07:00
Mayank Rana
def08da7f5 usb: dwc3: Add error print messages
There is a possible race that arises when gadget events are processed
before the resume routine has disabled the USB2 PHY autosuspend. Some
of the gadget events issue endpoint commands which may time out since
the PHY is still autosuspended. Add error messages to help debug
these failurs.

Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:37 -07:00
Jack Pham
f0487e67e5 usb: dwc3: Adjust TX FIFO allocation
Optimize the dwc3_gadget_resize_tx_fifos() function to better
allocate the per-endpoint FIFOs depending on a number of factors:

	- super- or non-super speed
	- bulk/isoc with bursting
	- reduced RAM (when QDSS uses some internal RAM)
	- endpoint enabled in composition

Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:36 -07:00
Danny Segal
88ffd6eb95 usb: dwc: Fix function wakeup during suspend on SW path
When the SW wants to start USB traffic during USB bus suspend state, it
needs to issue remote-wakeup signaling to the USB host before sending the
function wakeup notification. This patch changes the function wakeup
sending notification function to check whenter the USB bus is suspended
and issue remote-wakeup if needed.

CRs-Fixed: 678203
Change-Id: I1b09e7763c821a0a0e62095b4dc1c8621a2316b3
Signed-off-by: Danny Segal <dsegal@codeaurora.org>
2016-03-22 11:06:35 -07:00
Danny Segal
635cdb12e4 gadget: dwc: Support remote wakeup bit in GET_STATUS command in HS-USB mode
In High-Speed mode, the remote wakeup feature is enabled by a SET_FEATURE
command sent from the host. This patch adds the logic reflect this
configuration in the device GET_STATUS command response.

Change-Id: I0c934d0330d2580f15b1307005dde7b4b7874a7d
Signed-off-by: Danny Segal <dsegal@codeaurora.org>
2016-03-22 11:06:34 -07:00
Danny Segal
8f171cb53f usb: dwc: add support for super-speed function suspend
The USB 3.0 specification defines a new 'Function Suspend' feature.
This feature enables the USB host to put inactive composite device
functions in a suspended state even when the device itself is not
suspended.
This patch extends the existing framework of USB dwc driver
to properly support the 'Function Resume' and 'Function Remote Wakeup'
related features.

Change-Id: If7bbfa7d6a4ff70d4b44ede5fc258370b890df47
Signed-off-by: Danny Segal <dsegal@codeaurora.org>
2016-03-22 11:06:34 -07:00
Jack Pham
9e134dbb1b usb: gadget: Add udc_priv member to struct usb_request
This member is used to store additional private flags
for BAM-enabled functions to pass information to the UDC.

Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:33 -07:00
Bar Weiner
fb759c4758 usb: dwc3: gadget: allow running wakeup in delayed context
Adding the option of running the gadget wakeup function
from the context in which it is called, or delaying it - in case
it is called from an atomic context. This is required in order
to support a case where the gadget is in lpm and the wakeup
would result in a queue to the low-powered hardware.

Change-Id: I09fc60e75c79202c97251146aab1539de3307424
Signed-off-by: Bar Weiner <bweiner@codeaurora.org>
Signed-off-by: Danny Segal <dsegal@codeaurora.org>
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:32 -07:00
Vijayavardhan Vennapusa
567c83ebc7 USB: dwc3: Add support for fixing superspeed enumeration issue
Setting SSPHY SUSP bit (bit 17) in GUSB3PIPECTL(0) register
might cause device enumerating at high speed mode instead of
superspeed mode on some platforms. Hence add workaround by
clearing the SSPHY SUSP bit during disconnect and setting it
after it is configured to fix this enumeration issue on those
platforms.

Also add support for disabling U1 and U2 low power modes  which
could also affect this enumeration issue.

CRs-Fixed: 637902
Change-Id: I8668ced09a88b77f37265ab15e89fa9e964bfbe9
Signed-off-by: Vijayavardhan Vennapusa <vvreddy@codeaurora.org>
[jackp@codeaurora.org: only add u1/u2 disable bits]
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:31 -07:00
Bar Weiner
01edad63c9 usb: dwc3: add in_lpm flag to struct dwc3
This change provides the gadget with awareness regarding
the vendor-specific's low-power-mode status. This is done
in order to enable proper decision making regarding cases
where the gadget would potentially attempt to interface the
hardware when it's in lpm.

Change-Id: I1508fbddd13228fbb7d6d53d91d98a0acaaf3fd7
Signed-off-by: Bar Weiner <bweiner@codeaurora.org>
2016-03-22 11:06:30 -07:00
Bar Weiner
87ac720b8a usb: dwc3: add support for pwr_event_irq
Adds support for the pwr_event_irq in general, and for
the L1_OUT pwr event specifically. The support consists of:
1. Enabling the pwr_event_irq based on the DT.
2. Adding a threaded irq handler as well as a centralized function
   (dwc3_pwr_event_handler()) for handling the various power events.
3. Enabling the L1_OUT pwr event. This is done on an
   arch-by-arch basis. The trigger for enabling this is
   dbm_l1_lpm_interrupt().
4. Calling usb_gadget_wakeup() in order to initiate a wakeup sequence
   without sending a remote-wakeup indication to the host.
5. Adding a call from dwc3_msm_resume() to dwc3_pwr_event_handler().
   This is done in order to overcome a situation where
   dwc3_msm_suspend() would have disabled the clocks, thereby
   disabling the ability to read the PWR_STAT register before calling
   the handler function.

Change-Id: Ia548ec2e9ee4a7c6634c87ba24fe4cdbf1221000
Signed-off-by: Dov Levenglick <dovl@codeaurora.org>
Signed-off-by: Bar Weiner <bweiner@codeaurora.org>
2016-03-22 11:06:29 -07:00
Dov Levenglick
94e3cbb5f2 usb: dwc3: gadget: ignore suspend interrupt before connect
The controller sees a suspend event prior to the the cable connect
or reset events. As a result, it runs through an unnecessary
suspend sequence. Adding a check on the gadget's state avoids
the overhead.
The root cause of this appears to be a situation where the
controller senses/is told that there is a VBUS, but the port
reset is not forthcoming. In such a case, the line state is
interpreted as suspend, and the event is generated.
When VBUS detach is sensed/indicated, the state is returned to
USB_STATE_NOTATTACHED, in preparation for the next cable connect.

Change-Id: I639454ceb0ad3a8ff2c02d527c553a934b8639fc
Signed-off-by: Dov Levenglick <dovl@codeaurora.org>
2016-03-22 11:06:28 -07:00
Jack Pham
abeac45ef6 usb: dwc3: Add missing defines
Add bit definition for the GUSB2PHYCFG ENBLSLPM bit.
Add definition for DWC3_GUCTL_REFCLKPER which is used to set
the reference clock frequency. Also add definition for
DWC3_GDBGLTSSM_LINKSTATE_MASK used to query the HW for
the current LTSSM link state.

Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:27 -07:00
Bar Weiner
a1ee10d4cc usb: dwc3: gadget: allow remote-wakeup for SS-USB
Remove the restriction in the code that disables the possibility
of device remote wakeup in SS-USB.
Originally, this restriction was coded since suspend/resume in SS-USB
is expected to be performed at the function level, rather than the
device level. However, the suspend is currently done at the device
level, and therefore the corresponding remote wakeup should also
follow in suit.
The concept of function suspend/resume may be revisited in the future.

Change-Id: If071f38c03cf46290536cafad1a13a6818088eb7
Signed-off-by: Bar Weiner <bweiner@codeaurora.org>
2016-03-22 11:06:27 -07:00
Mayank Rana
7fcaf72280 usb: dwc3: Keep track of interrupt statistics
This change adds debug support to log all received different
events with endpoint0, other endpoints and gadget events. It
tracks these events per endpoint and displays the same.

For each of the endpoint event counters, add the rate (in Hz)
at which it occurs in order to better analyze performance and
aid in optimization.

How to use:
- Mount debugfs
- To see received all dwc3 events/interrupts
cat /sys/kernel/debug/<base_address>.dwc3/int_events
- To clear all received dwc3 events/interrupts
echo 0 > /sys/kernel/debug/<base_address>.dwc3/int_events

Change-Id: Ibf5f3ee57f69c87f94f55a58f50792075be24fbb
Signed-off-by: Gilad Broner <gbroner@codeaurora.org>
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:26 -07:00
Dov Levenglick
ce73ca32ca usb: dwc3: gadget: start resume sequence on remote-wakeup
As per Synopsys databook, the USB controller does not
trigger a wakeup event when remote-wakeup is used.
Hence, after remote-wakeup sequence is complete, and
the device is back at U0 state, it is required that
the resume sequence is initiated manually by SW.

Change-Id: I2f147d4a0644088b948b1798627c7717c35c0104
Signed-off-by: Bar Weiner <bweiner@codeaurora.org>
Signed-off-by: Dov Levenglick <dovl@codeaurora.org>
2016-03-22 11:06:25 -07:00
Jack Pham
c694893be5 usb: dwc3: gadget: Protect against ep disabling during completion
In dwc3_cleanup_done_reqs(), a potential race condition
could arise when dwc3_gadget_giveback() temporarily
releases the main spinlock.  If during this window the
very endpoint being handled becomes disabled, it would
lead to a NULL pointer dereference in the code that
follows.  Guard against this by making sure the endpoint
is still enabled after returning from the giveback call.

CRs-fixed: 628972
Change-Id: Ifdb823fff12747f699217d871a5959c85b5340f7
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:24 -07:00
Mayank Rana
06b8c38125 dwc3: Disable USB Link state(U1/U2) change events
Currently all USB Link state change events are enable which are
triggering huge number of interrupts to the cpu. Disable U1/U2 Link
state entry/exit events by using dwc_usb3_devten register. Below is
one of test results showing the same.
Test case: Run tethered RMNET UDP UL/DL Modem looback with 50M bandwidth
Test duration: 120 seconds
Test Results :
- with USB Link state change events enable:
CPU Idle : 42%, Number of USB Link state change events: 3769013
- with USB Link state change events disable:
CPU Idle : 51%, Number of USB Link state change events: 0
These numbers (cpu usage, number of interrupts) are taken for
120 seconds duration of test execution.

This change also does enable U3L2L1SuspEn event (BIT:6)  to get U3
notification and handling suspend part. Wakeup event is already enabled
which takes care of USB resuming.

CRs-Fixed: 610718
Change-Id: Ied6da6699849a3136a35de0b9a27ee18086daeab
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
2016-03-22 11:06:23 -07:00
Jack Pham
78c2759dea usb: dwc3: Stop processing more events after erratic error
In rare cases if the controller is unable to communicate with the
PHY it will trigger an ERRATIC ERROR event, upon which it is
recommended that the controller be reset. Currently the reset
is scheduled to be performed in a workqueue, which relinquishes
the dwc3_interrupt thread to continue to process the event buffer.
Meanwhile if the reset runs concurrently, it would disable the core
clock, which would result in unclocked I/O access if the gadget
interrupt handling continues to run. Fix this by stopping the
interrupt thread and prevent further interrupts from reading DWC3
registers until the reset sequence has completed.

Change-Id: Ib9a2173867d2ce3c9dbc5f5cbff0dda554168b35
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:22 -07:00
Jack Pham
d675e70190 usb: dwc3: gadget: Handle erratic error event only once
DWC3 databook suggests that upon receiving erratic error event
software should reset the controller. The way in which the
driver currently handles interrupts by offloading event processing
to a threaded handler could result in a long sequence of received
erratic errors in the event queue. dwc3_gadget_interrupt() could
then end up processing a large number of the same event unnecessarily.

In the case of dwc3-msm, this results in KERN_INFO messages flooding
the console. Fix this by only handling erratic error once. Add
a state variable to keep track of when it is seen, and clear it
once a non-error event is processed.

Change-Id: I5deeb2a614f9002867472a0e4aa26a61f0413ceb
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:21 -07:00
Jack Pham
0b937c189f usb: dwc3: gadget: Ensure core is not suspended when handling interrupt
Since dwc3_thread_interrupt is part of interrupt handling that
can be scheduled to run in thread context, it leaves open a
window in which the controller might be placed into low power
mode. In this state, clocks would be disabled, and by the time
dwc3_thread_interrupt runs, would result in an unclocked I/O
access when it tries to write to the GEVNTCOUNT register.

Prevent this by calling pm_runtime_get() in dwc3_interrupt() in
order to force the device to remain in active state, which
increments the parent device's child count so that it too is
prevented from entering suspend. Call pm_runtime_put() at the
end of dwc3_thread_interrupt() after finishing processing the
event buffers.

CRs-fixed: 609233
CRs-fixed: 622850
Change-Id: Ia21c9ac74d74833a889081f41c93acec2a7ae011
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:21 -07:00
Jack Pham
88f0a43593 usb: dwc3: Enable newer refclk-based SOF/ITP generation
Add support for refclk-based SOF and ITP generation, which is
present on DWC3 cores starting in revision 2.50a. This supersedes
the functionality provided by GCTL.SOFTITPSYNC which handled ITP
generation only. This introduces the new GFLADJ register and
writes its fields based on the reference clock period to the
core, which can now be specified as a device tree parameter.

Change-Id: I2c57586cd8b5275b77ebe64cf0835617f0340b62
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:20 -07:00
Manu Gautam
b311a3dbc4 usb: dwc3: core: Allow platform glue driver to handle PM
DWC3 platform glue driver on some targets is responsible for
dealing with power management. They might even implement
runtime suspend for DWC3 and want to keep devices in suspend
during system PM state transitions. Also, DWC3 core driver
doesn't implement runtime PM and carries out hardware read
write operations assuming it is never put in LPM and clocks
would always be ON.
Hence, for platforms which implement aggressive power management
of DWC3 from its glue driver, make core's PM ops as NO-OP and
just notify them of the core PM states using callback.

Change-Id: If82913ebe753236682e31ab351c991c3f855b2f1
Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
2016-03-22 11:06:19 -07:00
Jack Pham
5de8e63f16 USB: dwc3: Implement revised initialization sequence
Revise initialization and power-on routines to
be more consistent with recommended sequences.
Since some of the same sequences are repeated during
USB cable reconnection and exiting from power collapse,
consolidate these into common routines to avoid duplicated code.

Also don't perform controller and PHYs soft reset as they may
result in unknown flip-flop state resulting in undefined issues.
Soft reset is not required as Controller and PHY are reset using
GCC anyway.

Change-Id: I99856ac2ff01daa75b7e6d5a584c1b314402aa03
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:18 -07:00
Wesley Cheng
10bfd21360 USB: dwc3: gadget: Reset device core before setting Run/stop bit
When cable is disconnected, SW does device initiated disconnect
by clearing run/stop bit in DCTL register. When software wants to
reconnect to host, it has to do soft reset USB core and then
do device reinitialization.

By default max burst size for for control endpoints are initialized
to zero. This leads to setting burst size to non zero value for
control endpoints as part of reenabling endpoint 0 and 1 which results
in command queued for ep0 out getting timed out. Hence fix this by
initializing burst size to one in udc_start() API.

CRs-Fixed: 494807
Change-Id: I0a23ae8bc80932f9f66f792a1149ad5d8ac7d4a2
Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
2016-03-22 11:06:17 -07:00
Jack Pham
36e0761d75 usb: dwc3: Set elastic buffer mode
Add a device tree property to allow setting the GUSB3PIPECTRL
Elastic Buffer Mode (bit 0). By default set the buffer to
half-full to work around SuperSpeed link errors. If the property
is set, set the buffer to be nominally empty.

This change is a combination of two previous commits:

	USB: dwc3: core: Set elastic buffer mode to zero

	Currently elastic buffer mode in GUSB3PIPE_CTRL(0) register is
	set to one. This results in high link error rates and superspeed
	mode transfer failures if VDDCX is at super turbo mode voltage
	1.05V. Hence set elastic buffer mode to zero in GUSB3PIP_CTRL
	register.

	usb: dwc3: Do not set half-full elastic buffer

	On some platforms setting of half-full elastic buffer will cause data
	corruption and hence we need to avoid this setting.

Signed-off-by: Vijayavardhan Vennapusa <vvreddy@codeaurora.org>
Signed-off-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:16 -07:00
Vijayavardhan Vennapusa
72dfd99183 USB: dwc3: Add debug support for DWC3 driver
Add support for DWC3 driver to dump requests in SW queue
list, requests queued to USB HW and trb list as well. Also
add support for logging endpoint events through debugfs.
Enable logging of EP0 control events by default.

Example:
To capture 2 in endpoint events
echo -n 4 > /sys/module/dwc3/parameters/ep_addr_txdbg_mask
To capture 3 out endpoint events
echo -n 8 > /sys/module/dwc3/parameters/ep_addr_rxdbg_mask
To print debug log events on endpoints
cat /sys/kernel/debug/dwc3/events

To dump requests in SW queue list for 6 out endpoint
echo 6 0 > /sys/kernel/debug/dwc3/requests
cat /sys/kernel/debug/dwc3/requests
To dump requests queued to USB HW for 8 in endpoint
echo 8 1 > /sys/kernel/debug/dwc3/queued_reqs
cat /sys/kernel/debug/dwc3/queued_reqs
To dump TRBs for 9 in endpoint
echo 9 1 > /sys/kernel/debug/dwc3/trbs
cat /sys/kernel/debug/dwc3/trbs

Change-Id: I84e963b8299a1af76de9a35a6ea46ec34b9fe79e
Signed-off-by: Vijayavardhan Vennapusa <vvreddy@codeaurora.org>
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:15 -07:00
Jack Pham
2799624a41 usb: dwc3: Expose dwc3_trb_dma_offset
Expose this function for use in the glue layer.

Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:14 -07:00
Manu Gautam
5ffe965cf4 usb: dwc3: gadget: Fail request submission if it was already queued
Function driver should not try to queue a busy request again to DCD
until DCD returns it by calling its completion handler or it is
explicitly dequeued. Some buggy function driver may try to submit a
request again which is with DCD resulting in corruption of request_list
leading to crash later in giveback. Catch such conditions and fail the
request submission to DCD.

CRs-Fixed: 447192
Change-Id: Id2a4a1720f61dffc50cc22598734f229caf07ff3
Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
2016-03-22 11:06:13 -07:00
Mayank Rana
0e58b939fb usb: dwc3: gadget: Introduce endless endpoints
There are 3 different transport used for BAM communication and
each BAM pipe can be BAM2BAM or SYS2BAM configuration. Currently
all different per endpoint related interrupts/events are enabled
with USB controller for this configuration. Hence although data
transfer is happening through BAM hardware accerlation path, APPS
is receiving interrupt for each completion from USB controller.
This change binds property with each endpoint if it is being used
in BAM2BAM mode, and enables required interrupts with USB
controller. This significantly reduces number of interrupts
received on APPS with keeping CPU idle in all tethered calls.

Change-Id: I0185606f93996bf7a8c3f9451950b7c4cf9e21c7
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
[jackp@codeaurora.org: renamed subject, omitted u_bam.c and u_bam_data.c]
Signed-off-by: Jack Pham <jackp@codeaurora.org>
2016-03-22 11:06:12 -07:00