Unsanitized pointer after kfree leads to potential risk.
Set pointer to NULL.
CRs-Fixed: 2008031
Change-Id: Ia59a57fcd142a6ed18d168992b8da4019314afa4
Signed-off-by: Xiaojun Sang <xsang@codeaurora.org>
Add the minimum and maximum fps supported and enable dynamic
fps and esd for fhd video mode panel. Enable ESD, ULPS for
NT and Truly command mode panels. Enable partial update for
truly fhd command mode panel.
Change-Id: I0fe5502d74903e13544603154e853f4b486ca7be
Signed-off-by: Ashish Garg <ashigarg@codeaurora.org>
OLEDB driver needs the LAB_VREG_OK status to program the PD_CTL
register after the oledb module is enabled. As this status register
is not accessible from the OLEDB driver, register a notifier callback
with LABIBB driver to get LAB_VREG_OK status.
Change-Id: I85009688a2accb6246135d22e08ee21fb8296f62
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
With QUP in shared mode, enabling and disabling the
resources in runtime pm will cause failure of
transactions over the QUP that are running on other
execution environment. To avoid the failure
enable/disable gpios and clocks of QUP per transfer.
Also move the clock prepare and unprepare calls
to runtime pm APIs from the transfer API to
reduce the latencies in the transactions.
Change-Id: Ic697cdc544405d86ec7c675922c18c00fec451a6
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Signed-off-by: Shrey Vijay <shreyv@codeaurora.org>
Add sub-device node to allow mba to be able to load in carveout
memory region for SDM660.
Change-Id: I0e9932a0a779a66b7a3d4b682a60885cb7d799c5
Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
This reverts commit 3e47c53624 ("firmware_class: Add an
additional path to fw_path list").
Adding /firmware/images entry in fw_path is introducing selinux
denials as the access was happening under the client process
context. Removing the entry from fw_path structure.
Change-Id: I359f8defe49595a7e53558992080cb94eba42451
Signed-off-by: Satya Durga Srinivasu Prabhala <satyap@codeaurora.org>
Commit dbca823c25bf ("f_gsi: Don't send end xfer command when USB is
into U3 state") consolidated below usecases path for RNDIS:
1. USB RNDIS adaptor disable/enable case
2. USB RNDIS suspend/resume case
3. USB cable connect case
Due to USB GSI endpoints are getting disabled as part of above usecase
1 i.e. adaptor disable, it is required to reconfigure and re-enable USB
GSI endpoints when adaptor is enabled. USB GSI endpoints are re-configured
but not re-enabled for above usecase 3 although it is already configured
and enabled as pat of set_alt(1). Hence USB GSI endpoint are partially
configured causing no USB data transfer between USB GSI and IPA GSI which
fails IP address assignment. Fix this issue by making sure that USB GSI
endpoints are not reconfigured in above usecase 3.
CRs-Fixed: 1095920
Change-Id: I67068bac21274d715f61f9e5b83fae54e2c8e22d
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
It is recommended to avoid sending end xfer command with USB GSI
endpoint when USB is into U3 state (i.e. bus suspended) as USB
controller may hang. USB GSI driver sends end xfer command with
suspend implementation when remote wakeup is not allowed. Hence
update IPA driver about remote wakeup status to suspend or
disconnect IPA GSI channel whereas remove sending end xfer command
to USB controller when remote wakeup is not allowed.
CRs-Fixed: 1077546
Change-Id: I3ac3714ccaf4ac9f16c26f59b9550aa825483344
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
USB function driver uses usb_gadget_autopm_get() API to increments
USB controller device's PM runtime usage and child count, and also
expects that USB controller is resumed. Late suspend disables USB
controller device's PM runtime functionality by incrementing
disable_depth count and early resume enables it back once system is
resumed. This results into pm_runtime_get_sync() returning -EACCESS
when APPS is power collapsed and it is resuming due to USB bus resume
case. usb_gadget_autopm_get() API is decrementing device's PM runtime
usage count if it receives error value from pm_runtime_get_sync() API.
USB function driver doesn't check return value which results into
continuing USB operation. On next bus suspend, it decrements usage count
although it was not incremented in previous resume case which makes PM
runtime usage count negative. This can cause multiple issues as below:
1. USB bus resume may take more time causing host re-enumerating USB
gadget device
2. Unclock register access on remote wakeup case
3. USB host mode enumeration may fail due to dwc3 device usage count
is negative.
Fix this issue by making usb ipa wq as freezable workqueue which will
make sure that ipa_work_handler() work is executed only after system is
resumed and USB controller device's PM runtime is enabled.
CRs-Fixed: 1075002, 1074383
Change-Id: I300d1a0081fafcbef3c00c63cddd49be54a651e5
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
usb_func_ep_queue() returns -EAGAIN if usb is function suspended and
successfully remote wakeup is performed. This change fixes error
handling with USB GSI function driver to make sure caller knows that
request is actually queued or not from this context. This makes sure
that USB request is queued once USB host has resumed USB bus.
CRs-Fixed: 1033093
Change-Id: I3f3cb1b6b42530bfa93e0d4badacfe651b6bbb4c
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
the spec says the frame size will not be greater than
14, but this have a security hole when somebody sends
a message with a size greater than 14. So need check
up-boud of the CEC frame size.
Change-Id: I743208badc5e77ae911cfb2d102f758d4843138f
Signed-off-by: zhaoyuan <yzhao@codeaurora.org>
Unregister glink notification handle after SSR as otherwise it results
in the link up notification to be skipped resulting in incorrectly
completing the port open notification.
Change-Id: I668de44163a702faade1f170a74f66fb5a0c5571
Signed-off-by: Sathish Ambley <sathishambley@codeaurora.org>
Increment GSI command timeout. This is needed since during Q6 GSI FW
authentication GSI HW is disabled and the response for the HW may be
delayed.
CRs-Fixed:
Change-Id: Ia9ed0f0163abbfd3e242c38a9aea084c1c37e8fd
Signed-off-by: Gidon Studinski <gidons@codeaurora.org>:
This change adds the validation of qseed3 params before programming
the registers. This check would prevent any wrong configuration on
the vig src pipes.
CRs-Fixed: 2008489
Change-Id: If05d95349ba437332778a378804e6dd373ba2beb
Signed-off-by: Abhijit Kulkarni <kabhijit@codeaurora.org>
Add mutex around qseecom_set_client_mem_param to prevent an
ioctl thread modifying and corrupting data which is being
processed by another ioctl in the other thread
Change-Id: I0cfb8afab4001c2913be693dfe44c761b9568893
Signed-off-by: Zhen Kong <zkong@codeaurora.org>
In order to support multiple instances of mhi_uci
net devices, add platform device support. Platform
specific information can be specified in the device
tree and used in the driver. Also create separate debug
log buffer per client to make debugging easier.
CRs-Fixed: 1086301
Change-Id: Ibfc9b7bb36e5d10a56c9b72494806419383b72f6
Signed-off-by: Sujeev Dias <sdias@codeaurora.org>
In case of user PD restart requests from clients, return a separate error
code if PDR is disabled on subsystem. This is so that clients can
distinguish it from other error cases and take appropriate action.
CRs-Fixed: 2011758
Change-Id: Ifac7779455a3984de97a4e3e2f33bd74c5148cab
Signed-off-by: Puja Gupta <pujag@codeaurora.org>
The call to kasprintf() can fail, with a failure to
allocate memory. Handle the condition appropriately.
CRs-Fixed: 1014400
Change-Id: I83d3a6c8bdfd7a104b88a3bedd50f49faeecd97a
Signed-off-by: Hanumant Singh <hanumant@codeaurora.org>
When pil loading done through user space helper, there is a possibility
that signal could be pending on thread that initiated the pil, which would
lead to pil failure. To avoid this issue, move pil loading for ADSP, SLPI
and CDSP to separate workqueue in respective loader drivers.
Change-Id: Ie60a7eba7c52ac1565ce166d0e367379cce0b03e
Signed-off-by: Satya Durga Srinivasu Prabhala <satyap@codeaurora.org>
Averaging 10 die temperature samples reduces error caused by
a trim issue.
Change-Id: Ie0b9477c121df92544280b8e322c2205c680f6eb
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
700Khz is not a harmonic of the digital clock and is optimal enough
for all vbus ranges. Running the smb in the non harmonic freq range
is required for correct TDIE adc reporting.
Change-Id: Ib70d64cd72b7408474fd64df287f6404d3749764
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
During continuous splash handoff the pipes are unstaged and the
timing engine is being turned off. But this change is not
being flushed. Right after that we release the splash memory
and this sometimes causes a memory fault. This change adds
the necessary flush.
Change-Id: Ia78359fd8159a7217ffc4f0192788f295ac3504c
Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
Add placeholders for the KGSL power limit functions if
CONFIG_QCOM_KGSL is not enabled in the kernel config.
Change-Id: Ic0dedbad15b54cd8c3eba1b0649cb23193dbc16c
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Kernel compilation warning is generated due to
these uninitialized variables access. This change
fixes them by initializing the variables.
Change-Id: Ifae04fe5e4d1b9a0c2c399a3c6746c38dea5c4cc
CRs-fixed: 2004062
Signed-off-by: Ghanim Fodi <gfodi@codeaurora.org>
ipa3_get_ep_mapping() is used to map an IPA client to
IPA endpoint index. The index is used as array index.
This change validates that the returned index is
within the valid range.
CRs-fixed: 2012203
Change-Id: I25df8d0c9b60a5290f2457dd2ed77f2c7e78b46f
Signed-off-by: Ghanim Fodi <gfodi@codeaurora.org>
Update compress driver to support session start delay.
Userspace can use this param to delay start of
playback session.
CRs-Fixed: 1112258
Change-Id: I0b31a4bae12f9f2b1f8a3e003909741529458772
Signed-off-by: Manish Dewangan <manish@codeaurora.org>
Update compress driver to support configuration of DSP render
window. Render window is used by DSP to take rendering decision.
i.e whether input frame should be rendered, dropped or repeated.
CRs-Fixed: 1112258
Change-Id: Ib1b9100ab87878d2e2da93e2b86ca68fb9dd97a9
Signed-off-by: Manish Dewangan <manish@codeaurora.org>
Update compress driver to support configuration of DSP clock
recovery mode. Supported modes are auto and none. In auto mode
DSP does clock recovery based on avtimer and device drift otherwise
it ignores drift.
CRs-Fixed: 1112258
Change-Id: I4b6b37c08be422e38b7f0bf625712d5e2b0dc0f3
Signed-off-by: Manish Dewangan <manish@codeaurora.org>
ASM driver changes to configure clock recovery mode.
Based on the configure mode, DSP decides whether to enable
clock recovery or not.
CRs-Fixed: 1112258
Change-Id: Ia6a6c33ce7b478af8d2397c20fcc6281d96ec3ce
Signed-off-by: Manish Dewangan <manish@codeaurora.org>
ASM driver changes to configure render mode.
Based on configured render mode DSP decides to whether to use
Audio Master Mode or STC Master mode for rendering.
CRs-Fixed: 1112258
Change-Id: I01c7a172b899fd7e950f216732d12a2cb2c737e9
Signed-off-by: Manish Dewangan <manish@codeaurora.org>
Add support for DP PLL driver to bring up display port
on sdm630.
Change-Id: I075581be3c69841a7eb3909b28d5214728717f68
Signed-off-by: Narender Ankam <nankam@codeaurora.org>
PBS driver triggers the PBS event specified by the client
driver to execute the PBS RAM configuration. Enable it for
sdm660 targets.
Change-Id: I95c70295805d31506c864546b763bef8a5e7b4bf
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
To handle Cx peak current limit on SDM660, GPU needs
to call Cx ipeak driver APIs when it switches between
threshold points.
Cx ipeak driver will throttle cDSP frequency if all
the clients are running at their respective threshold
frequencies to limit Cx peak current.
Change-Id: I5ffcf1a42523072d2b8b7bc0022eb3cc067acbb9
Signed-off-by: Rajesh Kemisetti <rajeshk@codeaurora.org>
Updating min frequency for memlat voting from 787MHz to
1113MHz to avoid intermediate DDR frequency switching on
SDM630 target.
Change-Id: I4a66efcd3301c3662b48b11c11f83a97c6562f31
Signed-off-by: Nikhil Kumar Kansal <nkansal@codeaurora.org>
Add MBA carveout between ADSP & cDSP in sync with
v1 memory map.
Change-Id: I65af5e01af1e5dd3de7f0666017dcd82ea8f7293
Signed-off-by: Prakash Gupta <guptap@codeaurora.org>