Currently, we specify the size of payload that the panel needs
to send back via the MRPS command only for DCS/Generic long
read commands. Enable the MRPS command to be sent for short
commands also based on the return length of the payload expected.
Change-Id: I634a8e5d12a8ea8d0a8118f360aef27610b21c9c
Signed-off-by: Padmanabhan Komanduru <pkomandu@codeaurora.org>
When device goes into suspend, MDP driver will put pipeline into border
color only without staging any pipes. Similar pipeline is setup while
resuming the device. When MDP pipeline is in border color only, minimum
MDP clock requirement is based on mixer width. Currently MDP clock
calculations are skipped if number of layers staged are 0. This set MDP
to minimum clock rate and device under-runs. Fix this by allowing MDP
clock rate calculations even when number of staged layers are 0.
Change-Id: I1c00e00b0b4ac76866a7863293bf29d2bc6a423d
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
Update the dynamic fps configuration of the slave dsi controller
while updating the master controller itself. This fixes corruption issues
for dual dsi panels that have dynamic fps feature enabled.
Change-Id: Ibf4f49dcf7a228be839c511bae14e66d60340070
Signed-off-by: Siddhartha Agrawal <agrawals@codeaurora.org>
Scaling by 1 logic was complicated. After trying to understand
what use cases we were preventing with this check, we verified that
ppp is actually able to handle scaling by 1 with hw team. There
is no need for this check.
Change-Id: I9f3cda5e61740fffdbda92dc768a98796b9a8238
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
For cases such as the rotator interface, flags to
indicate retire fence file descriptors are not set.
Do not return error while copying these file descriptors
for such interfaces. This avoids the driver from setting
false positive error flags to user space processes in
usecases where retire fence fd is not present.
CRs-Fixed: 663793
Change-Id: I7918520764c364ee11f469ea757c38ef46bf93cd
Signed-off-by: Manoj Rao <manojraj@codeaurora.org>
Don't expect user space to validate for NULL ROI. DISPLAY_COMMIT
can be called by any module. So validate the ROI before
configuring MDP.
Change-Id: Iba52731e2c603f237099ad560773437bbfac112f
Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
Currently it is failing RGBA format though it is valid
condition.
Change-Id: I2ee26a4f3fbef3d001e5f9ff1ebdc7fd093c3a26
Signed-off-by: Jeevan Shriram <jshriram@codeaurora.org>
Add support for post processing features when power collapse
feature is enabled. Every time MDSS enters power collapse mode,
all the post processing registers will get reset to 0, hence we
need to restore those PP registers when MDSS comes out of power
collapse mode.
Change-Id: I4abb41f17f24a12dddf50e01d8f69db19a464f3b
Signed-off-by: Ping Li <quicpingli@codeaurora.org>
Using Fixed fps and v_total for BW calculations, it
results in underrun if dynamic fps and v_total is used.
Dynamic FPS change should be Mutex protected for
synchronization between read/write so that multiple
processes don’t change fps at the same time. Line
count should be checked to make sure we have sufficient
lines before we start programming FPS. Do not configure
new fps when vsync timeout happens. Add support for
FIFO empty recovery.
CRs-Fixed: 651333
Change-Id: Icff48a7f85755484a321f0de26d4816f895c367e
Signed-off-by: Justin Philip <jphili@codeaurora.org>
Signed-off-by: raghavendra ambadas <rambad@codeaurora.org>
In MDSS 1.8.0, bit 2 in intr enable and intr status register
is marked for WB2 which is different from the other targets.
Add changes to handle the same.
Change-Id: I76947bc218c897e121bb22fbda7aaa57723ec708
Signed-off-by: Kalyan Thota <kalyant@codeaurora.org>
Add code to set the backlight level to zero for blank event
and restore the backlight level to its previous value during
unblank event. This will fix any unexpected panel flicker
that might show up on the screen during panel ON sequence.
CRs-Fixed: 608091
Change-Id: I871a067b0cc40d893b8b7e5a25103ebb914f9b7a
Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
Signed-off-by: Benet Clark <benetc@codeaurora.org>
While calculating source and destination rect of a pipe for the
programmed ROI, consider FLIP flags set for the pipe.
Change-Id: I631453c26f443b08a23556f83195d9914e05b41d
Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
For better analysis, time stamp of xlog should synchronize with
the time stamp of printk. Use local_clock() to log time stamp.
CRs-Fixed: 673350
Change-Id: I00e456fdc35f5a85d8029d12f4507990444e2821
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
During panel unblank a kickoff is done to turn on the panel so that the
first update is not delayed. It is also used to give buffer to command
mode panel prior to enabling backlight prevent junk data from appearing.
In order to prevent release fence timeline from being signaled too
early we will increase the commit count. This allow next sync point
to be added to the appropriate point on timeline, instead of relying
on frame done being called before sync/commit calls.
Change-Id: I566f90b3013b59dedbe42bbb9fdf6fa37d65e779
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
Make sure the MDP clocks are turned on for register read
and write access when device comes out of power collapse mode.
Change-Id: Ibbfba8b33b85b247c82d2938322c09853528deba
Signed-off-by: Ping Li <quicpingli@codeaurora.org>
Notify post-processing features whenever there is a backlight change, so
that PP feature can update accordingly.
Change-Id: I2317088752444478bcfd9cf4f6acfa8553e85d30
Signed-off-by: Ping Li <quicpingli@codeaurora.org>
With source-split feature, a pipe can be staged across two layer
mixers (LM) and/or two pipes can be staged on a LM same stage. Current
implementation stages source split pipe into incorrect container index
for right LM. Similarly while un-staging it calculates incorrect index
if more than two pipes are staged on a single LM. Fix this to resolve
MDP pipeline hangs.
Change-Id: I89e0f5946cb330dc918641486728baea856de574
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
Print error code when file node allocation fails within
fence acquire logic. This helps to find the root cause
for file node allocation failure.
Change-Id: Ib6adb9f612f13cb56d8f43549722b78440f689f8
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
msm_ion_client_create doesn't actually do anything with its heap_mask
parameter. Remove it. Also remove the extra argument from an audio
function that wraps msm_ion_client_create.
The following semantic patch was used to generate this patch:
@@
expression E1, E2;
@@
msm_ion_client_create(
- E1,
E2)
@@
expression E1, E2;
@@
msm_audio_ion_client_create(
- E1,
E2)
Change-Id: I403a125a1715b29a3db1f27c993abe0bc6d3fb11
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Previously, the ad_info completion structure was initialized every
time ad_input was called, which reset the completion wait_queue. A
completion structure should only be initialized once, in order to
prevent any corruptions of the wait_queue. Instead, we initialize
the completion during dt probe so that the wait_queue is only
initialized once, and during ad_input, we use a safer INIT_COMPLETION
for resetting complete count.
Change-Id: If1fb7c9a9dec2ad1ec1f07b022bdeabe1af41b22
Signed-off-by: Benet Clark <benetc@codeaurora.org>
The bl_updated variable requires the BL lock. Otherwise, it can be
corrupted and cause backlight issues.
Change-Id: I55eb4b8d525765ede4f27a404f5c3f1f0b446719
Signed-off-by: Benet Clark <benetc@codeaurora.org>
There are potential deadlock between irq handler and
mdss_mdp_irq_enable() since both can acquire mdss_lock
before trying to grab local lock. Add koff_lock for kickoff
related function in addition to original clk_lock which used
for clock related function to reduce unnecessary lock contention.
CRs-Fixed: 665524
Change-Id: Iebc5023eb9dc99f2a2709379bfac67ec275046a7
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
In the current implementation, contiguous memory allocation
during bootup is removed and related changes were made in
frame buffer driver which is not backward compatible. With this
change, add backward compatibility to map to physically contiguous
memory when available which is allocated at bootup.
Change-Id: Ib1a595f2426dda8d3e1c5e50c71c35d3f45854b6
Signed-off-by: Jeevan Shriram <jshriram@codeaurora.org>
Allow user to specify the type when requesting an overlay pipe.
If field is set the pipe type indication in the flags will be
ignored.
Change-Id: Iee51d24b96c7a2a987dc70a439342e6548dfc8fa
Signed-off-by: Vinu Deokaran <vinud@codeaurora.org>
When MDSS is idle power-collapsed, any events that require hardware
programming should result in exiting idle power collapse. Currently,
this is only done whenever a screen udpate happens. However, it is
possible that other APIs may be called prior to the actual screen
update. To address these cases, add the exit sequence call at the
interface level as well.
Change-Id: I162e1c1c4137a2ba20ed0b76f0c182c2c931cc87
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
DSI Ultra Low Power State (ULPS) mode is property of the DSI data
and clock lanes. Current implementation requires the MDP command
interface to send explicit events to the DSI controller to config
ULPS mode. However, it would be a lot more efficient if the DSI
controller would independently decide to enter/exit ULPS based on
whether the link clocks are enabled or not. This also ensures that
if any DCS commands need to be sent when ULPS is enabled, the DSI
controllers will exit ULPS accordingly.
Change-Id: If8d5b7039b5e104bcee5304c7c0ddb3cdd5bbcbc
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
RT/NRT feature splits the AXI traffic over two AXI ports.
By diverting RT/NRT traffic to individual AXI ports, NRT
traffic can be throttled by NOC at SoC level based on AXI
port#. Having this capability can help tweak QoS based on
use-cases.
This change adds support to identify real time and
non-real time clients and acocrdingly program HW to take
care of routing the RT/NRT traffic to respective AXI ports.
Change-Id: Ic5d94423f125226539db9e21bc095dba803cc63e
Signed-off-by: Radhika Ranjan Soni <rrsoni@codeaurora.org>
Unstage pipe from right mixer also if pipe staging
fails due to any error. This removes the invalid pipe
usage on right mixer when source split is enabled.
Change-Id: Iac8365025630b71808ea3e0f6ec849964ef52b9c
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
For left+right partial update case, both pingpong_done are
enabled. The last pingpong_done will do the notification to
signal timeline to release buffer.
Change-Id: Ibfe115d3c9cc05cdc7f9171b9421e85f1cc56157
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
This patch adds l_roi and r_roi fields to display commit struct to
support partial update for dual DSI panels. Panel side
frame buffer's column, page address and DSI controller's
stream size are updated based on the ROI requested.
Change-Id: I70957c9ee1546448416441a8d0608fb00c3b92ca
Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
Signed-off-by: Siddhartha Agrawal <agrawals@codeaurora.org>
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
Add a frame buffer reference count check before calling
null commit to release the free list pipes. This avoids
unnecessary flickering on screen if a process tries to open
and close the fb node without performing any operation.
Change-Id: I96b824edccf27f0ddb796c420ef1feb49f65ddea
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
Add support for switching between dsi command mode and
video mode and vice versa at runtime. If the panel is
configured in video mode, it would be power efficient to
be able to dynamically switch to command mode on need
basis. This change adds the support by providing an IOCTL
to switch between video mode and command mode at runtime.
Change-Id: I573c063556d68d631fe27cc2d1447522eceb7f2a
Signed-off-by: Sandeep Panda <spanda@codeaurora.org>
Each VBIF client can be configured for its number of outstanding (OT)
transactions. Currently we can have as high as 13 of these VBIF clients
within MDP. OT configuration for these clients is spread across multiple
registers. Current implementation of rotator OT limit is not considering
these multiple registers which leads to incorrect OT limit configuration
for WB1 WR VBIF client. Fix this by adding logic to select correct
register offset.
Change-Id: I7b4f7ac37ff5c8a85f35dbeb6a6c450b157c4b3a
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
Frame buffer releases all allocated control nodes by calling
blank when its reference count reaches to zero. In error
case, caller might call prepare ioctl and lead to null
pointer dereference to calculate the layer mixer width. A null
condition check prevents such dereferencing call.
CRs-fixed: 664517
Change-Id: I3b65b48a67ab2efb9654457ca7901da6ef0d57be
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
BW calculation for single layer requires iterative search on how many
pipes are staged on a layer mixer. In the current implementation,
starting source split, container used to store staged pipes has two
entries per stage. Based on this maximum entries to search for single
layer has also increased. Update single layer iterative search based on
this new changes.
Change-Id: I2e65567fd795d71ca5ded0fa56c602267fe46768
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
Adding a performance flag in perf_tune params to run the
H/W at its peak. Useful for debugging from the user side.
Give following command in adb shell to turn it on:
echo 1 > /sys/kernel/debug/mdp/perf/perf_mode
To turn off:
echo 0 > /sys/kernel/debug/mdp/perf/perf_mode
Change-Id: I11d86b840952b9f1d167e426997d50caa35b35cf
Signed-off-by: Vineet Bajaj <vbajaj@codeaurora.org>
Max mixer width supported varies for different targets.
Add support for max mixer property in the device tree.
Change-Id: I2cbbb947eada13b89349702065d732dd54ed6ba3
Signed-off-by: Kalyan Thota <kalyant@codeaurora.org>
In the case when ESD status check fails with DSI ACK
errors, there is a chance of unclocked register access when
DSI_INTR_CTRL register is being set.
Change-Id: I629b4ec642a86369b6ed693bdc6f8b4260ec1f5d
Signed-off-by: Vineet Bajaj <vbajaj@codeaurora.org>
If there is some pipe to clean up, need wait for it be done to
make sure the pipe can be used for the second cycle and recover
mode can be executed.
Change-Id: Ifb3fdb152bc4bbf367b3d272aa0c88b1a0650c19
Signed-off-by: Ken Zhang <kenz@codeaurora.org>
ESD feature may need to check the status of the panel by reading specific
panel register depending on the panel. Add support for ESD status check
through status register read and to configure the method used for checking
panel status through panel dtsi entry.
CRs-Fixed: 660805
Change-Id: I13b11362722eb2ad379162944eafff04ec01d1cb
Signed-off-by: Shivaraj Shetty <shivaraj@codeaurora.org>
Split display configuration requires that lower and upper pipe
control registers get programmed accordingly. This change fixes
a missing configuration bit in one of the control registers.
Change-Id: I17c71c004dbf6807483f132cb22271230b27960c
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
Time out condition was hard coded to 60 fps. If dynamic fps
feature was used, an invalid timeout might occur.
Change-Id: I0abe52416c10ef4ae0af6f541d22c66f6c8a6b5e
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
In the current implementation, pm runtime status for the framebuffer
device changes to active when the overlay session is started. With idle
power collapse feature enabled, it is possible that the MDSS core could
be turned off prior to starting the overlay session depending on the
duration of the idle timeout. This may result in an invalid hardware
configuration leading to various target instabilities. Fix this by
holding a reference to the pm runtime when mdp overlay is turned on.
Similarly, when the userspace process is killed, wake up MDSS from idle
power collapse before shutting down the fb device.
Change-Id: Ie7748732fe76f9b2766da32b972e1e9fe7ff8751
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
Remove use of this mutex to allow multiple msm_fb ioctl calls.
Mutexes within the individual fb_ioctl calls already provide
the necessary locking.
This is based on android-msm-2.6.35 commit:
a809819d (msm_fb: display: Add delay kickoff to MDDI)
which in includes this change among others.
Change-Id: Iee68bf3556ab913f916868988f4adbad1ed6b2a0
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
FB clients are tracked using process id. The process id does
not match if open and close API callers are different. Track
the fb clients using file descriptor node id in such cases
and release all resources associated with that process id
gracefully.
CRs-fixed: 652449
Change-Id: I09c965a421197c6464a64684e9706f30df327882
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Currently chroma sample is calculated after calculation of plane
size and stride in case of rotation in H2V1/H1V2 formats. Fix
this to correct chroma sample before plane sizes and stride are
calculated.
Change-Id: I851d61034b465d48fd21bb4a015c103457dc7936
Signed-off-by: Jayant Shekhar <jshekhar@codeaurora.org>
Adding trace points for systrace at various points in
the driver.
Change-Id: I4783fd2982bddb7f111de9e064bcaff153eb1ce1
Signed-off-by: Adrian Salido-Moreno <adrianm@codeaurora.org>
Signed-off-by: Vineet Bajaj <vbajaj@codeaurora.org>
Add events to observe when bandwidth is requested,
when bandwidth is needed and when bandwidth is released
for command mode panels.
Change-Id: I56b8ce28683696bee50e9cd10351076c49e4a84c
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
Add tracing points in key points in driver.
Change-Id: Ie31e27be4890e2e7cd573c00dbf3f66fa9c62060
Signed-off-by: Adrian Salido-Moreno <adrianm@codeaurora.org>
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
[cip@codeaurora.org: Moved mdss_mdp_trace.h file location]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
