When rotation session involves an interlaced layer that is intended to be
deinterlaced by MDP, client is expected to pass in flag indicating rotator
needs to deinterlace content.
Change-Id: I27c009e32cd82e00713c20b3accb2efbe5587344
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
Add xlog to log the pipe ndx and layer count during
the async position update ioctl call.
Change-Id: Ic1d381e76d4894550a37210bbc4344dd614ac5fb
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
In the current scenario, when the sizes of data plane 0 and
the plane 0 matches, the data plane configuration is skipped
to avoid configuring it all the time. Add additional checks
when we skip the configuration to make sure all the data
planes are configured correctly.
Change-Id: Ife7def6d97933732469c14f053b81da9d7661731
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
When there are multiple IOMMU drivers in the system,
each one will be sitting on different busses. This
way, clients should be choosing the right bus to
declare their domain on. Once and for all, update
all the clients code to use proper bus abstraction
API msm_iommu_get_bus() to get right bus.
Change-Id: I5edf7037e7b1e4af6a559b6aeaa0b6de0976bf35
Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
[cip@codeaurora.org: Removed changes to
drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c,
drivers/media/platform/msm/camera_v2/common/cam_smmu_api.c,
drivers/media/platform/msm/vidc/venus_boot.c,
drivers/platform/msm/ipa/ipa_v2/ipa.c,
drivers/platform/msm/ipa/ipa_v3/ipa.c,
drivers/platform/msm/msm_11ad/msm_11ad.c]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
Previously, only the base mixercfg was used to determine if the pipe
is in use. The extn registers were not checked, resulting in faulty
checks for cursor and any pipe staged in stage6. Fix validation to
include checks for extn registers. And refactor, to get the mixer mask
from utility functions.
Change-Id: Id356fa3255d796abdc596cbfbae6604aa7cf57f0
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Remove all hw revision checks related to REV_200 from
mdp driver.
Change-Id: I31c18b9c91eb93946f777a4b276aec6c999dd337
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Set pixel drop CDM down sampling for the resolutions which
do not support average filtering.
Change-Id: Iee767c95cc584ea5ea039993d284400c7bacfbcb
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
The dsi hw config is parsed from the string passed from bootloader.
It is parsed based on the delimiter ':', but when a panel is booted
in simulator mode, an additional override parameter prefixed with '#'
is passed from bootloader. Fix the parsing to account for the override
parameter when simulator panels are used.
Change-Id: Id9d7419179048d8b564efbbb8ea238d987d6a83c
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
As of commit be2f6d25bb77 ("msm: mdss: dsi: create dsi clock manager")
dsi clock management was split into two clients: mdp and dsi. Cmd mode
interface uses the mdp client handle and everything else using dsi
client handle. When transitioning from one dsi mode to another, clocks
need to be rebalanced. In order to rebalance properly, mode switch is
required to vote using the dsi client handle. Modified input argument to
MDSS_EVENT_PANEL_CLK_CTRL to allow for client handle selection.
Change-Id: Id54d72de603e2115451a49fed961d01f4440c517
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflict]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
Commit cb78c355b9225b815302c721b8f410168cba4a84 ("msm:
mdss: Issue ctl sw reset when underrun happens") enables the
software underrun recovery for split display cases due to
hardware limitation. This limitation is not applicable to
8994, 8996 and all upcoming targets. This change skips the
recovery path when hardware supports it.
Change-Id: I09e17bb50749ea5a0ec32ed604adab7126434e59
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
PHY/PLL programming are handled by PHY/PLL driver. Remove any
programming done for PHY/PLL in HDMI Tx core driver.
Change-Id: I2d3a9311d7dc011b292a9fdfcb1424dbb435aedc
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
There is one recent change in MDP driver that removes the vsync handler
when device goes to suspend, and this change puts AD into an incorrect
state after suspend/resume. This change modify the AD implementation
to coordinate the MDP driver change mentioned above by adding the AD
vsync back during resume. This change also fix the state resetting
during AD off case.
Change-Id: Ic31a791fa6f8fe5ba731837f8d9808d20e2d31e6
Signed-off-by: Ping Li <pingli@codeaurora.org>
Regression in change I532587eaa763499c9d51909937339093cd74a8cf.
During DSI mode change we need to send dsc command with
CMD_REQ_COMMIT flag.
Change-Id: Ibc970c70c974cb020c05780f45341a9a99eb6e30
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
Reset supported HDMI resolutions list to contain at least
a default resolution on EDID parser initialization and on
each parser call. In corner cases of EDID read or parser
failures, driver should expose a default resolution to
other modules to continue with the HDMI initialization.
Change-Id: I75cb78577d327c0f042238e10379585111d8fd70
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflict]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
HDMI Tx core can be configured with multiple resolutions with
different pixel clocks. This needs PHY/PLL to be configured
with different settings. Reset PHY/PLL on every power on before
configuring new PHY settings to avoid any PLL lock issues.
Change-Id: I564305730105f3e54fbb504c20cce5b2eb9039b1
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
Assign and use the correct mixer_type in writeback start.
Change-Id: Iacb0424b1518eec7077d2c053222358cf6a38abb
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Currently, we configure max_pkt_size for every DCS read
command. Avoid sending max_pkt_size DCS command for every
DCS read by adding conditional check for the configured
max_pkt_size value for every DCS read.
Change-Id: If2c38794b0383a429f1b2b8f5fa48881bfaed0e4
Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
For every histogram collect in a split display configuration, a
concatenation scratch array was alloced in order to sum the histograms
of the multiple DSPPs. This change improves performance by removing the
allocation and summing the histograms into the histogram array of the
first DSPP in the split display.
Change-Id: Id07cdfc2175bdce0f3b662daa70a014986f73eb4
Signed-off-by: Benet Clark <benetc@codeaurora.org>
Previously, the PP driver assumed that there would be a DSPP for every
INTF mixer. However, this assumption does not hold true for all targets.
This change fixes the errors caused by assuming the 1:1 ratio and allows
all layer mixers to be programmed based on CTL configuration.
Change-Id: I15d03921c9b91212717417296e3a157e97b5113a
Signed-off-by: Benet Clark <benetc@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflict]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
add xlog debug messages for early clock gating feature.
Change-Id: Ie05476a4f574b4097ff6ebde849a07cdd1b4fed4
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
In the postprocessing ioctl, there is a configurable block parameter
which can be used to choose the logical display for the config. However,
the framebuffer device opened for the ioctl should be the display for
the config. Rather than deprecating the block parameter, this change
forces the block parameter to match the FB device used for the ioctl.
Change-Id: I76e100311ff8f3361e9c7b7759de78becd332685
Signed-off-by: Benet Clark <benetc@codeaurora.org>
msm8994 is no longer supported on the current code base. Remove msm8994
debug bus entry table to reduce the code size.
Change-Id: Ib6dea2b9add2c083fba213e96afcec88fe741455
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
Enable dumping of debug bus when fatal errors are encountered which
issues panic to the system.
Change-Id: I8c14b842bf4fe54d5418b123fe7d5ec1e1e59f8f
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
During fatal errors, XLOG handler is called which dumps certain
information, address, debug bus, xlog etc., into kernel logs and
other larger information, register dumps, into RAM. Remove debug bus
dumping from kernel logs to RAM and reduce information dumped into
kernel logs to minimal in order to prevent watch-dog bites.
Change-Id: Id21b1eae156ec37f8c0bf42bd51ecbff29d0ab8d
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
When downstream device cable is connected and disconnected
very quickly, or connect/disconnect processing takes more time
than expected, HPD state machine needs to be put into right state
to make sure HDMI is subsequently turned ON and OFF properly.
Change-Id: I96fbc454951b6bbf5af05b2b74a04f7ba4ddce11
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
While initializing modes, add additional check for empty timings list
and abort generating mode list if empty. Having empty list will lead
to setting an empty mode list, instead of keeping the default created
during framebuffer registration.
Change-Id: Ia03202d82d4e9a639a52e0e1b2ccbbdda3b6fcad
Signed-off-by: Adrian Salido-Moreno <adrianm@codeaurora.org>
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
In the current implementation, phase step calculation for chroma plane
is not considering chroma subsample and is reduced to half. This is
incorrect and needs to be reduced to half only when chroma sub sampling
is present. This change corrects the phase step calculations for the
chroma planes.
Change-Id: Ia909f909f699882b863efb17b5dded77e6fdb1b1
Signed-off-by: Jeevan Shriram <jshriram@codeaurora.org>
Validate wfd destination formats that make use of mdp writeback
interface.
Change-Id: I52b6faee259c4fcde733a96b7cc0b834eebe5ed9
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
When multiple panel timings are available and enumerating video mode
list, the configuration present in the modelist may differ from the
actual configuration in fb variable info. This may cause issues when
usermode does GET_VSCREENINFO/PUT_VSCREENINFO calls. Fix this by
updating variable info with current timing mode.
Change-Id: Id9d4068bdb4851ffb4bc7e218a0666d1bd64eebe
Signed-off-by: Adrian Salido-Moreno <adrianm@codeaurora.org>
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflict]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
For HDMI use cases where there are no PP blocks available, there
are currently error/warning logs explaining the same. Rather than
print an error, these use cases should be handled and a debug
log should be printed.
Change-Id: Ib416323b9816e9e7a723058faeb03c43da88f918
Signed-off-by: Benet Clark <benetc@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflicts]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
Previously, all split dsi panels had two panel files and border-right
of DSI0 and border-left of DSI1 was set to 0 and all the kernel
calculations were based on that assumption. Replicate the same
scenario with the new single file panel configs by changing the border
values accordingly while setting the values for each DSI. And, include
the border configs during pipe configuration.
Change-Id: If7f5ed4d71ddc2ca26a8be34566df768b1ed7a13
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
For DSI6G v1.4.0 and above, DSI controller has support to insert
NULL packets in the middle of pixel data or DMA packets to avoid
HS-LP-HS transitions. Add support to featurize this based on DT
property.
Crs-Fixed: 880973
Change-Id: I36acfe6d27a1d750a5af12c3d136df473abb4598
Signed-off-by: Padmanabhan Komanduru <pkomandu@codeaurora.org>
Signed-off-by: Siddhartha Agrawal <agrawals@codeaurora.org>
For DSI6G version 1.4.0 and above, for command mode use cases,
there is support in MDSS DSI to insert NULL packets automatically
between lines of a frame or High Speed DMA command burst to avoid
HS-LP-HS transitions in the middle of frame/DMA command transfer.
Add support for this in DSI driver.
Crs-Fixed: 880973
Change-Id: I468c2ea602d4c3efa0d8844c843840a15b631a3f
Signed-off-by: Padmanabhan Komanduru <pkomandu@codeaurora.org>
Signed-off-by: Siddhartha Agrawal <agrawals@codeaurora.org>
Dynamic fps change and video interface stop works in two
different thread. It is possible that video interface move
to stop state when dynamic fps thread is in process of
updating the fps information on the same interface.
This change acquires the stop mutex lock and releases it
at the end.
Change-Id: I94d279ea53acb7daa7b042829c0e31df758a6782
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
Commit a5f4c89e2774c070350039e3a9d9349908475a7c ("msm:
mdss: select mixer respective to ctl path for wb") tries
to reserve the initial mixer path for primary display
and use rest of the path for external and WB display.
It does not decrease the number of available mixers
after updating the mixer pool. This leads to invalid
memory access when all available mixers are in use.
Ideally, it should check the number of available dspp
which are reserved for primary display while allocating
the mixer for writeback path.
Change-Id: Ib97291d907dc8261005bca3cd947fd907f90d773
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
During the early wakeup event for command mode panels
the enable of power, clocks and restore of the
controllers status happen in a different thread
context. This can cause a race condition with
multiple threads that also try to enable the power
resources and assume that the status of the
controllers has been restored.
Prevent race condition for multiple threads trying
to enable the resources, by making sure that the
complete power on, clocks and restore of the
controllers happen before return from the first
call to enable the clocks. This fixes random ping pong
timeouts observed due above described race conditions.
Change-Id: Ie3607797994a5d4f533c4d4838718b0229e32dc6
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
Resource control lock mutex should not be held while
driver is waiting for the power work items to finish
since this can result in a deadlock.
Fix this by moving the mutex to only the area that
needs to be protected.
Change-Id: I91c440845a379a1e141178b043ad7adb33989ef2
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
Current code request the power transition during the
early wake up event even if the panel is off.
This is can cause problems due ctl is not valid at this
time or in some other race conditions it prevents the
bandwidth requests. This fix prevents that early wake up
is called during power off, fixing the null pointer
dereferences and mdp busy timouts errors.
Change-Id: Idc51d02aa34d794a38f6e3a82ae80d5afa3d58f4
Signed-off-by: Vinu Deokaran <vinud@codeaurora.org>
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
FB events are sent only for first pdata and not for the next
in split DSI cases. This is handled within each event separately.
Fix the event handler to send events for both pdata separately
in split DSI cases and avoid handling it within individual events.
Change-Id: I70edc88f0958af3a807eecf0211dc2d8cd26301c
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Correctly setup the proper return value in case the ulps feature
is disabled. If the ulps is disabled, the dsi clock functions return
an error causing a bootup failure.
Change-Id: I2650957a5d955f66b31bc1c5f373c146efc5c23b
Signed-off-by: Siddhartha Agrawal <agrawals@codeaurora.org>
When an application requests a particular minimum
HDCP encryption level, the kernel exposes an API
that informs the HDCP library of this change.
Add support for this API call.
Change-Id: I508a08f946c8d36a2567f3e7fba2e5b01e992e31
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
Add sysfs node to allow adding new resolution to the resolutions
database and let the system configure to that resolution.
Change-Id: I881be3cf9a441502e25c7501ea5d5cf456f2f58e
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
Fix linear format validation check during perf check
which happens during atomic validation stage. Current
invalid check may lead to perf validation failure and
switch to GPU composition.
Change-Id: Ie1782de2f770de9e10e9b25ad1914405402c2f5d
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
MDSS driver supports iommu dynamic attach only when splash
thread is enabled. Client might want to attach the iommu
dynamically without using splash thread to avoid blink for
video mode panel. That is possible by doing 1-to-1 memory
mapping before iommu attach and splash memory late release.
This change supports the dynamic memory mapping to avoid
splash thread. Release the splash memory in first commit
instead of first suspend resume.
CRs-fixed: 755804
Change-Id: I7dcb415644a54a4b80f700c4d0914511a5685830
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
Signed-off-by: Jayant Shekhar <jshekhar@codeaurora.org>
Writeback block needs secure destination flag configured
while it is writing content protected buffer. This change
updates the flag at validate time to keep reusing the same
path for secure and non secure display.
Change-Id: Ia58276b472429731cfc23158db105a6ae0d041be
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
HDMI 4k uses dual layer mixer controlled by a single controller,
but fails to set the split_lm flag appropriately. This leads to
false comparisons in few usecases. Set the split_lm flag, and
the associated structures appropriately for different HDMI
configurations.
Change-Id: I7a294bc0ad7a45b92b6aceebbd6efa9d5f09a8ca
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Whenever we disconnect HDMI or are performing a
reauthentication of HDCP 2.2, unload the HDCP
2.2 TZ app so the state of the app is completely
reset.
Change-Id: I4696c373b027e38eaa95a345c65a61c1d7f1bd2d
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
Sometimes during suspend due to some shared regulator, if DSI PHY
was not turned off properly, then DSI LANE control register might
store some stale values during resume and this might cause side
effects on panel during initialization sequence. So reset the DSI
lane control register during DSI host initialization.
Change-Id: Ib87281cc1346d88a83e7e26f7dc4951a0798276b
Signed-off-by: Sandeep Panda <spanda@codeaurora.org>
During "adb shell stop/start", CTL structure gets destroyed.
Add check for CTL pointer before trying to change resolution. Remove
additional frame rate and clock rate parsing since it already done
while parsing the timing settings. Initialize timing structure
entries to zero before updating the structure.
CRs-fixed: 873962
Change-Id: Iebb2168eef0e002b98afa46b510b028f8ea183b1
Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
