Guenter Roeck 9fcbabe209 xsysace: Fix error handling in ace_setup ... [ Upstream commit 47b16820c490149c2923e8474048f2c6e7557cab ] If xace hardware reports a bad version number, the error handling code in ace_setup() calls put_disk(), followed by queue cleanup. However, since the disk data structure has the queue pointer set, put_disk() also cleans and releases the queue. This results in blk_cleanup_queue() accessing an already released data structure, which in turn may result in a crash such as the following. [ 10.681671] BUG: Kernel NULL pointer dereference at 0x00000040 [ 10.681826] Faulting instruction address: 0xc0431480 [ 10.682072] Oops: Kernel access of bad area, sig: 11 [#1] [ 10.682251] BE PAGE_SIZE=4K PREEMPT Xilinx Virtex440 [ 10.682387] Modules linked in: [ 10.682528] CPU: 0 PID: 1 Comm: swapper Tainted: G W 5.0.0-rc6-next-20190218+ #2 [ 10.682733] NIP: c0431480 LR: c043147c CTR: c0422ad8 [ 10.682863] REGS: cf82fbe0 TRAP: 0300 Tainted: G W (5.0.0-rc6-next-20190218+) [ 10.683065] MSR: 00029000 <CE,EE,ME> CR: 22000222 XER: 00000000 [ 10.683236] DEAR: 00000040 ESR: 00000000 [ 10.683236] GPR00: c043147c cf82fc90 cf82ccc0 00000000 00000000 00000000 00000002 00000000 [ 10.683236] GPR08: 00000000 00000000 c04310bc 00000000 22000222 00000000 c0002c54 00000000 [ 10.683236] GPR16: 00000000 00000001 c09aa39c c09021b0 c09021dc 00000007 c0a68c08 00000000 [ 10.683236] GPR24: 00000001 ced6d400 ced6dcf0 c0815d9c 00000000 00000000 00000000 cedf0800 [ 10.684331] NIP [c0431480] blk_mq_run_hw_queue+0x28/0x114 [ 10.684473] LR [c043147c] blk_mq_run_hw_queue+0x24/0x114 [ 10.684602] Call Trace: [ 10.684671] [cf82fc90] [c043147c] blk_mq_run_hw_queue+0x24/0x114 (unreliable) [ 10.684854] [cf82fcc0] [c04315bc] blk_mq_run_hw_queues+0x50/0x7c [ 10.685002] [cf82fce0] [c0422b24] blk_set_queue_dying+0x30/0x68 [ 10.685154] [cf82fcf0] [c0423ec0] blk_cleanup_queue+0x34/0x14c [ 10.685306] [cf82fd10] [c054d73c] ace_probe+0x3dc/0x508 [ 10.685445] [cf82fd50] [c052d740] platform_drv_probe+0x4c/0xb8 [ 10.685592] [cf82fd70] [c052abb0] really_probe+0x20c/0x32c [ 10.685728] [cf82fda0] [c052ae58] driver_probe_device+0x68/0x464 [ 10.685877] [cf82fdc0] [c052b500] device_driver_attach+0xb4/0xe4 [ 10.686024] [cf82fde0] [c052b5dc] __driver_attach+0xac/0xfc [ 10.686161] [cf82fe00] [c0528428] bus_for_each_dev+0x80/0xc0 [ 10.686314] [cf82fe30] [c0529b3c] bus_add_driver+0x144/0x234 [ 10.686457] [cf82fe50] [c052c46c] driver_register+0x88/0x15c [ 10.686610] [cf82fe60] [c09de288] ace_init+0x4c/0xac [ 10.686742] [cf82fe80] [c0002730] do_one_initcall+0xac/0x330 [ 10.686888] [cf82fee0] [c09aafd0] kernel_init_freeable+0x34c/0x478 [ 10.687043] [cf82ff30] [c0002c6c] kernel_init+0x18/0x114 [ 10.687188] [cf82ff40] [c000f2f0] ret_from_kernel_thread+0x14/0x1c [ 10.687349] Instruction dump: [ 10.687435] 3863ffd4 4bfffd70 9421ffd0 7c0802a6 93c10028 7c9e2378 93e1002c 38810008 [ 10.687637] 7c7f1b78 90010034 4bfffc25 813f008c <81290040> 75290100 4182002c 80810008 [ 10.688056] ---[ end trace 13c9ff51d41b9d40 ]--- Fix the problem by setting the disk queue pointer to NULL before calling put_disk(). A more comprehensive fix might be to rearrange the code to check the hardware version before initializing data structures, but I don't know if this would have undesirable side effects, and it would increase the complexity of backporting the fix to older kernels. Fixes: 74489a91dd ("Add support for Xilinx SystemACE CompactFlash interface") Acked-by: Michal Simek <michal.simek@xilinx.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>		2019-05-16 19:45:02 +02:00
..
aoe	Revert "block: remove artifical max_hw_sectors cap"	2015-08-18 13:21:13 -07:00
drbd	drbd: skip spurious timeout (ping-timeo) when failing promote	2019-02-20 10:13:11 +01:00
mtip32xx	Revert "mtip32xx: use runtime tag to initialize command header"	2018-04-08 11:52:02 +02:00
paride	cdrom: do not call check_disk_change() inside cdrom_open()	2018-05-30 07:49:13 +02:00
rsxx	block: change ->make_request_fn() and users to return a queue cookie	2015-11-07 10:40:46 -07:00
xen-blkback	xen-blkback: don't leak stack data via response ring	2017-11-21 09:21:17 +01:00
zram	zram: close udev startup race condition as default groups	2018-11-27 16:08:01 +01:00
amiflop.c	block: drop owner assignment from platform_drivers	2014-10-20 16:20:18 +02:00
ataflop.c	ataflop: fix error handling during setup	2018-11-21 09:27:31 +01:00
brd.c	brd: Fix discard request processing	2016-04-12 09:08:53 -07:00
cciss.c	cciss: correct the non-resettable board list	2015-05-31 11:14:34 -07:00
cciss.h
cciss_cmd.h
cciss_scsi.c	scsi: Do not set cmd_per_lun to 1 in the host template	2015-05-31 18:06:28 -07:00
cciss_scsi.h
cpqarray.c	genirq: Remove the deprecated 'IRQF_DISABLED' request_irq() flag entirely	2015-03-05 20:53:06 +01:00
cpqarray.h
cryptoloop.c
DAC960.c	block: use pci_zalloc_consistent	2014-08-08 15:57:28 -07:00
DAC960.h
floppy.c	floppy: Do not copy a kernel pointer to user memory in FDGETPRM ioctl	2018-10-10 08:52:07 +02:00
hd.c	block: hd: remove deprecated IRQF_DISABLED	2014-10-01 08:16:07 -06:00
ida_cmd.h
ida_ioctl.h
Kconfig	nvme: move to a new drivers/nvme/host directory	2015-10-09 10:40:37 -06:00
loop.c	Revert "block/loop: Use global lock for ioctl() operation."	2019-05-16 19:44:52 +02:00
loop.h	Revert "block/loop: Use global lock for ioctl() operation."	2019-05-16 19:44:52 +02:00
Makefile	nvme: move to a new drivers/nvme/host directory	2015-10-09 10:40:37 -06:00
mg_disk.c	block: drop owner assignment from platform_drivers	2014-10-20 16:20:18 +02:00
nbd.c	nbd: ratelimit error msgs after socket close	2016-05-11 11:21:10 +02:00
null_blk.c	null_blk: use async queue restart helper	2015-12-28 13:07:09 -07:00
osdblk.c	mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd	2015-11-06 17:50:42 -08:00
pktcdvd.c	pktcdvd: Fix pkt_setup_dev() error path	2018-02-16 20:09:47 +01:00
ps3disk.c	block: Kill bio_segments()/bi_vcnt usage	2013-11-23 22:33:51 -08:00
ps3vram.c	block: change ->make_request_fn() and users to return a queue cookie	2015-11-07 10:40:46 -07:00
rbd.c	rbd: set max_segments to USHRT_MAX	2018-01-17 09:35:30 +01:00
rbd_types.h
skd_main.c	skd: Submit requests to firmware before triggering the doorbell	2017-09-27 11:00:14 +02:00
skd_s1120.h	skd: fix formatting in skd_s1120.h	2013-11-08 09:10:30 -07:00
smart1,2.h
sunvdc.c	sunvdc: Do not spin in an infinite loop when vio_ldc_send() returns EAGAIN	2019-02-20 10:13:06 +01:00
swim.c	swim: fix cleanup on setup error	2018-11-21 09:27:31 +01:00
swim3.c	block/swim3: Fix -EBUSY error when re-opening device after unmount	2019-02-20 10:13:13 +01:00
swim_asm.S
sx8.c	block: rename REQ_TYPE_SPECIAL to REQ_TYPE_DRV_PRIV	2015-05-05 13:40:03 -06:00
umem.c	block: change ->make_request_fn() and users to return a queue cookie	2015-11-07 10:40:46 -07:00
umem.h
virtio_blk.c	virtio_blk: fix panic in initialization error path	2017-08-11 09:08:58 -07:00
xen-blkfront.c	xen: features for 4.4-rc0	2015-11-04 17:32:42 -08:00
xsysace.c	xsysace: Fix error handling in ace_setup	2019-05-16 19:45:02 +02:00
z2ram.c	block: remove struct request buffer member	2014-04-15 14:03:02 -06:00