Fix 32bit compilation issues in DSI and HDMI pll driver.
Also avoid udelay of more than 2ms as it gives a fake
__bad_udelay reference at link-time on 32bit build.
Change-Id: I2681c0fb2a7d69ee8a3f9f6d18164c3cb482d2f7
Signed-off-by: Vishnuvardhan Prodduturi <vproddut@codeaurora.org>
Signed-off-by: Sandeep Panda <spanda@codeaurora.org>
Add support to bring up HDMI PLL on bridge chips with an external
1.8V supply by modifying the existing MSM8996v3 sequence.
Change-Id: I6c893f25e7bcf2900d0aa83d42ef314aab4b5746
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflicts]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
Reset pll_verf_cfg1 to default value of 0x10 before pll
start for msm8996 based on hardware recommendation.
Change-Id: I95a89c18de4f7eb65a8ea0a8e4810560ddb0b44f
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
These PLL codes are stored in memory in bootloader, so that pll driver
can use these pre-calibrated values to lock to a new frequency when
dynamic refresh rate feature is enabled.
Change-Id: I527e03aa3efcb3904dd6057cd2e63356062436ca
Signed-off-by: Jeevan Shriram <jshriram@codeaurora.org>
Before completing SW calibration of HDMI PLL on
msm8996 v2, poll C READY register for an increased
period to ensure that we do not mistakenly perform
software calibration when it is not needed.
Change-Id: I7ec25665700ecf20b9fe2337eb01015b1e156b9b
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
When using 4k resolutions at 60fps, the PLL
ready bit will take slightly longer than other
video modes. Increase the timeout value to
ensure that the PLL lock is successful. Also
modify the lane mode values to improve Shmoo
margin with low core voltage.
Change-Id: I9d65535b941e755fe706e4dd61cb357a7a62cdc2
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
In the V3 revision of MSM8996, there is a different
recommended power on sequence. Update this sequence for
MSM8996V3 only with the new sequence and calculations.
Change-Id: I29612a3a4c9d148df61169c091015079ada6b41c
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
Enable PLL resource only once in prepare. The current driver enables and
disables PLL resources multiple times during the course of prepare
routine.
Change-Id: I9fbf58e7e509dda55d8ec01ec7d305ccf1691f94
Signed-off-by: Vinu Deokaran <vinud@codeaurora.org>
DSI SSC enabled through dtsi. Both down spread and
center spread are supported. Default is down spread
when SSC enabled.
Change-Id: I4c5ef632e5442ef610444ea5439d4bb78541791b
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
Update SVS mode and driver level settings for
MSM8996v1 PLL locking sequence, based on Si
characterization.
Change-Id: Ic25e89f62b222847eef491a1c4138434ab2b38fe
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
Set up pll master/slave status base on both pll
GLBL_TEST_CTRL and CLKBUFLR_EN pll registers value.
Change-Id: Ic75e77d5fccb88613ebe435f97a39f5d745fb264
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
When audio driver requests the cable status, return that
the cable status is connected only when HDMI is powered.
This prevents audio from accessing HDMI registers when
HDMI clock is off.
Change-Id: Icc5016df731725de25b4ca86e2ac3632ab89d5bf
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
Current code does not increase the retire count during the
create fence. This results in the vsync handler not getting
created to report the vsync during kickoff.
Change-Id: I81373487142a6f501a58027a26a49a9949c56ee0
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
This change adds compat layer support to the atomic commit
ioctl for postprocessing.
Change-Id: I211f27d885aca0d8088c2baf14025ebf083fedfd
Signed-off-by: Benet Clark <benetc@codeaurora.org>
This change adds support for SSPP postprocessing using the
atomic commit ioctl. The configuration given as part of the
ioctl will be cached in the same pipe res as before, and the
register programming sequence will be called from the pipe
setup as before.
Change-Id: Ida8209f80e55e9d5009b5df4e55f787b4a85ddc0
Signed-off-by: Benet Clark <benetc@codeaurora.org>
As per the new qos strategy, overhead fudge factors are not needed and
thus remove related logic. Also as per the new qos implementation,
user-space program is responsible to passing on compression ratio when
they setup the pipeline. So cleanup current driver logic which makes
decision based on data path.
Change-Id: I3d4f7ab3749b5b8595ea322a0b5b25ba3187b660
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
Currently rotator driver is using input compression ratio for output.
This is not correct because it is possible to have different input and
output formats which changes compression ratios. Similarly for WFD, use
output compression ratio passed by user-space.
Change-Id: I63650bcbf9f02ddf3310aacdc27f009381775481
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
Currently there are two different data structure representing
multiplication factors. Replace internal one, mdss_fudge_factor, and
with the one shared with user-space, mult_factor.
Change-Id: I9e0dcc092b4f9033cbfcd7e185e642c922e29a27
Signed-off-by: Ujwal Patel <ujwalp@codeaurora.org>
Checking if HDCP is enabled will ensure that HDCP 2.2
is enabled, in which case hdcp ops will be available.
Removing redundant check for hdcp ops. This prevents an
error log when EINVAL is unnecessarily returned to
mdp_intf.
Change-Id: I3f63dbd70651b15b241df9f3ebd4c1aab231fced
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
Rotator was releasing all open rotator sessions whenever
pm_suspend was called. This resulted in rotator trying to access
memory that was freed after resume was called. We are now only
cancel all rotator request (rotator work items) on pm_suspend.
Change-Id: Ib63e49213e6fbdec216888e4e7d3fb29defa3903
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflict]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
MSM8996/8994/8992 is configured for split display
configuration as default option. However, bootloader
can override this configuration to single dsi by
selecting a single dsi panel on one of controller
and set "none" to another controller. This requires
hardware override.
Change-Id: I3e585079548e92f6d576615059987321dfad132a
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
For destination split panels driver should allow the client to enable
the post processing features for entire screen or one of the slpit
sides. Change adds support in post processing driver to allow the
clients to configure feature in split mode panels.
Change-Id: I2c84aa488205aaa17b5abd3bc26b975361967bba
Signed-off-by: Gopikrishnaiah Anandan <agopik@codeaurora.org>
Enable MMSS clamp control configuration during clock on and off cases
on DSI v1.04. This clamp configuration helps in retaining PHY register
configuration when the MDSS gdsc is toggled.
Change-Id: I403417442aedd394d4e8d7c4d20c361c2130dbb1
Signed-off-by: Jeevan Shriram <jshriram@codeaurora.org>
DSI driver needs to disable pll and enable clamps before entering into
low power state. Since the PLL disable is configuring GLBL_TEST_CNTRL,
CLK_BUF PHY registers to 0, these registers are not restored after the
clamps are disabled. This change avoids configuring these registers
during PLL disable and gets disabled during dsi off.
Change-Id: Ia577099679f23cb9d0d42417863b6b3ad3af635b
Signed-off-by: Jeevan Shriram <jshriram@codeaurora.org>
For some resolutions on MSM8996 V2, PLL can become
unlocked at high operating temperatures. To prevent
this, use a VCO frequency of at least 8.9Ghz for bit
clocks of at least 282Mhz.
Change-Id: I409f286d23a924eab8bcd204638602e530597d77
Signed-off-by: Casey Piper <cpiper@codeaurora.org>
mdss smmu driver turns on the power rail during probe
and leave it on for continuous splash screen scenario.
It avoids extra refcount during attach for this scenario
by relaying on MDP handoff status. However, MDP handoff
status is updated before context banks are attached for
video mode panel. This adds extra refcount to power rails
and leave them on always. This fix moves the power rail
handoff to smmu structure instead of relying on MDP
status.
Change-Id: Ifc98c0e3812c7b78224f0167886dcb49dba3b267
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
Was using do_div improperly, this resulted in 0 bw vote from
rotator.
Change-Id: Iac1803631b674d6931b0dcbe45d65fd4740c36c9
Signed-off-by: Terence Hampson <thampson@codeaurora.org>
Previously, the atomic commit ioctl copies the entire kernel layer list
to the userspace layer list structure. The only parameter modified
during atomic commit should be the error code, and therefore, the
only value needed by userspace after the atomic commit ioctl returns.
Copying the kernel layer list structure causes the userspace to have
stale kernel pointer references to scale and PP info structures.
Change-Id: Ia8e96af21f7d9594a47d1503f3afef50a767971f
Signed-off-by: Benet Clark <benetc@codeaurora.org>
The compat layer for atomic commit is incorrectly using compat
pointers. This change adds correct support for copying all
nested compat pointers in the atomic commit structure. It also
returns the correct error value when copy_from_user fails.
Change-Id: If35a00583cfed105a16ffa547813c386314bff9b
Signed-off-by: Benet Clark <benetc@codeaurora.org>
When creating the framework for handling PP versioning, all PP features
were given interface update and space in the framework for handling
versioning. However, the CSC hardware will not change, and
therefore will not need any updates. This change removes the framework
update done for CSC.
Change-Id: Idc6c0b7ea62717ff1d1f2e4c827481e5db1976a8
Signed-off-by: Benet Clark <benetc@codeaurora.org>
Previously, the gamut caching code was not returning an error value when
an invalid table size was passed. This change will return error during
caching if the table size is invalid.
Change-Id: I212b345239543943670c2f03a0fc8376d31d1e86
Signed-off-by: Benet Clark <benetc@codeaurora.org>
MDP needs color space value to configure CSC matrix correctly. So
add color_space member in the mdp_input_layer structure.
Change-Id: I47ca556f8cfa8ef6c95fb0d77ef1510e3830a286
Signed-off-by: Sushil Chauhan <sushilchauhan@codeaurora.org>
During the controller configuration, some of the panel
timings could have been updated by the driver.
This change updates the panel information shared with the
upstream driver to keep updated the panel settings
that have changed after the controller setup.
Change-Id: I4d050d74f1aec50dbc294357ba0dace7c0940a16
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
Add factors for prefill calculations to the
capabilities exposed to the display driver
user space.
Change-Id: Ib479a5514978c8dec2376be4f2510bafb460af10
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
Add support to calculate the mdp prefill bandwidth
with simplified equation.
Change-Id: Icb9fd738a7aced7d59b8d59a78691e7316ef31c1
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
NULL check for req in dsi cmd list commit is misplaced, causing
race condition due to skipping of dsi cmd mdp busy check. This would
eventually result in underflow due to possible contention of using dsi
link. Fix the NULL check to avoid misbehavior.
Change-Id: I5999646d4db67efd0854b3db07e1d987e66c9cb5
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
When AD calibration mode is turned ON, an ioctl is sent to
set the mode to calibration in driver. However this does not
set the calibration mode backlight. So the backlight value
would remain 0. If bl is not set during calibration then upon
suspend resume the bl will remain as 0 and nothing would
appear on display.
Now initializing the calibration mode bl level to the bl
level when calibration mode was turned on.
Change-Id: Iecee61dc69815b673deb8610a524b07c4f4b9261
Signed-off-by: Krishna Chaitanya Parimi <cparimi@codeaurora.org>
Signed-off-by: Ping Li <pingli@codeaurora.org>
AD when set in calibration mode will block all backlight
updates from frameworks. Hence during suspend/blank the
backlight would not be 0 but will be set to the value
set in calibration mode.
Now this is changed as during suspend the backlight is
set to 0 within driver itself. This complicates things by
causing backlight to remain 0 post resume in calibration
mode. Now changing the behavior so that backlight is set
to 0 during suspend and set to the calibration set value
upon resume.
Change-Id: Id0b3919a7034875b3f3a606d00f462ceb21f40ee
Signed-off-by: Krishna Chaitanya Parimi <cparimi@codeaurora.org>
Remove few ioctls and changes related to it as they are obsolete now.
Change-Id: I26ad6609f8a1b3b2f8f549b82c330e5db7e5b44c
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Current implementation updates the DSI link clock rate during UNBLANK.
By this time link rate is already set with a random value, which
might lead to unexpected behaviour. Update the clock during LINK READY
so that the new values take effect.
Change-Id: Ib6d3f27b5607adb1d47ec5b8094af4f280424c2b
Signed-off-by: Anusha Koduru <kanusha@codeaurora.org>
Ioctls which modifies the commit data structures needs to wait for
kickoff before it is handled. The cursor and set/get metadata ioctls
were made to wait on pan idle, which makes it impossible to get through
when there are lot of panel updates. Move these ioctls to wait for
kickoff as these not necessarily needs the panel to be idle.
Change-Id: I417a88b434fcc8abd43654f3856bc7ca3639a50c
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
Starting with the change: "msm: mdss: use compression
ratio factors passed by user space"; compression ratio
factors are now assigned and passed by user space, so
kernel side does not need to assign the compression ratio
factors anymore. This change removes the deprecated
kernel code that was assigning the compression ratio.
Change-Id: I93e7afefa99198d947746df4a6962d0bb3508375
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflicts]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
Use the compression ratio factors shared by user space
to reduce the bandwidth calculations and vote for the
reduced throughput when compressed formats
are used.
Before this change kernel estimated the compression
ratio factors to reduce the bandwidth in the compressed
formats, after this change user space will set the
compression factors and kernel will use those for
bandwidth calculations.
Change-Id: I00fc0b9f526e7ff400740d48f42f6404737eae32
Signed-off-by: Ingrid Gallardo <ingridg@codeaurora.org>
[cip@codeaurora.org: Resolved merge conflict]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
Expose new ioctl for updating the layer position asynchronously.
Initially, pipes should be configured with async_update flag set
during the atomic commit, after which any number of position update
calls can be made. This would enable multiple position updates
within a single vsync. However, the screen update would happen
only after vsync, which would pick the latest update. Currently,
supported for video mode panels with single LM or dual LM with
src_split enabled. Only position updates are possible with no
scaling/cropping and each async layer should have unique z_order.
Change-Id: Ibb2804b59c6c980411396120e63167f18df5bc5b
Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>
[cip@codeaurora.org: Resolved out-of-order merge conflict]
Signed-off-by: Clarence Ip <cip@codeaurora.org>
Make HDCP 2.2 work with Trustzone QSEECOM driver that handles interaction
with the HDCP secure app that actually runs HDCP authentication protocol.
The current HDCP 2.2 driver is designed to run with a Trustzone module in
userspace that uses sysfs nodes to communicate with this driver. With
Trustzone QSEECOM driver now available to communicate with HDCP secure app
in TZ, make use of its features to communicate with the secure app.
Change-Id: Ifd66785e40c28fd161b82477ebef2b5829005875
Signed-off-by: Alhad Purnapatre <alhadp@codeaurora.org>
Userspace clients will enable the histogram and disable it as per the
algorithm requirements. If the process under which the client is
running crashes and restarts states of histogram between client and
driver is not in sync. In case the driver is not in sync with client it
should return EBUSY error to client. Client will stop and start the
histogram to maintain the sync.
Change-Id: I7b3c8d7890d8ca24ecf065e48a9ea5884cc886de
Signed-off-by: Gopikrishnaiah Anandan <agopik@codeaurora.org>
Non-uniform mapping mode is configurable parameter exposed by MDP.
Driver should provide the option to gamut clients to configure the
mapping. Change updates the interface to expose the parameter and
programs the gamut registers based on user setting.
Change-Id: I71e7e0f7443da7856b0d03e6b2799f9380274893
Signed-off-by: Gopikrishnaiah Anandan <agopik@codeaurora.org>
